Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-build-channels into lp:launchpad

2018-03-08 Thread William Grant
Review: Approve code Diff comments: > === modified file 'lib/lp/snappy/interfaces/snap.py' > --- lib/lp/snappy/interfaces/snap.py 2017-08-22 11:36:30 + > +++ lib/lp/snappy/interfaces/snap.py 2018-02-08 13:37:58 + > @@ -281,17 +282,23 @@ > @operation_parameters( >

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad-buildd/log-build-url into lp:launchpad-buildd

2018-03-08 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad-buildd/log-build-url into lp:launchpad-buildd. Commit message: If Launchpad passes a build_url item in the extra build arguments, then emit it at the start of the log. Requested reviews: Launchpad code reviewers (launchpad-reviewers)