[Launchpad-reviewers] [Merge] lp:~twom/launchpad/precache-gitrepository-branch-queries into lp:launchpad

2018-09-05 Thread Tom Wardill
Tom Wardill has proposed merging lp:~twom/launchpad/precache-gitrepository-branch-queries into lp:launchpad. Commit message: Precache gitrepository voting summary data Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

Re: [Launchpad-reviewers] [Merge] lp:~tobijk/launchpad-buildd/launchpad-buildd-bionic into lp:launchpad-buildd

2018-09-05 Thread Colin Watson
Review: Needs Fixing Thanks for working on this! As well as the inline comments I've left, I'm pretty sure that this is going to need changes to the test suite. Diff comments: > === modified file 'lpbuildd/target/lxd.py' > --- lpbuildd/target/lxd.py2018-06-12 23:23:13 + > +++

[Launchpad-reviewers] [Merge] lp:~tobijk/launchpad-buildd/launchpad-buildd-bionic into lp:launchpad-buildd

2018-09-05 Thread Tobias Koch
Tobias Koch has proposed merging lp:~tobijk/launchpad-buildd/launchpad-buildd-bionic into lp:launchpad-buildd. Commit message: bionic compatibility Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/charms/precise/squid-forwardproxy/dns-v4-first into lp:~canonical-launchpad-branches/charms/precise/squid-forwardproxy/trunk

2018-09-05 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/charms/precise/squid-forwardproxy/dns-v4-first into lp:~canonical-launchpad-branches/charms/precise/squid-forwardproxy/trunk. Commit message: Add dns_v4_first configuration option. Requested reviews: Launchpad code reviewers