Re: [Launchpad-reviewers] [Merge] ~lgp171188/launchpad:charm-launchpad-scripts-bzrsyncd into launchpad:master

2023-07-05 Thread Ines Almeida
LGTM, only a few minor comments. I don't feel comfortable being the sole reviewer though, so I'll leave the approval for someone else :) Diff comments: > diff --git a/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml > b/charm/launchpad-scripts-bzrsyncd/charmcraft.yaml > new file mode 100644 >

[Launchpad-reviewers] [Merge] ~lgp171188/launchpad:charm-launchpad-scripts-bzrsyncd into launchpad:master

2023-07-05 Thread Guruprasad
Guruprasad has proposed merging ~lgp171188/launchpad:charm-launchpad-scripts-bzrsyncd into launchpad:master. Commit message: charm: Implement the launchpad-scripts-bzrsyncd charm Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

[Launchpad-reviewers] [Merge] ~ines-almeida/txpkgupload:update-gitignore into txpkgupload:master

2023-07-05 Thread Ines Almeida
Ines Almeida has proposed merging ~ines-almeida/txpkgupload:update-gitignore into txpkgupload:master. Commit message: Update .gitignore Ignore `.charm` files and `/venv` directory, and sort list alphabetically Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more

[Launchpad-reviewers] [Merge] ~pelpsi/txpkgupload:txpkgupload-charm into txpkgupload:master

2023-07-05 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/txpkgupload:txpkgupload-charm into txpkgupload:master. Commit message: Txpkgupload charm created Listens to FTP and SFTP requests, and processes uploads files into a temporary directory This is a subordinate charm, so it will need a master that