[Launchpad-reviewers] [Merge] ~lgp171188/lp-source-dependencies:add-waitress-2.1.2 into lp-source-dependencies:master

2024-02-01 Thread Guruprasad
The proposal to merge ~lgp171188/lp-source-dependencies:add-waitress-2.1.2 into lp-source-dependencies:master has been updated. Description changed to: Related Launchpad MP - https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/459895 For more details, see:

[Launchpad-reviewers] [Merge] ~lgp171188/lp-source-dependencies:add-waitress-2.1.2 into lp-source-dependencies:master

2024-02-01 Thread Guruprasad
Guruprasad has proposed merging ~lgp171188/lp-source-dependencies:add-waitress-2.1.2 into lp-source-dependencies:master. Commit message: Add waitress 2.1.2 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

[Launchpad-reviewers] [Merge] ~lgp171188/lp-source-dependencies:remove-unused-versions-of-pyyaml into lp-source-dependencies:master

2024-02-01 Thread Guruprasad
The proposal to merge ~lgp171188/lp-source-dependencies:remove-unused-versions-of-pyyaml into lp-source-dependencies:master has been updated. Description changed to: For more details, see: https://code.launchpad.net/~lgp171188/lp-source-dependencies/+git/lp-source-dependencies/+merge/459893

[Launchpad-reviewers] [Merge] ~lgp171188/launchpad:upgrade-waitress-to-2.1.2-critical-security-fix into launchpad:master

2024-02-01 Thread Guruprasad
The proposal to merge ~lgp171188/launchpad:upgrade-waitress-to-2.1.2-critical-security-fix into launchpad:master has been updated. Description changed to: Related lp-source-dependencies MP - https://code.launchpad.net/~lgp171188/lp-source-dependencies/+git/lp-source-dependencies/+merge/459896

[Launchpad-reviewers] [Merge] ~lgp171188/launchpad:upgrade-waitress-to-2.1.2-critical-security-fix into launchpad:master

2024-02-01 Thread Guruprasad
Guruprasad has proposed merging ~lgp171188/launchpad:upgrade-waitress-to-2.1.2-critical-security-fix into launchpad:master. Commit message: Upgrade waitress to 2.1.2 to fix multiple security issues See https://docs.pylonsproject.org/projects/waitress/en/latest/index.html#change-history.

[Launchpad-reviewers] [Merge] ~lgp171188/lp-source-dependencies:remove-unused-versions-of-pyyaml into lp-source-dependencies:master

2024-02-01 Thread Guruprasad
The proposal to merge ~lgp171188/lp-source-dependencies:remove-unused-versions-of-pyyaml into lp-source-dependencies:master has been updated. Description changed to: Related Launchpad MP - https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/459895 For more details, see:

[Launchpad-reviewers] [Merge] ~lgp171188/lp-source-dependencies:remove-unused-versions-of-pyyaml into lp-source-dependencies:master

2024-02-01 Thread Guruprasad
Guruprasad has proposed merging ~lgp171188/lp-source-dependencies:remove-unused-versions-of-pyyaml into lp-source-dependencies:master. Commit message: Remove PyYAML 5.3.1 and 5.4.1 These are not used any more Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master

2024-02-01 Thread Dimitri John Ledkov
i think having a realistic filename will help tracing & finding this with `git grep` later Diff comments: > diff --git a/lpbuildd/tests/test_snap.py b/lpbuildd/tests/test_snap.py > index 0e44093..42834a3 100644 > --- a/lpbuildd/tests/test_snap.py > +++ b/lpbuildd/tests/test_snap.py > @@ -255,6

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master

2024-02-01 Thread Simone Pelosi
Thank you for you review! Sure, I was not so clear. Test here is testing a build with a component and checks if the component is added correctly to the waiting files. I came up with that solution when Dimitri (xnox) asked why the `.comp` file generated by this build

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master

2024-02-01 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master has been updated. Commit message changed to: Added support for snap components `.comp` files must be added to file cache. Snap components and `.comp` file type:

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master

2024-02-01 Thread Jürgen Gmach
Oh, and btw... how do you know you have to add .comp files? That is also valuable information. -- https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/459807 Your team Launchpad code reviewers is requested to review the proposed merge of

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master

2024-02-01 Thread Jürgen Gmach
I think this should probably work, but without context it is hard to tell what is going on. Is there any official information about Snap components and maybe even what .comp file is looking like? If so, please link to it in the commit message and in a proper spot in our code base. If there is

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master

2024-02-01 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master. Commit message: Added support for snap components `.comp` files must be added to file cache. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more