Thanks a lot for the MP! We are on the right track!
As we went with the approach to handle both cases inside a single mixin, we
really, really want to have a good class docstring to explain that there are
two proxies involved.
Also we should add a comment or a paragraph in the docstring which
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Merged
For more details, see:
Review: Approve
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/461806
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:master.
___
Mailing list:
Diff comments:
> diff --git a/lib/lp/buildmaster/downloader.py
> b/lib/lp/buildmaster/downloader.py
> index fc16852..cee308a 100644
> --- a/lib/lp/buildmaster/downloader.py
> +++ b/lib/lp/buildmaster/downloader.py
> @@ -94,3 +110,24 @@ class RequestProcess(AMPChild):
> )
>
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
lp-fetch-service: add num_units to bundle
Requested reviews:
Canonical Launchpad Engineering (launchpad)
For more
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/461805
--
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service into
launchpad-mojo-specs:master.
Commit message:
lp-fetch-service: add num_units to bundle
Requested reviews:
Canonical Launchpad Engineering (launchpad)
For more details, see:
7 matches
Mail list logo
