[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:unembargo-bug-build-info-missing into launchpad:master

2024-04-19 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad:unembargo-bug-build-info-missing into launchpad:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/464705 -- Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:unembargo-bug-build-info-missing into launchpad:master

2024-04-19 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:unembargo-bug-build-info-missing into launchpad:master. Commit message: Unembargo build info Added buildinfo to unembargoed files. Added custom upload files to unembargoed files. Added a new endpoint buildMetadataFileUrls to retrieve chang

Re: [Launchpad-reviewers] [Merge] ~jugmac00/launchpad:expose-build-metadata-via-api into launchpad:master

2024-04-19 Thread Ines Almeida
Changing this MP to Rejected in favor of this one: https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/464697 -- https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/464639 Your team Launchpad code reviewers is requested to review the proposed merge of ~jugma

[Launchpad-reviewers] [Merge] ~jugmac00/launchpad:expose-build-metadata-via-api into launchpad:master

2024-04-19 Thread Ines Almeida
The proposal to merge ~jugmac00/launchpad:expose-build-metadata-via-api into launchpad:master has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/464639 -- Your team Launchpad code reviewers is reques

[Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:fetch-service-expose-build-metadata-url-api into launchpad:master

2024-04-19 Thread Ines Almeida
Ines Almeida has proposed merging ~ines-almeida/launchpad:fetch-service-expose-build-metadata-url-api into launchpad:master with ~ines-almeida/launchpad:fetch-service-buildd-manager-end-session as a prerequisite. Commit message: Expose the URL to download the metadata file of the fetch service

Re: [Launchpad-reviewers] [Merge] ~jugmac00/launchpad:expose-build-metadata-via-api into launchpad:master

2024-04-19 Thread Ines Almeida
Diff comments: > diff --git a/lib/lp/snappy/interfaces/snapbuild.py > b/lib/lp/snappy/interfaces/snapbuild.py > index 52019bf..fea9d5f 100644 > --- a/lib/lp/snappy/interfaces/snapbuild.py > +++ b/lib/lp/snappy/interfaces/snapbuild.py > @@ -370,6 +371,14 @@ class ISnapBuildView(IPackageBuildVie

[Launchpad-reviewers] [Merge] ~lgp171188/launchpad:update-publisher-multi-sign-archive-when-multiple-keys-available into launchpad:master

2024-04-19 Thread Guruprasad
Guruprasad has proposed merging ~lgp171188/launchpad:update-publisher-multi-sign-archive-when-multiple-keys-available into launchpad:master. Commit message: Sign the archive with all its OpenPGP signing keys If an archive has more than one OpenPGP signing key, sign the archive's metadata fi

[Launchpad-reviewers] [Merge] ~lgp171188/launchpad:set-up-ppa-update-keys-cronscript into launchpad:master

2024-04-19 Thread Guruprasad
Guruprasad has proposed merging ~lgp171188/launchpad:set-up-ppa-update-keys-cronscript into launchpad:master. Commit message: charm/launchpad-ppa-publisher: Add the PPA key updater cron job Also use a unique name for the ppa-update-keys cron script, Requested reviews: Launchpad code reviewers

Re: [Launchpad-reviewers] [Merge] ~jugmac00/launchpad:expose-build-metadata-via-api into launchpad:master

2024-04-19 Thread Jürgen Gmach
I updated the code - unfortunately once again without being able to run the tests. It is impossible to apply any meaningful changes without a working test environment. So we either need to merge this as is (after somebody has checked it out and ran the tests) and apply some changes later on (a

[Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into launchpad:master

2024-04-19 Thread Ines Almeida
The proposal to merge ~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into launchpad:master has been updated. Commit message changed to: Refactor buildd-manager: remove unneeded variables, rename and add comments - Removed the `/session` from the base URL for the fetch service c

[Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into launchpad:master

2024-04-19 Thread Ines Almeida
Ines Almeida has proposed merging ~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into launchpad:master. Commit message: Refactor buildd-manager: remove unneeded variables, rename and add comments Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more detai

[Launchpad-reviewers] [Merge] ~jugmac00/launchpad:fix-testing-docs into launchpad:master

2024-04-19 Thread Jürgen Gmach
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-testing-docs into launchpad:master. Commit message: Fix TempDir usage in testing docs Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~jugmac00/launchpad/+git/launchpa

Re: [Launchpad-reviewers] [Merge] ~jugmac00/launchpad:expose-build-metadata-via-api into launchpad:master

2024-04-19 Thread Simone Pelosi
I just add there what we found during the peer programming session :) Diff comments: > diff --git a/lib/lp/snappy/interfaces/snapbuild.py > b/lib/lp/snappy/interfaces/snapbuild.py > index 52019bf..46bd205 100644 > --- a/lib/lp/snappy/interfaces/snapbuild.py > +++ b/lib/lp/snappy/interfaces/snapb

Re: [Launchpad-reviewers] [Merge] ~jugmac00/launchpad:expose-build-metadata-via-api into launchpad:master

2024-04-19 Thread Ines Almeida
I know this isn't tested, but just a initial review! Diff comments: > diff --git a/lib/lp/snappy/interfaces/snapbuild.py > b/lib/lp/snappy/interfaces/snapbuild.py > index 52019bf..46bd205 100644 > --- a/lib/lp/snappy/interfaces/snapbuild.py > +++ b/lib/lp/snappy/interfaces/snapbuild.py > @@ -370