Andrey Fedoseev has proposed merging
~andrey-fedoseev/launchpad:snap-base-features into launchpad:master.
Commit message:
Use `SnapBase.features` in `snapcraft.yaml` parser
to determine whether duplicate build-on values are allowed instead of relying
on snap base name
Requested reviews:
This is a new nullable column that's been added recently
On Fri, Oct 7, 2022, 11:59 Jürgen Gmach
wrote:
> How did they land in the database in the first place?
>
> Could we convert them to empty dicts?
> --
>
> https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/431181
>
How did they land in the database in the first place?
Could we convert them to empty dicts?
--
https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/431181
Your team Launchpad code reviewers is requested to review the proposed merge of
None is an existing value in the database that we need to account for.
On Fri, Oct 7, 2022, 11:17 Jürgen Gmach
wrote:
> I do not know what a SnapBase is, and the docstring for ISnapBase isn't
> helpful at all ("A base for snaps."), but I still wonder whether we could
> initialize `features` as
I do not know what a SnapBase is, and the docstring for ISnapBase isn't helpful
at all ("A base for snaps."), but I still wonder whether we could initialize
`features` as an empty dict, so we could save us those `is None` checks.
--
Andrey Fedoseev has proposed merging
~andrey-fedoseev/launchpad:snap-base-features into launchpad:master.
Commit message:
Fix the case when `SnapBase.feature` is `None`
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
Andrey Fedoseev has proposed merging
~andrey-fedoseev/launchpad:snap-base-features into launchpad:master.
Commit message:
Add `ISnapBase.features` field
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
7 matches
Mail list logo
