Colin Watson has proposed merging ~cjwatson/lp-archive:charm-fix-part-name into lp-archive:main.
Commit message: charm: Fix final part name Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp-archive/+git/lp-archive/+merge/448500 The example in https://juju.is/docs/sdk/charmcraft-yaml#heading--the-reactive-plugin calls the final (and in that case only) part "charm". I'd thought that was just an example. However, as of https://github.com/canonical/charmcraft/commit/35adadf42c625c5ee5ed6d611c9bdec10413ae59 in charmcraft 2.4.0, calling the final part anything else causes charms to be misbuilt; they end up containing unmodified copies of the top-level `actions.yaml`, `config.yaml`, and `metadata.yaml` files rather than merging the information provided by each layer. -- Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/lp-archive:charm-fix-part-name into lp-archive:main.
diff --git a/charm/lp-archive/charmcraft.yaml b/charm/lp-archive/charmcraft.yaml index 27b0e26..fc42982 100644 --- a/charm/lp-archive/charmcraft.yaml +++ b/charm/lp-archive/charmcraft.yaml @@ -29,7 +29,7 @@ parts: "*": ols-layers/ prime: - "-ols-layers" - lp-archive: + charm: after: - charm-wheels - ols-layers
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp