I pushed a few new commits after the demo this morning:
- The CSS file is now hosted locally
- Small update to the style of items in Launchpad
- Updates the icon colors slightly and added a new icon
- Updates the 'Launchpad' and 'Get Started' sections (see screenshots below)
Logged out:
Ines Almeida has proposed merging
~ines-almeida/launchpad:frontpage-revamp-change-layout into
~ines-almeida/launchpad:frontpage-revamp-remove-top-project.
Commit message:
ui: Launchpad homepage revamp
- Imported Vanilla framework directly to the homepage
- Re-organized homepage sections and
The proposal to merge ~ines-almeida/launchpad:frontpage-revamp-change-layout
into ~ines-almeida/launchpad:frontpage-revamp-remove-top-project has been
updated.
Status: Needs review => Work in progress
For more details, see:
Thank you all for the comments!
@petermakowski
Regarding impact on SEO, I ran lighthouse in the master branch and this one and
the scores are exactly identical (unfortunately, not incredibly high).
For reference, the scores were:
- Performance: 36
- Accessibility: 76
- Best pratices: 68
-
> These are the same links, right?
Yes, probably a copy-paste error, updated the links now
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is requested to review the proposed merge of
*
- Annoynymous person (after): https://postimg.cc/21CmQF6P
- Logged in person (after): https://postimg.cc/21CmQF6P
*
These are the same links, right?
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is
Diff comments:
> diff --git a/lib/lp/app/templates/root-index.pt
> b/lib/lp/app/templates/root-index.pt
> index ee51d55..2a6ffcf 100644
> --- a/lib/lp/app/templates/root-index.pt
> +++ b/lib/lp/app/templates/root-index.pt
> @@ -6,48 +6,7 @@
>metal:use-macro="view/macro:page/main_only"
>
> Could you also update copyright string? (from 2004-2023 to 2004-2024)
Done in a separate MP:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460927
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is
It looks good! Could you also update copyright string? (from 2004-2023 to
2004-2024)
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is requested to review the proposed merge of
A few screenshots:
- Annonymous person (before): https://postimg.cc/MX4vm42g
- Annoynymous person (after): https://postimg.cc/21CmQF6P
- Logged in person (after): https://postimg.cc/21CmQF6P
These screenshots were taken before removing the "See more..."
button, but the remaining should look
10 matches
Mail list logo
