I have addressed your review comments, Andrey.
--
https://code.launchpad.net/~lgp171188/lpcraft/+git/lpcraft/+merge/433493
Your team Launchpad code reviewers is requested to review the proposed merge of
~lgp171188/lpcraft:easier-way-to-add-a-ppa into lpcraft:main.
Diff comments:
> diff --git a/lpcraft/config.py b/lpcraft/config.py
> index d8d2045..f60cbc2 100644
> --- a/lpcraft/config.py
> +++ b/lpcraft/config.py
> @@ -126,12 +135,57 @@ class PackageRepository(ModelConfigDefaults):
> """
>
> type: PackageType # e.g. `apt``
> +ppa:
Diff comments:
> diff --git a/lpcraft/config.py b/lpcraft/config.py
> index d8d2045..f60cbc2 100644
> --- a/lpcraft/config.py
> +++ b/lpcraft/config.py
> @@ -119,6 +121,13 @@ class PackageSuite(str, Enum):
> jammy = "jammy" # 22.04
>
>
> +class
Diff comments:
> diff --git a/lpcraft/config.py b/lpcraft/config.py
> index d8d2045..f60cbc2 100644
> --- a/lpcraft/config.py
> +++ b/lpcraft/config.py
> @@ -119,6 +121,13 @@ class PackageSuite(str, Enum):
> jammy = "jammy" # 22.04
>
>
> +class
Guruprasad has proposed merging ~lgp171188/lpcraft:easier-way-to-add-a-ppa into
lpcraft:main.
Commit message:
Allow specifying PPAs using the shortform notation
LP: #1982950
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1982950 in lpcraft: "Adding
5 matches
Mail list logo