The proposal to merge lp:~jcsackett/launchpad/remove-bad-subscribers into
lp:launchpad has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/remove-bad-subscribers/+merge/117771
--
Review: Needs Information code
Hi Jon.
As Steven's and Ian's work to honour structural subscriptions is completing,
the focus on subscribing roles will soon be mute. I do not want to abandon your
work though. The removal of
test_transition_to_private_grants_subscribers_access demonstrates
1. I think the preservation of existing driver subscriptions is good.
Maybe the code can be DRY if `required_subscribers.add(pillar.driver)`
was in the ` if information_type in PRIVATE_INFORMATION_TYPES` block
Sure, that's doable; it also needs the !ubuntu check on it.
2. Is the bug
Review: Approve code
Thank you. You can land this when you are satisfied with the driver.
--
https://code.launchpad.net/~jcsackett/launchpad/remove-bad-subscribers/+merge/117771
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
The proposal to merge lp:~jcsackett/launchpad/remove-bad-subscribers into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/remove-bad-subscribers/+merge/117771
--
j.c.sackett has proposed merging lp:~jcsackett/launchpad/remove-bad-subscribers
into lp:launchpad.
Requested reviews:
Curtis Hovey (sinzui)
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/remove-bad-subscribers/+merge/117771
Summary
===
Currently, if a bug is
6 matches
Mail list logo
