[Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-28 Thread noreply
The proposal to merge lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel has been updated. Status: Approved = Merged -- https://code.launchpad.net/~jcsackett/launchpad/unknown-translations-service-643545-0/+merge/36464 Your team Launchpad code reviewers

Re: [Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-24 Thread Guilherme Salgado
Review: Approve ui* This is probably unrelated to your changes, but I thought I'd mention anyway: when looking at https://translations.launchpad.dev/kubuntu anonymously I see only the one sentence stating LP doesn't know about translations for it, but when I'm logged in as an admin I see all

Re: [Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-24 Thread Curtis Hovey
Review: Approve ui The issues about what the admin sees are indeed questions for the translations team. I have a question to add. U believe Ubuntu is the only distro that can be translated because it is the only distro that soyuz builds...Shouldn't the options be unknown, or external? you

Re: [Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-24 Thread j.c.sackett
I have a question to add. U believe Ubuntu is the only distro that can be translated because it is the only distro that soyuz builds...Shouldn't the options be unknown, or external? As opposed to Unknown, External and Not Applicable? I thought not doing translations was a valid choice for

Re: [Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-24 Thread j.c.sackett
This is probably unrelated to your changes, but I thought I'd mention anyway: when looking at https://translations.launchpad.dev/kubuntu anonymously I see only the one sentence stating LP doesn't know about translations for it, but when I'm logged in as an admin I see all the edit links

[Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-24 Thread Brad Crittenden
The proposal to merge lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel has been updated. Status: Needs review = Approved -- https://code.launchpad.net/~jcsackett/launchpad/unknown-translations-service-643545-0/+merge/36464 Your team Launchpad code

[Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-23 Thread j.c.sackett
The proposal to merge lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel has been updated. Description changed to: Summary === Begins the process of moving translations to use the translations_usage enum for enabling or disabling the app for a given

[Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-23 Thread Paul Hummer
The proposal to merge lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel has been updated. Status: Needs review = Approved -- https://code.launchpad.net/~jcsackett/launchpad/unknown-translations-service-643545-0/+merge/36464 Your team Launchpad code

[Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-23 Thread j.c.sackett
The proposal to merge lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel has been updated. Status: Approved = Needs review -- https://code.launchpad.net/~jcsackett/launchpad/unknown-translations-service-643545-0/+merge/36464 Your team Launchpad code

Re: [Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-23 Thread j.c.sackett
Data to test for UI: Distribution -- UNKNOWN Kubuntu (http://translations.launchpad.dev/kubuntu) Distroseries -- UNKNOWN Krunch (http://translations.launchpad.dev/kubuntu/krunch) Distribution -- LAUNCHPAD Ubuntu (http://translations.launchpad.dev/ubuntu) Distroseries -- LAUNCHPAD Hoary

[Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-23 Thread j.c.sackett
The proposal to merge lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel has been updated. Description changed to: Summary === Begins the process of moving translations to use the translations_usage enum for enabling or disabling the app for a given

Re: [Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel

2010-09-23 Thread j.c.sackett
Adding a diff here as a snapshot since I'm about to add sample data and it will totally bork the diff. -- https://code.launchpad.net/~jcsackett/launchpad/unknown-translations-service-643545-0/+merge/36464 Your team Launchpad code reviewers is requested to review the proposed merge of