[Launchpad-reviewers] [Merge] lp:~rharding/launchpad/yui35_test_fix2 into lp:launchpad

2012-08-14 Thread Richard Harding
Richard Harding has proposed merging lp:~rharding/launchpad/yui35_test_fix2 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1036313 in Launchpad itself: JS test failures under YUI 3.5.1

Re: [Launchpad-reviewers] [Merge] lp:~rharding/launchpad/yui35_test_fix2 into lp:launchpad

2012-08-14 Thread Curtis Hovey
Review: Approve code Thank you for these fixes. -- https://code.launchpad.net/~rharding/launchpad/yui35_test_fix2/+merge/119603 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

[Launchpad-reviewers] [Merge] lp:~rharding/launchpad/yui35_test_fix2 into lp:launchpad

2012-08-14 Thread Curtis Hovey
The proposal to merge lp:~rharding/launchpad/yui35_test_fix2 into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~rharding/launchpad/yui35_test_fix2/+merge/119603 --

Re: [Launchpad-reviewers] [Merge] lp:~rharding/launchpad/yui35_test_fix2 into lp:launchpad

2012-08-14 Thread Deryck Hodge
Review: Approve Just make sure to drop the asset.js head link and this is good to go. Thanks for dropping the StartsWith asserts from the earlier version of this! Looks good otherwise. -- https://code.launchpad.net/~rharding/launchpad/yui35_test_fix2/+merge/119603 Your team Launchpad code

[Launchpad-reviewers] [Merge] lp:~rharding/launchpad/yui35_test_fix2 into lp:launchpad

2012-08-14 Thread noreply
The proposal to merge lp:~rharding/launchpad/yui35_test_fix2 into lp:launchpad has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~rharding/launchpad/yui35_test_fix2/+merge/119603 --