Re: [Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/private-dupe-bug-warning-943497 into lp:launchpad

2012-07-24 Thread Richard Harding
Review: Approve Thanks Ian, love the cleanup and tests. I also didn't know about HTML_PARSER so awesome. #282/4 I'd make the module name just lp.bugs.duplicate(s). Think of it more like a python module. You have a class in there MarkBugDuplicate, and this module might contain other code later

Re: [Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/private-dupe-bug-warning-943497 into lp:launchpad

2012-07-24 Thread Ian Booth
Thanks for the great review. #282/4 I'd make the module name just lp.bugs.duplicate(s). Think of it more like a python module. You have a class in there MarkBugDuplicate, and this module might contain other code later so no sense pegging it tight. Agreed. #299 Can we move all the

[Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/private-dupe-bug-warning-943497 into lp:launchpad

2012-07-24 Thread noreply
The proposal to merge lp:~wallyworld/launchpad/private-dupe-bug-warning-943497 into lp:launchpad has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~wallyworld/launchpad/private-dupe-bug-warning-943497/+merge/116248 --

[Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/private-dupe-bug-warning-943497 into lp:launchpad

2012-07-23 Thread Ian Booth
Ian Booth has proposed merging lp:~wallyworld/launchpad/private-dupe-bug-warning-943497 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #943497 in Launchpad itself: warn when you are going to mark a public bug as a duplicate of a