I have introduced a new css class 'actionicon' which provides the required left
margin.
Where nbsp; were removed before the anchors in the markup, I have added the
new css class to the anchors.
I have also done some drive bt fixes on the product index page - the
programming languages edit icon
Review: Approve code
I think the values are interpolated in the wrong order on line 39. Fix the line
before merging your code.
--
https://code.launchpad.net/~wallyworld/launchpad/sprite-icon-spacing-1007263/+merge/108291
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
The proposal to merge lp:~wallyworld/launchpad/sprite-icon-spacing-1007263 into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/sprite-icon-spacing-1007263/+merge/108291
--
Review: Needs Information code
What sprite is not an action? I suppose it its sprites on non-anchors. The crux
of the issue is text + anchor is too close. The text is often wrapped in a span
so maybe we can use a sibling selector
span + a.sprite {margin-left: 6px;}
We might want to try this
4 matches
Mail list logo
