The proposal to merge lp:~stub/launchpad/botbake into lp:launchpad has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~stub/launchpad/botbake/+merge/319445
--
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
Review: Approve code
I'd marginally prefer that the team stuff were moved into an API script, but if
you don't care then this is fine.
--
https://code.launchpad.net/~stub/launchpad/botbake/+merge/319445
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
Diff comments:
>
> === added file 'lib/lp/registry/scripts/createbotaccount.py'
> --- lib/lp/registry/scripts/createbotaccount.py 1970-01-01 00:00:00
> +
> +++ lib/lp/registry/scripts/createbotaccount.py 2017-03-13 15:07:05
> +
> @@ -0,0 +1,129 @@
> +# Copyright 2017
Stuart Bishop has proposed merging lp:~stub/launchpad/botbake into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~stub/launchpad/botbake/+merge/319445
Command line tool to create bot accounts, for Canonical IS
The proposal to merge lp:~stub/launchpad/botbake into lp:launchpad has been
updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~stub/launchpad/botbake/+merge/319445
--
Your team Launchpad code reviewers is requested to review the proposed
I don't see anything obviously terrible here, though William should definitely
take a look as well.
Diff comments:
> === added file 'lib/lp/registry/scripts/createbotaccount.py'
> --- lib/lp/registry/scripts/createbotaccount.py 1970-01-01 00:00:00
> +
> +++
Stuart Bishop has proposed merging lp:~stub/launchpad/botbake into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~stub/launchpad/botbake/+merge/319445
Command line tool to create bot accounts, for Canonical IS
7 matches
Mail list logo
