The proposal to merge lp:~twom/launchpad/rework-git-permissions-for-shadowing
into lp:launchpad has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~twom/launchpad/rework-git-permissions-for-shadowing/+merge/357091
--
Your team Launchpad code
Review: Approve
Just a few minor tweaks, but otherwise this looks good and we can land it.
Diff comments:
>
> === modified file 'lib/lp/code/xmlrpc/git.py'
> --- lib/lp/code/xmlrpc/git.py 2018-10-17 10:09:33 +
> +++ lib/lp/code/xmlrpc/git.py 2018-10-18 16:43:51 +
> @@ -350,67 +355,58
Review: Needs Fixing
Diff comments:
>
> === modified file 'lib/lp/code/interfaces/gitrule.py'
> --- lib/lp/code/interfaces/gitrule.py 2018-10-16 15:29:37 +
> +++ lib/lp/code/interfaces/gitrule.py 2018-10-18 13:49:45 +
> @@ -71,6 +71,16 @@
>
> grants = Attribute("The access
Tom Wardill has proposed merging
lp:~twom/launchpad/rework-git-permissions-for-shadowing into lp:launchpad.
Commit message:
Rework git branch permissions to improve shadowing for multiple grants
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
4 matches
Mail list logo
