Review: Approve code
--
https://code.launchpad.net/~cjwatson/launchpad/snap-auto-build-code/+merge/297957
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
Review: Approve code
Diff comments:
>
> === modified file 'lib/lp/snappy/model/snap.py'
> --- lib/lp/snappy/model/snap.py 2016-05-28 00:21:40 +
> +++ lib/lp/snappy/model/snap.py 2016-06-29 15:47:32 +
> @@ -663,6 +689,55 @@
>
Review: Approve
Diff comments:
>
> === modified file 'lib/lp/code/browser/tests/test_branchlisting.py'
> --- lib/lp/code/browser/tests/test_branchlisting.py 2015-12-11 04:40:07
> +
> +++ lib/lp/code/browser/tests/test_branchlisting.py 2016-06-28 21:11:44
> +
> @@ -389,7 +387,6
Review: Needs Fixing
Diff comments:
> === modified file 'lib/lp/snappy/browser/snap.py'
> --- lib/lp/snappy/browser/snap.py 2016-05-28 00:21:40 +
> +++ lib/lp/snappy/browser/snap.py 2016-06-29 21:46:52 +
> @@ -369,6 +370,16 @@
> self.context.information_type in
Colin Watson has proposed merging lp:~cjwatson/launchpad/db-snap-channels into
lp:launchpad/db-devel.
Commit message:
Add Snap.store_channels column.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers): db
Related bugs:
Bug #1597819 in Launchpad itself: "Add option to
The proposal to merge lp:~cjwatson/launchpad/snap-auto-build-model into
lp:launchpad has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/snap-auto-build-model/+merge/297955
--
Your team Launchpad code reviewers is
Diff comments:
>
> === modified file 'lib/lp/snappy/model/snap.py'
> --- lib/lp/snappy/model/snap.py 2016-05-28 00:21:40 +
> +++ lib/lp/snappy/model/snap.py 2016-06-29 15:47:32 +
> @@ -663,6 +689,55 @@
> list(getUtility(IPersonSet).getPrecachedPersonsFromIDs(
>
The proposal to merge lp:~cjwatson/launchpad/snap-auto-build-code into
lp:launchpad has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/snap-auto-build-code/+merge/297957
--
Your team Launchpad code reviewers is subscribed
Colin Watson has proposed merging
lp:~cjwatson/launchpad/snap-channels-store-client into lp:launchpad with
lp:~cjwatson/launchpad/snap-auto-build-ui as a prerequisite.
Commit message:
Add model and store client support for automatically releasing snap packages.
Requested reviews:
Launchpad
Colin Watson has proposed merging lp:~cjwatson/launchpad/snap-channels-job into
lp:launchpad with lp:~cjwatson/launchpad/snap-channels-store-client as a
prerequisite.
Commit message:
Automatically release snap packages that have store_channels set.
Requested reviews:
Launchpad code reviewers
Colin Watson has proposed merging lp:~cjwatson/launchpad/snap-channels-ui into
lp:launchpad with lp:~cjwatson/launchpad/snap-channels-job as a prerequisite.
Commit message:
Add UI for automatically releasing snap packages.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
* Check all available processors by default.
* Dropped `SnapSet.availableProcessors()` for populating the processors widget,
in favor of `getUtility(IProcessorSet).getAll()` to keep the same logic as
`SnapSet.new()`.
* Indent processor checkboxes to keep them aligned with the series selector.
*
* Also, moved the processors selector up, between series and upload to store.
--
https://code.launchpad.net/~maxiberta/launchpad/new-snap-select-processors/+merge/298242
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
13 matches
Mail list logo
