Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-auth into lp:launchpad

2016-10-12 Thread William Grant
Review: Approve code Diff comments: > > === modified file 'lib/lp/code/model/codeimportjob.py' > --- lib/lp/code/model/codeimportjob.py2016-10-03 17:00:56 + > +++ lib/lp/code/model/codeimportjob.py2016-10-07 15:56:06 + > @@ -340,3 +348,57 @@ > # 4) >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-create-hosting into lp:launchpad

2016-10-12 Thread William Grant
Review: Approve code Diff comments: > > === modified file 'lib/lp/code/model/tests/test_codeimport.py' > --- lib/lp/code/model/tests/test_codeimport.py2016-10-03 17:00:56 > + > +++ lib/lp/code/model/tests/test_codeimport.py2016-10-11 14:42:21 > + > @@ -66,15 +67,22

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-worker-refactor into lp:launchpad

2016-10-12 Thread William Grant
Review: Approve code Diff comments: > === modified file 'lib/lp/code/xmlrpc/codeimportscheduler.py' > --- lib/lp/code/xmlrpc/codeimportscheduler.py 2016-10-11 13:46:57 + > +++ lib/lp/code/xmlrpc/codeimportscheduler.py 2016-10-11 13:46:57 + > @@ -69,10 +69,10 @@ > job =

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-source-details-refactor into lp:launchpad

2016-10-12 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/codeimport-source-details-refactor/+merge/308117 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-worker into lp:launchpad

2016-10-12 Thread William Grant
Review: Approve code Diff comments: > === modified file 'configs/development/launchpad-lazr.conf' > --- configs/development/launchpad-lazr.conf 2016-06-30 16:05:11 + > +++ configs/development/launchpad-lazr.conf 2016-10-11 15:36:32 + > @@ -55,6 +55,7 @@ > > [codeimport] >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-worker into lp:launchpad

2016-10-12 Thread Colin Watson
I've sprinkled a bunch of extra comments around in various places. Diff comments: > > === modified file 'lib/lp/codehosting/codeimport/worker.py' > --- lib/lp/codehosting/codeimport/worker.py 2016-10-11 15:36:32 + > +++ lib/lp/codehosting/codeimport/worker.py 2016-10-11 15:36:32 + >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-auth into lp:launchpad

2016-10-12 Thread Colin Watson
Diff comments: > > === modified file 'lib/lp/code/model/codeimportjob.py' > --- lib/lp/code/model/codeimportjob.py2016-10-03 17:00:56 + > +++ lib/lp/code/model/codeimportjob.py2016-10-07 15:56:06 + > @@ -340,3 +348,57 @@ > # 4) >

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-source-details-refactor into lp:launchpad

2016-10-12 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-source-details-refactor into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-source-details-refactor/+merge/308117 -- Your team Launchpad

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-auth into lp:launchpad

2016-10-12 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-git-auth into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-auth/+merge/307968 -- Your team Launchpad code reviewers is subscribed to

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-create-hosting into lp:launchpad

2016-10-12 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-create-hosting into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-create-hosting/+merge/308132 -- Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-worker-refactor into lp:launchpad

2016-10-12 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-worker-refactor into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-worker-refactor/+merge/308122 -- Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-code-import-security-deletion into lp:launchpad

2016-10-12 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/git-code-import-security-deletion into lp:launchpad with lp:~cjwatson/launchpad/codeimport-git-worker as a prerequisite. Commit message: Grant vcs-imports edit access to imported repositories, and handle deletion of imported

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-worker into lp:launchpad

2016-10-12 Thread William Grant
Review: Approve code Diff comments: > > === modified file 'lib/lp/codehosting/codeimport/worker.py' > --- lib/lp/codehosting/codeimport/worker.py 2016-10-11 15:36:32 + > +++ lib/lp/codehosting/codeimport/worker.py 2016-10-11 15:36:32 + > @@ -918,3 +973,67 @@ > """See