Re: [Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/private-librarian into lp:launchpad

2010-07-27 Thread Stuart Bishop
Review: Needs Information The idea seems good. I don't see why the table should exist in the session database. It should exist in the main database. Putting it in the session database just doubles the number of database connections the Librarian and garbage collector need to maintain, and

Re: [Launchpad-reviewers] [Merge] lp:~jtv/launchpad/db-external-suggestions-template-cache into lp:launchpad

2010-07-27 Thread Jeroen T. Vermeulen
After digging a bit deeper I don't think this fits in with garbo after all, since it's not a TunableLoop. Nor should it become one. The job system wouldn't work either: extra database table, new job class, new job runner, new utility, and ultimately still a new cron job to run the new job

[Launchpad-reviewers] [Merge] lp:~julian-edwards/launchpad/checkUpload-bug-608891 into lp:launchpad/devel

2010-07-27 Thread Julian Edwards
Julian Edwards has proposed merging lp:~julian-edwards/launchpad/checkUpload-bug-608891 into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: #608891 archive.checkUpload() OOPSes when distoseries is set to a stable release

[Launchpad-reviewers] [Merge] lp:~henninge/launchpad/buildd-manager-logging into lp:launchpad/devel

2010-07-27 Thread Henning Eggers
Henning Eggers has proposed merging lp:~henninge/launchpad/buildd-manager-logging into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: #589604 buildd-manager should be more rsync-friendly with log syncing

Re: [Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/private-librarian into lp:launchpad

2010-07-27 Thread Robert Collins
I used the session DB because this stuff is transient : memcached might be an answer too but the token *system* has to be available or private file downloads will fail, and memcached is currently (AIUI) a 'when its there use it' system - which is fine. Replicating the tokens isn't terribly

[Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/private-librarian into lp:launchpad

2010-07-27 Thread Robert Collins
The proposal to merge lp:~lifeless/launchpad/private-librarian into lp:launchpad has been updated. Status: Needs review = Work in progress -- https://code.launchpad.net/~lifeless/launchpad/private-librarian/+merge/31020 Your team Launchpad code reviewers is requested to review the proposed

[Launchpad-reviewers] [Merge] lp:~thumper/launchpad/fix-mirror-failure-story into lp:launchpad/devel

2010-07-27 Thread noreply
The proposal to merge lp:~thumper/launchpad/fix-mirror-failure-story into lp:launchpad/devel has been updated. Status: Approved = Merged -- https://code.launchpad.net/~thumper/launchpad/fix-mirror-failure-story/+merge/31010 Your team Launchpad code reviewers is requested to review the

[Launchpad-reviewers] [Merge] lp:~edwin-grubbs/launchpad/bug-577492-needspackaging-duplicates into lp:launchpad/devel

2010-07-27 Thread Edwin Grubbs
Edwin Grubbs has proposed merging lp:~edwin-grubbs/launchpad/bug-577492-needspackaging-duplicates into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: #528648 restore needs_packaging for +portlet-package-summary

[Launchpad-reviewers] [Merge] lp:~thumper/launchpad/fix-upgrade-branch-failure into lp:launchpad/devel

2010-07-27 Thread Tim Penhey
Tim Penhey has proposed merging lp:~thumper/launchpad/fix-upgrade-branch-failure into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: #610401 Upgrade Branch job needs write privileges to Job https://bugs.launchpad.net/bugs/610401

[Launchpad-reviewers] [Merge] lp:~thumper/launchpad/stop-mirroring-hosted into lp:launchpad/devel

2010-07-27 Thread Tim Penhey
Tim Penhey has proposed merging lp:~thumper/launchpad/stop-mirroring-hosted into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) This is the final branch in the stack that enforces not calling the branch mirror methods on hosted branches. Exceptions

Re: [Launchpad-reviewers] [Merge] lp:~brian-murray/launchpad/bug-556489-distro-struct-sub into lp:launchpad/devel

2010-07-27 Thread Robert Collins
I'm not clear why this makes sense. - users can subscribe to the bugs list [same amount of mail] - there are uses to being notified of every bug, same as things like gmane are subscribed to lists - this makes lp less flexible not more. I suspect you're doing a bandaid to the real issues: -