wrong: apparently they don't have an errno...
--
https://code.launchpad.net/~mbp/launchpad/mbp-trivial/+merge/32173
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~mbp/launchpad/mbp-trivial into lp:launchpad.
___
I think all POSTs redirect before displaying the subsequent page, so that
should be fine. However, I'm very suspicious of widely deploying
@cachedproperty... I'd be much happier if it was populated only by the explicit
prejoin, and operated uncached in the normal case.
--
Granted this is only a Recommends not a hard Depends, but bzr-lpreview-body is
only published in the PPA for lucid. It ought to be available in all populated
distroseries.
Also, please mention bzr-lpreview-body on
https://dev.launchpad.net/LaunchpadPpa.
--
The proposal to merge lp:~jelmer/meta-lp-deps/lintian into lp:meta-lp-deps has
been updated.
Status: Needs review = Work in progress
--
https://code.launchpad.net/~jelmer/meta-lp-deps/lintian/+merge/31745
Your team Launchpad code reviewers is requested to review the proposed merge of
Max Bowsher has proposed merging lp:~maxb/meta-lp-deps/pg8.4 into
lp:meta-lp-deps.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
--
https://code.launchpad.net/~maxb/meta-lp-deps/pg8.4/+merge/32200
Your team Launchpad code reviewers is requested to review the proposed
Review: Needs Fixing code
Production still uses 8.3, so we can't drop 8.3 support just yet.
The other changes are fine.
--
https://code.launchpad.net/~maxb/meta-lp-deps/pg8.4/+merge/32200
Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps.
On Tue, 2010-08-10 at 13:26 +, Max Bowsher wrote:
Granted this is only a Recommends not a hard Depends, but bzr-lpreview-body
is only published in the PPA for lucid. It ought to be available in all
populated distroseries.
Also, please mention bzr-lpreview-body on
The proposal to merge lp:~jelmer/meta-lp-deps/lintian into lp:meta-lp-deps has
been updated.
Status: Approved = Merged
--
https://code.launchpad.net/~jelmer/meta-lp-deps/lintian/+merge/31745
Your team Launchpad code reviewers is requested to review the proposed merge of
Jonathan Lange has proposed merging lp:~jml/launchpad/readme into
lp:launchpad/devel.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
I thought, you know what would be a good idea? A README file! It should explain
what Launchpad is, where one could go to find more
Jelmer Vernooij has proposed merging
lp:~jelmer/launchpad/publisher-use-debian-1 into lp:launchpad/devel.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers): code
Refactor lp.archivepublisher.publishing to use the functionality in the new
debian Python module to generate
Brad Crittenden has proposed merging lp:~bac/launchpad/bug-590813 into
lp:launchpad/devel.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
#590813 ShortListTooBigError configuring project
https://bugs.launchpad.net/bugs/590813
= Summary =
Some products
Hi, this looks ok to me.
Nothing to do with your patch per se - I have a question about the
test technology being used: create_initialised_view - I presume that
that lets you get in under the publishing machinery?
That means that things setup by publications - like oops handling etc
- won't be
j.c.sackett has proposed merging
lp:~jcsackett/launchpad/plus-participation-timeouts into lp:launchpad/devel.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
#607879 ~person/+participation timeouts
https://bugs.launchpad.net/bugs/607879
Summary
Partial
j.c.sackett has proposed merging lp:~jcsackett/launchpad/member-icons-title
into lp:launchpad/devel.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
#614649 Title for member of icons unhelpful
https://bugs.launchpad.net/bugs/614649
Summary
Fixes a trivial
This catches exceptions like other tests. The issue of recording an oops (which
is an act of adaption) is a separate concern. I do not think TestBrowser
records oopes either because it uses a similar mechanism to instantiate the
view.
--
Thanks!
--
https://code.launchpad.net/~sinzui/launchpad/deactivate-deactivated-account-0/+merge/32264
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~sinzui/launchpad/deactivate-deactivated-account-0 into lp:launchpad/devel.
William Grant has proposed merging
lp:~wgrant/launchpad/bug-616154-guessPackageNames-order-fix into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
#616154 Distribution.guessPackageNames needs to return the source for the
latest published binary
17 matches
Mail list logo
