[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel

2011-09-13 Thread Steve Kowalik
Steve Kowalik has proposed merging lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~stevenk/launchpad/denorm-bspph-indices/+merge/75149 Add indicies for

[Launchpad-reviewers] [Merge] lp:~jtv/launchpad/bug-844550 into lp:launchpad

2011-09-13 Thread Jeroen T. Vermeulen
Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/bug-844550 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #844550 in Launchpad itself: Retire gina transitional domination https://bugs.launchpad.net/launchpad/+bug/844550

Re: [Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel

2011-09-13 Thread Stuart Bishop
Review: Approve db -- https://code.launchpad.net/~stevenk/launchpad/denorm-bspph-indices/+merge/75149 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel.

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel

2011-09-13 Thread Stuart Bishop
The proposal to merge lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~stevenk/launchpad/denorm-bspph-indices/+merge/75149 --

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel

2011-09-13 Thread Stuart Bishop
The proposal to merge lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel has been updated. Commit Message changed to: Add indicies for the denormalisation columns of SPPH and BPPH. For more details, see:

[Launchpad-reviewers] [Merge] lp:~rvb/launchpad/confirmationoverlay-button-optional into lp:launchpad

2011-09-13 Thread Raphaël Victor Badin
Raphaël Victor Badin has proposed merging lp:~rvb/launchpad/confirmationoverlay-button-optional into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel

2011-09-13 Thread Stuart Bishop
The proposal to merge lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel has been updated. Commit Message changed to: [r=stub][no-qa] Add indicies for the denormalisation columns of SPPH and BPPH. For more details, see:

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel

2011-09-13 Thread noreply
The proposal to merge lp:~stevenk/launchpad/denorm-bspph-indices into lp:launchpad/db-devel has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~stevenk/launchpad/denorm-bspph-indices/+merge/75149 --

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/delete-more into lp:launchpad

2011-09-13 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/delete-more into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wgrant/launchpad/delete-more/+merge/75179 Delete some unused code from canonical.*. --

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/cleanup-canonical.lp into lp:launchpad

2011-09-13 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/cleanup-canonical.lp into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wgrant/launchpad/cleanup-canonical.lp/+merge/75180 Clean up canonical.lp's

[Launchpad-reviewers] [Merge] lp:~jtv/launchpad/bug-848954 into lp:launchpad

2011-09-13 Thread Jeroen T. Vermeulen
Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/bug-848954 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #848954 in Launchpad itself: ztm.commit may break gina's dry-run mode

[Launchpad-reviewers] [Merge] lp:~allenap/launchpad/add-rabbit-service-bug-806160 into lp:launchpad

2011-09-13 Thread Gavin Panella
Gavin Panella has proposed merging lp:~allenap/launchpad/add-rabbit-service-bug-806160 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #806160 in Launchpad itself: Get Rabbit running as a dev service in Launchpad.

[Launchpad-reviewers] [Merge] lp:~adeuring/launchpad/cronscript-for-hwdb-report-fixes into lp:launchpad

2011-09-13 Thread Abel Deuring
Abel Deuring has proposed merging lp:~adeuring/launchpad/cronscript-for-hwdb-report-fixes into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~adeuring/launchpad/cronscript-for-hwdb-report-fixes/+merge/75214

Re: [Launchpad-reviewers] [Merge] lp:~allenap/launchpad/add-rabbit-service-bug-806160 into lp:launchpad

2011-09-13 Thread Robert Collins
You write out a unique config fragment and export LPCONFIG before starting services depending on rabbit. We do this in the test runner and it works well - is there any reason it won't work here? -- https://code.launchpad.net/~allenap/launchpad/add-rabbit-service-bug-806160/+merge/75195 Your team

Re: [Launchpad-reviewers] [Merge] lp:~allenap/launchpad/add-rabbit-service-bug-806160 into lp:launchpad

2011-09-13 Thread Gavin Panella
I was thinking of something like: $ make run_all $ make sync_branches How do the scripts that sync_branches invokes know where Rabbit is? -- https://code.launchpad.net/~allenap/launchpad/add-rabbit-service-bug-806160/+merge/75195 Your team Launchpad code reviewers is requested to review the

[Launchpad-reviewers] [Merge] lp:~benji/launchpad/bug-742662-2 into lp:launchpad

2011-09-13 Thread Benji York
Benji York has proposed merging lp:~benji/launchpad/bug-742662-2 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #742662 in Launchpad itself: Mixed new line markers causing OOPS while submitting translations

Re: [Launchpad-reviewers] [Merge] lp:~allenap/launchpad/add-rabbit-service-bug-806160 into lp:launchpad

2011-09-13 Thread Robert Collins
$ make run_all Assigned LPCONFIG=12345 $ export LPCONFIG=12345 $ make sync_branches -- https://code.launchpad.net/~allenap/launchpad/add-rabbit-service-bug-806160/+merge/75195 Your team Launchpad code reviewers is requested to review the proposed merge of

[Launchpad-reviewers] [Merge] lp:~bac/launchpad/bug-828572 into lp:launchpad

2011-09-13 Thread Brad Crittenden
Brad Crittenden has proposed merging lp:~bac/launchpad/bug-828572 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #828572 in Launchpad itself: bugs are marked incomplete_with_response if users or scripts change the status / tags

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/missing-all-still into lp:launchpad

2011-09-13 Thread Steve Kowalik
Steve Kowalik has proposed merging lp:~stevenk/launchpad/missing-all-still into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~stevenk/launchpad/missing-all-still/+merge/75286 There were 1 imports of names

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/denorm-bspph-garbo into lp:launchpad

2011-09-13 Thread Steve Kowalik
Steve Kowalik has proposed merging lp:~stevenk/launchpad/denorm-bspph-garbo into lp:launchpad with lp:~stevenk/launchpad/denorm-bspph-model as a prerequisite. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: