[Launchpad-reviewers] [Merge] lp:~stub/launchpad/pending-db-changes into lp:launchpad

2012-06-01 Thread Stuart Bishop
Stuart Bishop has proposed merging lp:~stub/launchpad/pending-db-changes into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~stub/launchpad/pending-db-changes/+merge/108323 = Summary = Turns out pgstattuple

[Launchpad-reviewers] [Merge] lp:~stub/launchpad/pending-db-changes into lp:launchpad/db-devel

2012-06-01 Thread Stuart Bishop
Stuart Bishop has proposed merging lp:~stub/launchpad/pending-db-changes into lp:launchpad/db-devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~stub/launchpad/pending-db-changes/+merge/108325 = Summary = Turns out

Re: [Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/sprite-icon-spacing-1007263 into lp:launchpad

2012-06-01 Thread Curtis Hovey
Review: Needs Information code What sprite is not an action? I suppose it its sprites on non-anchors. The crux of the issue is text + anchor is too close. The text is often wrapped in a span so maybe we can use a sibling selector span + a.sprite {margin-left: 6px;} We might want to try this

[Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/filebug-choice-widget-infotype-1006799 into lp:launchpad

2012-06-01 Thread Ian Booth
The proposal to merge lp:~wallyworld/launchpad/filebug-choice-widget-infotype-1006799 into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~wallyworld/launchpad/filebug-choice-widget-infotype-1006799/+merge/108286 --

[Launchpad-reviewers] [Merge] lp:~sinzui/launchpad/queue-project-email into lp:launchpad

2012-06-01 Thread noreply
The proposal to merge lp:~sinzui/launchpad/queue-project-email into lp:launchpad has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~sinzui/launchpad/queue-project-email/+merge/108235 --

[Launchpad-reviewers] [Merge] lp:~bac/launchpad/bug-1007111 into lp:launchpad

2012-06-01 Thread Brad Crittenden
Brad Crittenden has proposed merging lp:~bac/launchpad/bug-1007111 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1007111 in Launchpad itself: Tests of same id but run in multiple layers fail

Re: [Launchpad-reviewers] [Merge] lp:~bac/launchpad/bug-1007111 into lp:launchpad

2012-06-01 Thread Gary Poster
Review: Approve Great, thanks! We talked on IRC about benji's concern with naming Python file objects after file descriptors, and so possibly changing fd to f or something else. As I said, your call. Also as we discussed even earlier, I'd like to see bug 682772 addressed as well (and maybe

[Launchpad-reviewers] [Merge] lp:~bac/launchpad/bug-1007111 into lp:launchpad

2012-06-01 Thread Gary Poster
The proposal to merge lp:~bac/launchpad/bug-1007111 into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~bac/launchpad/bug-1007111/+merge/108359 -- https://code.launchpad.net/~bac/launchpad/bug-1007111/+merge/108359 Your

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pas-arm into lp:launchpad

2012-06-01 Thread Brad Crittenden
Review: Approve code Hi Colin, Thanks for this patch. It makes good sense to take our incomplete parsing code and defer to the system tool. And thanks for your continued sensitivity to the LoC initiative. -- https://code.launchpad.net/~cjwatson/launchpad/pas-arm/+merge/107966 Your team

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pas-arm into lp:launchpad

2012-06-01 Thread Brad Crittenden
The proposal to merge lp:~cjwatson/launchpad/pas-arm into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjwatson/launchpad/pas-arm/+merge/107966 -- https://code.launchpad.net/~cjwatson/launchpad/pas-arm/+merge/107966 Your