[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad
The proposal to merge lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/ptuj-repr/+merge/338559 -- Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad
Makes sense, thanks. -- https://code.launchpad.net/~cjwatson/launchpad/ptuj-repr/+merge/338559 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad
That's because we're now using those properties in the parent class, specifically in the new PackageTranslationsUploadJobDerived.__repr__ method. The whole *Derived thing for jobs is pretty confusing, but basically the job runner calls iterReady on an IJobSource to get the list of jobs it should run, and the returned instances (FooJobDerived) typically delegate to self.context (which is a FooJob) for the business logic of the job proper. Now, I'm not a big fan of this layout because it's usually unnecessarily complicated, and in this case it's an artificial distinction because self.context == self; however, strictly speaking the job runner's logging is done using the FooJobDerived instance, so __repr__ belongs there and I therefore moved the properties it uses as well. -- https://code.launchpad.net/~cjwatson/launchpad/ptuj-repr/+merge/338559 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad
Review: Approve Looks good to me. One question though: why move those @properties from `PackageTranslationsUploadJob` to its parent class `PackageTranslationsUploadJobDerived`? -- https://code.launchpad.net/~cjwatson/launchpad/ptuj-repr/+merge/338559 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/zope.pagetemplate-4.3.0 into lp:launchpad
The proposal to merge lp:~cjwatson/launchpad/zope.pagetemplate-4.3.0 into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/zope.pagetemplate-4.3.0/+merge/335582 -- Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/twisted-16.5.0 into lp:launchpad
The proposal to merge lp:~cjwatson/launchpad/twisted-16.5.0 into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/twisted-16.5.0/+merge/335534 -- Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
