[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-appserver-nrpe-reconfigure into launchpad:master

2023-06-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-appserver-nrpe-reconfigure into launchpad:master. Commit message: charm: Deconfigure nrpe when service is deconfigured Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-appserver-simplify-status-check into launchpad:master

2023-06-16 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-appserver-simplify-status-check into launchpad:master. Commit message: charm/launchpad-appserver: Use /_status/check as health check Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] lp:~cjwatson/charms/trusty/turnip/code-in-swift into lp:~canonical-launchpad-branches/charms/trusty/turnip/devel

2023-06-16 Thread Colin Watson
The proposal to merge lp:~cjwatson/charms/trusty/turnip/code-in-swift into lp:~canonical-launchpad-branches/charms/trusty/turnip/devel has been updated. Status: Needs review => Rejected For more details, see:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/charms/trusty/turnip/code-in-swift into lp:~canonical-launchpad-branches/charms/trusty/turnip/devel

2023-06-16 Thread Colin Watson
This has long since been superseded by the in-tree charm. -- https://code.launchpad.net/~cjwatson/charms/trusty/turnip/code-in-swift/+merge/262198 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/charms/trusty/turnip/code-in-swift into

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:fix-make-schema-in-charmed-deployment into launchpad:master

2023-06-16 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:fix-make-schema-in-charmed-deployment into launchpad:master. Commit message: Fix database initialization in charmed deployments Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/txpkgupload:remove-git-dependency-from-default-make-command into txpkgupload:master

2023-06-16 Thread Colin Watson
Looking at https://git.launchpad.net/launchpad/commit?id=e13a516043 as an example, could you instead do `[ ! -d .git ] || scripts/update-version-info.sh`? That should make it work gracefully in a charm, and I think you could probably then drop the change to the `build-tarball` rule. --

Re: [Launchpad-reviewers] [Merge] ~cjwatson/launchpad:skip-conda-source-files-harder into launchpad:master

2023-06-16 Thread Colin Watson
I went through the history and I couldn't find any relevant changes since the file in question was published, so I must be missing some corner case in the current code, I think. -- https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/444873 Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:bmp-job-pruner into launchpad:master

2023-06-15 Thread Colin Watson
The proposal to merge ~cjwatson/launchpad:bmp-job-pruner into launchpad:master has been updated. Description changed to: This accounts for about 4 million out of the 24 million Job rows on production, so it seems worth the effort of pruning. This is a rebased version of

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:bmp-job-pruner into launchpad:master

2023-06-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:bmp-job-pruner into launchpad:master. Commit message: Prune old completed BranchMergeProposalJobs Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bmp-job-pruner into lp:launchpad

2023-06-15 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/bmp-job-pruner into lp:launchpad has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~cjwatson/launchpad/bmp-job-pruner/+merge/362460 -- Your team Launchpad code reviewers is subscribed to branch

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bmp-job-pruner into lp:launchpad

2023-06-15 Thread Colin Watson
Superseded by https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/444874. -- https://code.launchpad.net/~cjwatson/launchpad/bmp-job-pruner/+merge/362460 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:skip-conda-source-files-harder into launchpad:master

2023-06-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:skip-conda-source-files-harder into launchpad:master. Commit message: Always pretend that "source packages" for Conda have no files Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2023315 in

Re: [Launchpad-reviewers] [Merge] ~jelmer/launchpad:public-https into launchpad:master

2023-06-15 Thread Colin Watson
There was a recent thread on ubuntu-devel pointing out why `lp:` fails, so that part may not be LP's fault: https://lists.ubuntu.com/archives/ubuntu-devel/2023-June/042619.html -- https://code.launchpad.net/~jelmer/launchpad/+git/launchpad/+merge/435608 Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad/+git/security:suppress-orm-addresses into launchpad:master

2023-06-15 Thread Colin Watson
The proposal to merge ~cjwatson/launchpad/+git/security:suppress-orm-addresses into launchpad:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/security/+merge/444818 -- Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:dateutil.tz into launchpad:master

2023-06-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:dateutil.tz into launchpad:master. Commit message: Remove direct dependencies on pytz Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad/+git/security:suppress-orm-addresses into launchpad:master

2023-06-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad/+git/security:suppress-orm-addresses into launchpad:master. Commit message: Avoid showing memory addresses in API errors Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:update-pkgcache-binary-race into launchpad:master

2023-06-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:update-pkgcache-binary-race into launchpad:master. Commit message: Fix update-pkgcache crash due to binary deletion Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2023698 in Launchpad itself: "u

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:readthedocs-config into launchpad-buildd:master

2023-06-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:readthedocs-config into launchpad-buildd:master. Commit message: Refine readthedocs configuration Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:readthedocs-config into launchpad-buildd:master

2023-06-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:readthedocs-config into launchpad-buildd:master. Commit message: Add .readthedocs.yaml Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad-buildd

Re: [Launchpad-reviewers] [Merge] lp:~ines-almeida/lp-production-crontabs/update-lang-pack-exports into lp:lp-production-crontabs

2023-06-14 Thread Colin Watson
Review: Approve Diff comments: > === modified file 'scripts.lp.internal-launchpad' > --- scripts.lp.internal-launchpad 2023-05-31 18:01:50 + > +++ scripts.lp.internal-launchpad 2023-06-14 09:46:40 + > @@ -26,9 +26,7 @@ > 30 10 * * 2 nice -16 $LP_PY >

[Launchpad-reviewers] [Merge] ~petermakowski/launchpad:update-description-font-size into launchpad:master

2023-06-14 Thread Colin Watson
The proposal to merge ~petermakowski/launchpad:update-description-font-size into launchpad:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~petermakowski/launchpad/+git/launchpad/+merge/444647 -- Your team Launchpad code reviewers

Re: [Launchpad-reviewers] [Merge] ~petermakowski/launchpad:update-description-font-size into launchpad:master

2023-06-14 Thread Colin Watson
Review: Approve It may be worth grepping for font-family - there are a few other places that look similar. But this change looks fine, and addresses the most glaring mismatch I've noticed. Thanks! -- https://code.launchpad.net/~petermakowski/launchpad/+git/launchpad/+merge/444647 Your team

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-service-name-host into launchpad:master

2023-06-13 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-service-name-host into launchpad:master. Commit message: charm/launchpad-librarian: Set service_name to host names Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:allow-empty-ci-output-files into launchpad:master

2023-06-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:allow-empty-ci-output-files into launchpad:master. Commit message: Allow CI build artifacts to be zero-length Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-assets-http-interface into launchpad:master

2023-06-08 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-assets-http-interface into launchpad:master. Commit message: charm/launchpad-assets: Add http interface support Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-bump-ols-layers into launchpad:master

2023-06-07 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-bump-ols-layers into launchpad:master. Commit message: charm: Update ols-layers Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-appserver-http-interface into launchpad:master

2023-06-07 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-appserver-http-interface into launchpad:master. Commit message: charm/launchpad-appserver: Add http interface support Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-worker-count-change into launchpad:master

2023-06-06 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-worker-count-change into launchpad:master. Commit message: charm/launchpad-librarian: Restart when worker count is changed Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-http-interface into launchpad:master

2023-06-06 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-http-interface into launchpad:master. Commit message: charm/launchpad-librarian: Add http interface support Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:builder-metrics-by-region into launchpad:master

2023-06-06 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:builder-metrics-by-region into launchpad:master. Commit message: Add region to builder metrics Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:doc-malware-scanning into launchpad-buildd:master

2023-06-06 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:doc-malware-scanning into launchpad-buildd:master. Commit message: Add basic documentation of malware scanning for CI builds Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:fix-initial-remote-db-setup into launchpad:master

2023-06-06 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:fix-initial-remote-db-setup into launchpad:master. Commit message: Fix initial setup of remote databases Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-assets-favicon into launchpad:master

2023-06-05 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-assets-favicon into launchpad:master. Commit message: charm: Serve favicons from assets charm Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-clear-storage-action into launchpad:master

2023-06-05 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-clear-storage-action into launchpad:master. Commit message: charm: Add a clear-storage action to the librarian Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-expand-volume-docs into launchpad:master

2023-05-31 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-expand-volume-docs into launchpad:master. Commit message: charm: Expand documentation of librarian volume handling Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-debian-importer-db-layer into launchpad:master

2023-05-30 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-debian-importer-db-layer into launchpad:master. Commit message: charm: Update debian-importer charm to use the db layer Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:dm-mknod-check-existence into launchpad-buildd:master

2023-05-30 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:dm-mknod-check-existence into launchpad-buildd:master. Commit message: Only create /dev/dm-* in LXD containers if they don't already exist Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-maintainer into launchpad:master

2023-05-26 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-maintainer into launchpad:master. Commit message: charm: Change "maintainer" to a team mailing list Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:schema-depends-compile into launchpad:master

2023-05-26 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:schema-depends-compile into launchpad:master. Commit message: Reduce dependencies of "make schema" Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:release-232 into launchpad-buildd:master

2023-05-24 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:release-232 into launchpad-buildd:master. Commit message: Release version 232 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad-buildd/+git

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:fix-nvidia-device-handling into launchpad-buildd:master

2023-05-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:fix-nvidia-device-handling into launchpad-buildd:master. Commit message: Fix nvidia device node handling for devtmpfs Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:doc-charm-database-roles into launchpad:master

2023-05-18 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:doc-charm-database-roles into launchpad:master. Commit message: Document database role management for charms Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:fix-populate-archive-component into launchpad:master

2023-05-17 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:fix-populate-archive-component into launchpad:master. Commit message: populate-archive: Fix --component option Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:date-widget-time-zone-name into launchpad:master

2023-05-16 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:date-widget-time-zone-name into launchpad:master. Commit message: Refactor time zone name handling in DateTimeWidget Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-doc-migration-wording into launchpad:master

2023-05-16 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-doc-migration-wording into launchpad:master. Commit message: charm: Tidy up wording for librarian's active=false mode Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:remove-zope.securitypolicy into launchpad:master

2023-05-16 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:remove-zope.securitypolicy into launchpad:master. Commit message: Remove zope.securitypolicy Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:simplify-librarian-thread-state-test into launchpad:master

2023-05-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:simplify-librarian-thread-state-test into launchpad:master. Commit message: Simplify LibrarianClientTestCase.test_thread_state_FileUploadClient Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:sss-mantic into launchpad:master

2023-05-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:sss-mantic into launchpad:master. Commit message: Update soyuz-sampledata-setup.py for kinetic to mantic Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:unexport-getBuildSummariesForSnapBuildIds into launchpad:master

2023-05-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:unexport-getBuildSummariesForSnapBuildIds into launchpad:master. Commit message: Unexport Snap.getBuildSummariesForSnapBuildIds Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:unsixify-translations into launchpad:master

2023-05-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:unsixify-translations into launchpad:master. Commit message: Remove six from lp.translations Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:remove-packages-arch-specific-comments into launchpad:master

2023-05-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:remove-packages-arch-specific-comments into launchpad:master. Commit message: Remove obsolete comments about Packages-arch-specific Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:remove-old-code-import-worker-compat into launchpad:master

2023-05-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:remove-old-code-import-worker-compat into launchpad:master. Commit message: Drop support for old code import log file protocol Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:remove-futures into launchpad:master

2023-05-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:remove-futures into launchpad:master. Commit message: Remove futures requirement Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge

[Launchpad-reviewers] [Merge] ~cjwatson/turnip:deployment-artifact-series into turnip:master

2023-05-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/turnip:deployment-artifact-series into turnip:master. Commit message: Add series name to deployment artifact Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/turnip/+git

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:loggerhead-fix-robots into launchpad:master

2023-05-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:loggerhead-fix-robots into launchpad:master. Commit message: launchpad_loggerhead: Fix robots.txt Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-fix-log-file into launchpad:master

2023-05-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-fix-log-file into launchpad:master. Commit message: charm: Fix --logfile option passed to librarian Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-db-layer into launchpad:master

2023-05-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-db-layer into launchpad:master. Commit message: charm: Update launchpad-layers to 42a4b4c4f6 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-assets into launchpad:master

2023-05-11 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-assets into launchpad:master. Commit message: charm: Add a launchpad-assets charm Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:fix-translations-opening-unapprove into launchpad:master

2023-05-11 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:fix-translations-opening-unapprove into launchpad:master. Commit message: fix-translations-opening: Unapprove existing imports Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-doc-migration into launchpad:master

2023-05-10 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-doc-migration into launchpad:master. Commit message: charm: Document launchpad-librarian migration process Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:ci-build-webhooks into launchpad:master

2023-05-10 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:ci-build-webhooks into launchpad:master. Commit message: Add webhooks for CI builds Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:db-layer into launchpad-layers:main

2023-05-01 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:db-layer into launchpad-layers:main with ~cjwatson/launchpad-layers:payload-layer as a prerequisite. Commit message: Split out a launchpad-db layer Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-debian-importer into launchpad:master

2023-04-27 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-debian-importer into launchpad:master. Commit message: charm: Add a launchpad-debian-importer charm Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-fixes into launchpad:master

2023-04-27 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-fixes into launchpad:master. Commit message: charm: Fix a couple of bugs preventing the librarian from working Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:build-tarball-yarn into launchpad:master

2023-04-27 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:build-tarball-yarn into launchpad:master. Commit message: Include download-cache/yarn/ in deployment tarballs Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:apidoc-without-git into launchpad:master

2023-04-27 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:apidoc-without-git into launchpad:master. Commit message: Make apidoc generation work outside a git working tree Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:payload-layer into launchpad-layers:main

2023-04-27 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:payload-layer into launchpad-layers:main. Commit message: Move part of launchpad-base into a new launchpad-payload layer Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

Re: [Launchpad-reviewers] [Merge] ~lgp171188/lpci:docs-vanilla-theme into lpci:main

2023-04-26 Thread Colin Watson
Daniele asked us recently to start using https://github.com/canonical/sphinx-docs-starter-pack instead of the ad-hoc approach we've been copying around from an earlier conversation with him. I haven't looked at that seriously yet, but we should at least give it a try here. --

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:revert-build-tarball-assets into launchpad:master

2023-04-25 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:revert-build-tarball-assets into launchpad:master. Commit message: Revert "Include built assets in deployment tarballs" Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.lau

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:fix-build-tarball-assets into launchpad:master

2023-04-25 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:fix-build-tarball-assets into launchpad:master. Commit message: Move asset build to be local to build-tarball Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:build-tarball-assets into launchpad:master

2023-04-23 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:build-tarball-assets into launchpad:master. Commit message: Include built assets in deployment tarballs Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/rutabaga:charm-fix-proxy-check into rutabaga:master

2023-04-21 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/rutabaga:charm-fix-proxy-check into rutabaga:master. Commit message: charm: Fix check_rutabaga_proxy to avoid double slashes Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:drop-apt-transport-https into launchpad-buildd:master

2023-04-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:drop-apt-transport-https into launchpad-buildd:master. Commit message: Drop dependency on apt-transport-https Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-charmhub-secrets-private-key into launchpad:master

2023-04-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-charmhub-secrets-private-key into launchpad:master. Commit message: charm: Add charmhub_secrets_private_key Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/rutabaga:fix-migrate-db into rutabaga:master

2023-04-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/rutabaga:fix-migrate-db into rutabaga:master. Commit message: db: Don't fail migration if Token table already exists Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-staging-bos03 into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-04-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-staging-bos03 into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder. Commit message: vbuilder: Add bos03 for staging Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-mail-configure into launchpad:master

2023-04-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-mail-configure into launchpad:master. Commit message: charm: Configure outbound email if send_email is true Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2017136 in launchpad-layers: "No

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:mail-configure into launchpad-layers:main

2023-04-20 Thread Colin Watson
The proposal to merge ~cjwatson/launchpad-layers:mail-configure into launchpad-layers:main has been updated. Description changed to: Most of Launchpad's email is sent using immediate delivery, which uses `smtplib` directly; but some, such as email sent by garbo jobs, instead queues it up

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:mail-configure into launchpad-layers:main

2023-04-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:mail-configure into launchpad-layers:main. Commit message: Configure outbound email if send_email is true Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2017136 in launchpad-layers: "No

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-update-launchpad-layers into launchpad:master

2023-04-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-update-launchpad-layers into launchpad:master. Commit message: charm: Update launchpad-layers to 81c2d5b77d Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:expire-questions-limit into launchpad:master

2023-04-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:expire-questions-limit into launchpad:master. Commit message: expire-questions: Add a --limit option Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:supermirror-root-trailing-slash into launchpad-layers:main

2023-04-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:supermirror-root-trailing-slash into launchpad-layers:main. Commit message: Add trailing slash to supermirror_root Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2017026 in launchpad-layers

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-buildd-manager into launchpad:master

2023-04-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-buildd-manager into launchpad:master. Commit message: charm: Add a launchpad-buildd-manager charm Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

Re: [Launchpad-reviewers] [Merge] ~jugmac00/launchpad:oval-check-changes into launchpad:master

2023-04-19 Thread Colin Watson
I adopted this and proposed https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/441468 with a number of fixes on top of it. -- https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/441101 Your team Launchpad code reviewers is requested to review the proposed

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:oval-check-changes into launchpad:master

2023-04-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:oval-check-changes into launchpad:master. Commit message: Compare incoming OVAL data with already published one Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:states-to-flags into launchpad-layers:main

2023-04-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:states-to-flags into launchpad-layers:main. Commit message: Avoid deprecated reactive functions Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:lpci-snap-syntax into launchpad-layers:main

2023-04-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:lpci-snap-syntax into launchpad-layers:main. Commit message: .launchpad.yaml: Update snap property syntax Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:lpci-snap-syntax into launchpad:master

2023-04-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:lpci-snap-syntax into launchpad:master. Commit message: .launchpad.yaml: Update snap property syntax Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/lpci:release-0.0.52.1 into lpci:old-lpcraft

2023-04-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lpci:release-0.0.52.1 into lpci:old-lpcraft. Commit message: Release version 0.0.52.1 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lpci/+git/lpci/+merge/441436 I also

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:lpci-rename into launchpad:master

2023-04-18 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:lpci-rename into launchpad:master. Commit message: Follow rename of lpcraft to lpci Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/lpci:rename-warning into lpci:old-lpcraft

2023-04-18 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lpci:rename-warning into lpci:old-lpcraft. Commit message: Display notice advising users to switch to lpci Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lpci/+git/lpci

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:lpci-rename into launchpad-buildd:master

2023-04-18 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:lpci-rename into launchpad-buildd:master. Commit message: Use lpci rather than lpcraft, following its rename Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/lpci:release-0.1.0 into lpci:main

2023-04-18 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lpci:release-0.1.0 into lpci:main. Commit message: Release version 0.1.0 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lpci/+git/lpci/+merge/441327 -- Your team

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-db-changed into launchpad:master

2023-04-17 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-db-changed into launchpad:master. Commit message: charm: Clear configured states on DB relation changes Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-wsgi-worker-max-requests into launchpad:master

2023-04-17 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-wsgi-worker-max-requests into launchpad:master. Commit message: charm: Reduce max_requests and make it configurable Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:gpg-handle-preload into launchpad:master

2023-04-16 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:gpg-handle-preload into launchpad:master. Commit message: Defer GnuPG home directory setup to support app preloading Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:db-changed into launchpad-layers:main

2023-04-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:db-changed into launchpad-layers:main. Commit message: Clear configured states on DB relation changes Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/rutabaga:yaml-safe-load into rutabaga:master

2023-04-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/rutabaga:yaml-safe-load into rutabaga:master. Commit message: Load config file using yaml.safe_load Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/rutabaga/+git/rutabaga

[Launchpad-reviewers] [Merge] ~cjwatson/rutabaga:charm-remove-resource into rutabaga:master

2023-04-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/rutabaga:charm-remove-resource into rutabaga:master. Commit message: charm: Drop resource from rutabaga charm Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/rutabaga

[Launchpad-reviewers] [Merge] ~cjwatson/rutabaga:charm-docs into rutabaga:master

2023-04-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/rutabaga:charm-docs into rutabaga:master. Commit message: charm: Update documentation Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/rutabaga/+git/rutabaga/+merge/440891

<    1   2   3   4   5   6   7   8   9   10   >