Jürgen Gmach has proposed merging ~jugmac00/lpcraft:add-more-hooks into
lpcraft:main.
Commit message:
Add more hooks
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/413393
This MP
The proposal to merge ~jugmac00/lpcraft:add-more-hooks into lpcraft:main has
been updated.
Description changed to:
-
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/413393
--
Your team Launchpad code reviewers is requested to review the proposed merge
The proposal to merge ~jugmac00/lpcraft:add-more-hooks into lpcraft:main has
been updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/413393
--
Your team Launchpad code reviewers is requested to review the proposed merge of
Jürgen Gmach has proposed merging ~jugmac00/lpcraft:auto-collect-plugins into
lpcraft:main.
Commit message:
Use a decorator to collect all builtin plugins
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:rename-YAMLError-into-ConfigurationError into lpcraft:main.
Commit message:
Rename YAMLError into ConfigurationError
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
LGTM - In the long term we could implement a `-c` option to pass in a
configuration file, which would not make us to use `os.cwdir` which probably
could cause problems once we'll run tests in parallel.
This took me a bit to reproduce, as I experienced not such a problem in my
local env.
I
How did you find the problem with `tox` running only on system Python version
3.8?
After the longer break I am bit confused on how to get hold of usable data.
The current one-line spinner does not show any relevant info.
I added a function call, which was introduced with Python 3.10
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:create-documentation-for-plugin-system into lpcraft:main.
Commit message:
Create documentation for the plugin system
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:fix-tox-using-the-wrong-interpreter into lpcraft:main.
Commit message:
Fix tox plugin not selecting the right interpreter
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Jürgen Gmach has proposed merging ~jugmac00/lpcraft:increase-test-coverage into
lpcraft:main.
Commit message:
WIP: increase test coverage for lpcraft
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git
There is one usage of `with pytest.raises` which would be incompatible with an
alternative test runners. I went with it as afaik testtools prevents using the
`with self.assertRaises` syntax of the std lib.
Some tests seem artificial and use a lot of mocking, but I have not seen a much
better
Jürgen Gmach has proposed merging ~jugmac00/lpcraft:add-html-coverage into
lpcraft:main.
Commit message:
Add HTML coverage and contexts
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge
The proposal to merge ~jugmac00/lpcraft:add-html-coverage into lpcraft:main has
been updated.
Commit message changed to:
Add HTML coverage report and contexts
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/412002
--
Your team Launchpad code reviewers
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:retrieve-version-info-directly-from-setup-cfg into
lpcraft:main.
Commit message:
Retrieve version info directly from setup.cfg for building snaps
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
Verified by building the Snap
```
Pulling lpcraft
+ snapcraftctl pull
++ sed -n '/^version = /s///p' /root/project/setup.cfg
+ snapcraftctl set-version 0.0.1
```
We use setup-cfg-format, so I do not expect parsing issues because of e.g.
whitespace issues.
While this might not be 100% as
Jürgen Gmach has proposed merging ~jugmac00/turnip:fix-basic-xml-rpc-test into
turnip:master.
Commit message:
Fix basic XML-RPC test
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/turnip/+git/turnip/+merge/412162
Jürgen Gmach has proposed merging ~jugmac00/turnip:fix-build-step into
turnip:master.
Commit message:
Hardcode /usr/bin/virtualenv path
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/turnip/+git/turnip/+merge
Diff comments:
> diff --git a/lib/lp/bugs/tests/test_bugchanges.py
> b/lib/lp/bugs/tests/test_bugchanges.py
> index 148e329..b2999af 100644
> --- a/lib/lp/bugs/tests/test_bugchanges.py
> +++ b/lib/lp/bugs/tests/test_bugchanges.py
> @@ -1842,3 +1848,48 @@ class
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-pymemcache-regression
into launchpad:master.
Commit message:
Update SnapStoreClient to work with pymemcache
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00
Currently the mypy check fails with ...
$ tox -e mypy
GLOB sdist-make: /home/jugmac00/Projects/lpcraft/setup.py
mypy inst-nodeps:
/home/jugmac00/Projects/lpcraft/.tox/.tmp/package/1/lpcraft-0.0.1.zip
mypy installed: appdirs==1.4.4,craft-cli @
Jürgen Gmach has proposed merging
~jugmac00/launchpad:fix-another-pymemcache-regression into launchpad:master.
Commit message:
Update callers of Client.set
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad
@guruprasad - thanks for the review. I think there is nothing to do from my
side.
Let's wait until Colin has a chance to have a look at the changes.
Diff comments:
> diff --git a/lib/lp/buildmaster/interfaces/builder.py
> b/lib/lp/buildmaster/interfaces/builder.py
> index acd1dfd..a43fb7e
Jürgen Gmach has proposed merging ~jugmac00/lpcraft:main into lpcraft:main.
Commit message:
Run coverage via tox
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/411795
--
Your team
Jürgen Gmach has proposed merging ~jugmac00/lpcraft:add-coverage into
lpcraft:main.
Commit message:
Run coverage via tox
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/411796
--
Your
Jürgen Gmach has proposed merging
~jugmac00/launchpad:fix-pymemcache-regression-bytes-vs-str into
launchpad:master.
Commit message:
Fix pymemcache regression in SnapStoreClient.listChannels
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1950811
For the reviewer:
- I had to remove one assertion: self.assertEqual([],
hosting_fixture.getInventory.calls), which I think is ok, as getInventory is
the method were the expected exception is raised
- I had to implement the two new methods also in MemcacheFixture - this is a
bit dangerous, as
Jürgen Gmach has proposed merging
~jugmac00/launchpad:update-wadl-for-inclusive-naming into launchpad:master.
Commit message:
Update API for inclusive naming
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00
Jürgen Gmach has proposed merging
~jugmac00/turnip:improve-turnip-setup-documentation into turnip:master.
Commit message:
Add instructions for host configuration inside the LP instance
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Jürgen Gmach has proposed merging
~jugmac00/launchpad:make-gpg-optional-for-make-lp-user into launchpad:master.
Commit message:
Make gpg optional for make-lp-user
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-user-creation into
launchpad:master.
Commit message:
Fix gpg parsing for names with non ascii signs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00
LGTM
I try to see a pattern for the four different kinds of documentation Daniele
told us about.
I think the "Details section" would belong to the "Explanation" mode.
That is nothing that needs to be done now.
Diff comments:
> diff --git a/doc/running.rst b/doc/running.rst
> new file mode
LGTM - Usually pyupgrade takes care of it.
--
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/412452
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:remove-pep-263-codings into launchpad:master.
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:declare-snap-dependencies-for-jobs into lpcraft:main.
Commit message:
Declare snap dependencies for jobs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:add-configuration-to-provide-packages-to-install into
lpcraft:main.
Commit message:
Declare system package dependencies for jobs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-typo into
launchpad:master.
Commit message:
Fix typo
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411855
--
Your team
Jürgen Gmach has proposed merging
~jugmac00/turnip:pipx-is-not-available-on-bionic-via-apt into turnip:master.
Commit message:
Update README on how to get `pipx`on your system
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:add-lpcraft-environment-configuration into lpcraft:main.
Commit message:
Jobs can now have an environment configuration
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Only made it halfway through until it got too late.
Diff comments:
> diff --git a/doc/running.rst b/doc/running.rst
> new file mode 100644
> index 000..7f9c3a6
> --- /dev/null
> +++ b/doc/running.rst
> @@ -0,0 +1,407 @@
> +=
> +Running Launchpad
> +=
> +
> +..
see inline comment
Diff comments:
> diff --git a/lib/lp/services/database/enumcol.py
> b/lib/lp/services/database/enumcol.py
> index 3360ebe..2ce5d24 100644
> --- a/lib/lp/services/database/enumcol.py
> +++ b/lib/lp/services/database/enumcol.py
> @@ -71,6 +71,8 @@ class DBEnum(SimpleProperty):
LGTM
--
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/411090
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:enumcol-is-deprecated into launchpad:master.
___
Mailing list:
The proposal to merge ~cjwatson/launchpad:enumcol-is-deprecated into
launchpad:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/411090
--
Your team Launchpad code reviewers is requested to
Thank you for your excellent feedback (and preparation).
MP is ready for review.
--
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/410593
Your team Launchpad code reviewers is requested to review the proposed merge of
Jürgen Gmach has proposed merging
~jugmac00/launchpad:apply-pre-commit-run-all-files into launchpad:master.
Commit message:
apply pre-commit run --all-files
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad
Jürgen Gmach has proposed merging
~jugmac00/launchpad:sqlobject-is-a-first-party-import into launchpad:master.
Commit message:
Move the SQLObject wrapper into the lp namespace
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-typo into
launchpad:master.
Commit message:
fix typos
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/410931
--
Your team
Jürgen Gmach has proposed merging
~jugmac00/launchpad:replace-python-memcached-with-pymemcache into
launchpad:master.
Commit message:
Replace unmaintained python-memcached with pymemcache
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
I wonder whether we could simplify
[memcache]
servers: (127.0.0.1:11242,1)
from configs.testrunner.launchpad-lazr.conf
into
[memcache]
server: 127.0.0.1:11242
and thus also
get rid of the regex:
servers = [
(host, int(weight)) for host, weight in re.findall(
Thank you!
--
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411523
Your team Launchpad code reviewers is requested to review the proposed merge of
~jugmac00/launchpad:replace-python-memcached-with-pymemcache into
launchpad:master.
The proposal to merge
~jugmac00/launchpad:replace-python-memcached-with-pymemcache into
launchpad:master has been updated.
Description changed to:
-
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411523
--
Your team Launchpad code reviewers is
The proposal to merge
~jugmac00/launchpad:replace-python-memcached-with-pymemcache into
launchpad:master has been updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411523
--
Your team Launchpad code reviewers is
LGTM
Thanks for that one!
--
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/411549
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:bugs-dbenum into launchpad:master.
___
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-typos-in-layers-py
into launchpad:master.
Commit message:
Fix typos
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411577
Ready for another review.
What maybe still needs to be done is the removal of `python-memcached`.
https://launchpad.readthedocs.io/en/latest/pip.html#add-a-package possibly
suggests to remove replaced/old packages a month after the update...
--
While I have only limited experience with configuring Snaps, this LGTM.
--
https://code.launchpad.net/~cjwatson/lpcraft/+git/lpcraft/+merge/411362
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/lpcraft:snap-skeleton into lpcraft:main.
Jürgen Gmach has proposed merging
~jugmac00/launchpad:create-documentation-via-tox into launchpad:master.
Commit message:
Update documentation building
- build documentation via `tox -e docs`
- pin documentation dependencies (requirements/docs.txt)
- update dependencies via `tox -e update-docs
Jürgen Gmach has proposed merging
~jugmac00/launchpad:update-add-a-package-documentation into launchpad:master.
Commit message:
Update "Add a Package" section as we use setup.cfg nowadays
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details,
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-typo into
launchpad:master.
Commit message:
Fix typo
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411449
--
Your team
More context:
# Write bin/py for compatibility. This is much like
# env/bin/python, but if we just symlink to it and try to
# execute it as bin/py then the virtualenv doesn't get
# activated. We use -S to avoid importing sitecustomize both
I'll take a look throughout the day - will take some time, obviously :-)
--
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/411270
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:xmlrpc-client into launchpad:master.
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-typo into
launchpad:master.
Commit message:
Fix typo
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411206
--
Your team
Colin has already provided a more complete update to the documentation in
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/411453
--
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411454
Your team Launchpad code reviewers is requested to review the
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-another-typo into
launchpad:master.
Commit message:
fix typo
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411487
--
Your
The proposal to merge ~jugmac00/launchpad:update-add-a-package-documentation
into launchpad:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411454
--
Your team Launchpad code reviewers is
Jürgen Gmach has proposed merging
~jugmac00/lp-source-dependencies:pymemcache-3.5.0 into
lp-source-dependencies:master.
Commit message:
Add pymemcache 3.5.0
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lp
Jürgen Gmach has proposed merging
~jugmac00/launchpad:replace-python-memcached-with-pymemcache into
launchpad:master.
Commit message:
Replace unmaintained python-memcached with pymemcache
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
The proposal to merge
~jugmac00/launchpad:replace-python-memcached-with-pymemcache into
launchpad:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411523
--
Your team Launchpad
Thanks, Colin!
I updated the code in `po_import.py` accordingly.
The MP is ready for review.
--
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/412672
Your team Launchpad code reviewers is requested to review the proposed merge of
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:easier-testing-for-argparse-applications into lpcraft:main.
Commit message:
Enable easier testing for argparse applications
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Jürgen Gmach has proposed merging
~jugmac00/launchpad:fix-doctests-for-show-merge-proposal-link into
launchpad:master.
Commit message:
Fix regression in doctests for `show link for merge proposals`
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
Jürgen Gmach has proposed merging ~jugmac00/lpcraft:start-sphinx-documentation
into lpcraft:main.
Commit message:
Start sphinx documentation
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft
see https://ibb.co/9ypHjqJ
--
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/412854
Your team Launchpad code reviewers is requested to review the proposed merge of
~jugmac00/lpcraft:start-sphinx-documentation into lpcraft:main.
___
Jürgen Gmach has proposed merging ~jugmac00/lpcraft:fix-compatibility-with-rtd
into lpcraft:main.
Commit message:
Fix compatibility issue with Read the Docs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft
Jürgen Gmach has proposed merging
~jugmac00/launchpad:add-link-to-all-merge-proposals into launchpad:master.
Commit message:
Add link to all merge proposals
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1951128 in Launchpad itself: "no b
Screenshot -> see Jira issue
--
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/412860
Your team Launchpad code reviewers is requested to review the proposed merge of
~jugmac00/launchpad:add-link-to-all-merge-proposals into launchpad:master.
The readthedocs project can only be created/run successfully after this MP got
merged.
--
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/412854
Your team Launchpad code reviewers is requested to review the proposed merge of
~jugmac00/lpcraft:start-sphinx-documentation into
Jürgen Gmach has proposed merging ~jugmac00/launchpad:build-tarball into
launchpad:master.
Commit message:
Add link to all merge proposals
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1951128 in Launchpad itself: "no button / navigation to list o
Not sure if that matters, but with GHA you cannot re-run a single job yet
(though it is wished a lot). Not sure if we need that feature right from the
beginning (also not sure if we'd come up with a different solution in future,
though).
Related to the above configuration file:
- focal comes
If `run-one` will ever only be used by Launchpad itself, this might be a viable
approach, but though, why can't we use `lpcraft run-one
`? (or if preferred: `lpcraft run-one -j -s -a
` or similar).
I'd like to discuss the proposed index based approach vs a "selector/name"
based approach.
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:compare-crafterrors-directly into lpcraft:main.
Commit message:
Directly compare CraftErrors
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft
The proposal to merge ~jugmac00/lpcraft:compare-crafterrors-directly into
lpcraft:main has been updated.
Description changed to:
Since https://github.com/canonical/craft-cli/pull/41 has landed, you
can compare CraftError objects directly, so there is no more need to
compare the string
Jürgen Gmach has proposed merging ~jugmac00/launchpad:prevent-email-disclosure
into launchpad:master.
Commit message:
Prevent email address disclosure for mirror notifications
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-typo into
launchpad:master.
Commit message:
fix typo
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/412669
--
Your team
Jürgen Gmach has proposed merging ~jugmac00/lpcraft:use-pluggy-for-plugins into
lpcraft:main.
Commit message:
Introduce pluggy to manage internal and external plugins
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00
Jürgen Gmach has proposed merging
~jugmac00/launchpad:update-readme-for-configuration-directory into
launchpad:master.
Commit message:
Fix path to configuration doctest
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Jürgen Gmach has proposed merging ~jugmac00/lpcraft:fix-readthedocs into
lpcraft:main.
Commit message:
Fix autodoc on readthedocs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/413791
Jürgen Gmach has proposed merging
~jugmac00/launchpad:add-minimal-launchpad.yml-parser into launchpad:master.
Commit message:
Add minimal `.launchpad.yaml` parser
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00
On the other hand - this won't be enough to fix the problem, as with `pip
install -r requirements` lpcraft itself won't get installed.
--
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/413791
Your team Launchpad code reviewers is requested to review the proposed merge of
The proposal to merge ~jugmac00/lpcraft:fix-readthedocs into lpcraft:main has
been updated.
Commit message changed to:
WIP: Fix autodoc on readthedocs
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/413791
--
Your team Launchpad code reviewers is
Jürgen Gmach has proposed merging
~jugmac00/lpcraft:add-comment-about-pinning-tox-version into lpcraft:main.
Commit message:
Add todo comment about pinning tox
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00
The MP is now ready to review. Some path manipulation was necessary to make
this work on Read the Docs.
--
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/413791
Your team Launchpad code reviewers is requested to review the proposed merge of
~jugmac00/lpcraft:fix-readthedocs
The proposal to merge ~jugmac00/lpcraft:fix-readthedocs into lpcraft:main has
been updated.
Commit message changed to:
Fix autodoc on readthedocs
For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/413791
--
Your team Launchpad code reviewers is requested
Jürgen Gmach has proposed merging ~jugmac00/turnip:update-linters into
turnip:master.
Commit message:
run `pre-commit autoupdate && pre-commit run --all-files`
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac0
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-typos-for-retrieve
into launchpad:master.
Commit message:
Fix typos
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/414004
Jürgen Gmach has proposed merging ~jugmac00/turnip:add-pytest-makefile-target
into turnip:master.
Commit message:
Add makefile target for pytest
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/turnip/+git/turnip
Jürgen Gmach has proposed merging ~jugmac00/turnip:refactor-format-commit into
turnip:master.
Commit message:
Refactor commit retrieving and formatting
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/turnip/+git
Jürgen Gmach has proposed merging ~jugmac00/turnip:fix-typo-committer into
turnip:master.
Commit message:
Fix typo
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/turnip/+git/turnip/+merge/414042
--
Your team
LGTM (I did not run the tests, as I still face the lxd-agent issue, which at
some point I have to spend some time on)
--
https://code.launchpad.net/~cjwatson/launchpad-buildd/+git/launchpad-buildd/+merge/413899
Your team Launchpad code reviewers is requested to review the proposed merge of
Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-typo-access into
launchpad:master.
Commit message:
Fix typo
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/414065
--
Your
Diff comments:
> diff --git a/lib/lp/services/database/sort_sql.py
> b/lib/lp/services/database/sort_sql.py
> index bc480ce..2a886b3 100644
> --- a/lib/lp/services/database/sort_sql.py
> +++ b/lib/lp/services/database/sort_sql.py
> @@ -1,5 +1,5 @@
> -# Copyright 2009-2010 Canonical Ltd. This
LGTM, three more occurrences left over.
```
$ rg "builder slave"
lib/lp/buildmaster/enums.py
218:The builder slave is ready for use.
224:The builder slave is dirty and needs to be cleaned before use.
230:The builder slave is being cleaned.
```
--
1 - 100 of 510 matches
Mail list logo
