Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/job-oops-timeline into lp:launchpad

Review: Approve code Last time I looked at this I decided I didn't really want to risk enabling SQL logging for jobs (see the request_starttime conditon in connection_raw_execute), but it shouldn't be too terrible hopefully. --

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/gpg-timeline into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/gpg-timeline/+merge/340554 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-build-channels into lp:launchpad

Review: Approve code Diff comments: > === modified file 'lib/lp/snappy/interfaces/snap.py' > --- lib/lp/snappy/interfaces/snap.py 2017-08-22 11:36:30 + > +++ lib/lp/snappy/interfaces/snap.py 2018-02-08 13:37:58 + > @@ -281,17 +282,23 @@ > @operation_parameters( >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archivepublisher-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/archivepublisher-tests-future-imports/+merge/337053 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/optimise-spec-search into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/optimise-spec-search/+merge/338425 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/ppa-vocabulary-strip-prefix into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/ppa-vocabulary-strip-prefix/+merge/340257 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dispatch-build-url into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/dispatch-build-url/+merge/340249 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/anon-dsp into lp:launchpad

William Grant has proposed merging lp:~wgrant/launchpad/anon-dsp into lp:launchpad. Commit message: Allow anonymous launchpad.View on IDistributionSourcePackage. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wgrant

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refactor-run-parts-subprocess into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/refactor-run-parts-subprocess/+merge/336298 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/soyuz-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/soyuz-tests-future-imports/+merge/337042 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pep-3113 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/pep-3113/+merge/336686 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/no-legacy-store-search into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/no-legacy-store-search/+merge/337122 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/no-xrange into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/no-xrange/+merge/337044 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/range-iterator into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/range-iterator/+merge/337043 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/soyuz-browser-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/soyuz-browser-tests-future-imports/+merge/337010 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/who-cares-about-anonymous-consumer-keys into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/who-cares-about-anonymous-consumer-keys/+merge/336864 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/buildmaster-getFile-rename into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/buildmaster-getFile-rename/+merge/336709 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/no-explicit-keyserver-port into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/no-explicit-keyserver-port/+merge/336724 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/more-obvious-updating-repository-notice into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/more-obvious-updating-repository-notice/+merge/336680 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-webservice-get-commit into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-webservice-get-commit/+merge/336604 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/always-https-codebrowse into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/always-https-codebrowse/+merge/336376 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/zope.pagetemplate-4.3.0 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/zope.pagetemplate-4.3.0/+merge/335582 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/twisted-16.5.0 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/twisted-16.5.0/+merge/335534 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/modern-testtools-cleanup into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/modern-testtools-cleanup/+merge/335396 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/no-logtail-only-webhooks into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/no-logtail-only-webhooks/+merge/336479 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/buildd-manager-feature-controller into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/buildd-manager-feature-controller/+merge/336018 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/build-score-threshold-arch into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/build-score-threshold-arch/+merge/335934 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/build-score-threshold-feature into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/build-score-threshold-feature/+merge/335861 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/upgrade-testtools into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/upgrade-testtools/+merge/335395 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/docutils-0.14 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/docutils-0.14/+merge/335551 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pypi-dulwich into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'sourcecode/Makefile' > --- sourcecode/Makefile 2011-11-07 20:29:29 + > +++ sourcecode/Makefile 2017-12-22 10:00:58 + > @@ -3,7 +3,7 @@ > # the ones we test. If we fix them all to have EITHER a good makefile > #

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/upgrade-keystoneclient-swiftclient into lp:launchpad

Review: Approve code We'll probably need to tweak staging configs a bit to effectively test this. Have you verified in any depth against a non-prod Swift? Diff comments: > > === modified file 'lib/lp/services/librarianserver/swift.py' > --- lib/lp/services/librarianserver/swift.py 2015-02-16

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/tidy-makefile into lp:launchpad

Review: Approve code Diff comments: > === modified file 'Makefile' > --- Makefile 2018-01-01 20:24:26 + > +++ Makefile 2018-01-02 04:49:50 + > @@ -472,6 +468,7 @@ > -e 's,%LISTEN_ADDRESS%,$(LISTEN_ADDRESS),' \ > configs/development/local-launchpad-apache >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint-eqeqeq into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/eslint-eqeqeq/+merge/335615 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint-regexes into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/eslint-regexes/+merge/335613 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/relocate-mailman into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/relocate-mailman/+merge/335535 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/buildqueue-hide-empty into lp:launchpad

William Grant has proposed merging lp:~wgrant/launchpad/buildqueue-hide-empty into lp:launchpad. Commit message: Hide the virt/nonvirt queue portlets on BuilderSet:+index if they'd be empty. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/virtualenv-pip into lp:launchpad

Review: Approve code I've played with it locally and can't obviously break it. I'm sure it'll break the build process and production in unknown ways, but we can hardly avoid that. -- https://code.launchpad.net/~cjwatson/launchpad/virtualenv-pip/+merge/331388 Your team Launchpad code reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/tidy-swift-fixture into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/tidy-swift-fixture/+merge/334917 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/webservice-commit-feature-flag into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/webservice-commit-feature-flag/+merge/335287 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refresh-test-ssh-key into lp:launchpad

Review: Approve code "Twisted >= 16.0.0 uses cryptography, which forbids such short keys." is a little ambiguous, but neither meaning is particularly wrong... -- https://code.launchpad.net/~cjwatson/launchpad/refresh-test-ssh-key/+merge/335257 Your team Launchpad code reviewers is subscribed to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bmp-export-scheduleDiffUpdates into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/bmp-export-scheduleDiffUpdates/+merge/334256 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad-buildd/buildd-slave-tac-manifest-fix into lp:launchpad-buildd

William Grant has proposed merging lp:~wgrant/launchpad-buildd/buildd-slave-tac-manifest-fix into lp:launchpad-buildd. Commit message: Fix inclusion of buildd-slave.tac in MANIFEST.in. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/upgrade-zope-interface into lp:launchpad

Review: Approve code Yes. -- https://code.launchpad.net/~cjwatson/launchpad/upgrade-zope-interface/+merge/334110 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/use-more-statistics into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/use-more-statistics/+merge/333933 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-rocketfuel-flakes-leftover into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-rocketfuel-flakes-leftover/+merge/333932 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/download-cache-git into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/download-cache-git/+merge/333931 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/staging-restore-hax into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~wgrant/launchpad/staging-restore-hax/+merge/333787 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/staging-restore-hax into lp:launchpad

William Grant has proposed merging lp:~wgrant/launchpad/staging-restore-hax into lp:launchpad. Commit message: Fix staging restores and make them more verbose. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wgrant

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-fix-js-status into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-fix-js-status/+merge/330015 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/utilities-run-as into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/utilities-run-as/+merge/332290 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/beautifulsoup-wrapper into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/beautifulsoup-wrapper/+merge/332599 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/beautifulsoup-no-deprecated into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/beautifulsoup-no-deprecated/+merge/332601 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/gather-more-statistics into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/gather-more-statistics/+merge/333481 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/front-page-bulk into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/front-page-bulk/+merge/333510 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/hasquerycount-legible-mismatch into lp:launchpad

Review: Approve code Oh nice, I hadn't realised colourisation was viable. -- https://code.launchpad.net/~cjwatson/launchpad/hasquerycount-legible-mismatch/+merge/333244 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/branch-unscan-affordances into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'lib/lp/code/interfaces/branch.py' > --- lib/lp/code/interfaces/branch.py 2016-11-11 12:51:58 + > +++ lib/lp/code/interfaces/branch.py 2017-11-06 09:48:10 + > @@ -538,6 +538,10 @@ > pending_writes = Attribute( >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-precise-hacks into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-precise-hacks/+merge/332892 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/improve-dpkg-architecture-cache into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/improve-dpkg-architecture-cache/+merge/332853 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'utilities/lint' > --- utilities/lint2017-01-17 22:23:39 + > +++ utilities/lint2017-07-23 03:47:01 + > @@ -31,10 +31,21 @@ > fi > > # Sample data contains auto generated files with long lines. >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/blueprints-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/blueprints-tests-future-imports/+merge/332799 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bugtracker-sanitize-name-lowercase into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/bugtracker-sanitize-name-lowercase/+merge/332715 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/answers-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/answers-tests-future-imports/+merge/332778 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/answers-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/answers-tests-future-imports/+merge/332778 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bugzilla-without-credentials into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/bugzilla-without-credentials/+merge/332735 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snappy-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snappy-tests-future-imports/+merge/332570 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bugtracker-redhat-fixes into lp:launchpad

Diff comments: > > === modified file 'lib/lp/bugs/externalbugtracker/bugzilla.py' > --- lib/lp/bugs/externalbugtracker/bugzilla.py2017-01-14 07:41:41 > + > +++ lib/lp/bugs/externalbugtracker/bugzilla.py2017-10-20 11:30:23 > + > @@ -839,12 +844,18 @@ > comment

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bugtracker-redhat-fixes into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'lib/lp/bugs/externalbugtracker/bugzilla.py' > --- lib/lp/bugs/externalbugtracker/bugzilla.py2017-01-14 07:41:41 > + > +++ lib/lp/bugs/externalbugtracker/bugzilla.py2017-10-20 11:30:23 > + > @@ -296,6 +300,7

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/optimise-bin-py into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/optimise-bin-py/+merge/331863 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/frontend-dependencies into lp:meta-lp-deps

Review: Approve code -- https://code.launchpad.net/~cjwatson/meta-lp-deps/frontend-dependencies/+merge/331760 Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/code-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/code-tests-future-imports/+merge/331764 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/batch-snap-listing into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/batch-snap-listing/+merge/332085 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/answers-hide-inactive-projects into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/answers-hide-inactive-projects/+merge/331981 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pyopenssl-0.15.1 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/pyopenssl-0.15.1/+merge/331889 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/python-memcached-1.58 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/python-memcached-1.58/+merge/331911 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/pyopenssl-deps into lp:meta-lp-deps

Review: Approve code -- https://code.launchpad.net/~cjwatson/meta-lp-deps/pyopenssl-deps/+merge/331954 Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/code-bzr-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/code-bzr-tests-future-imports/+merge/331762 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/code-git-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/code-git-tests-future-imports/+merge/331761 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/code-browser-tests-future-imports into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/code-browser-tests-future-imports/+merge/331758 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/htpasswd-salt into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/htpasswd-salt/+merge/332013 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/sorted-apache-logs-by-age into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/sorted-apache-logs-by-age/+merge/331890 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/sorted-apache-logs into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/sorted-apache-logs/+merge/331809 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/gPPFID-email-argh into lp:launchpad

William Grant has proposed merging lp:~wgrant/launchpad/gPPFID-email-argh into lp:launchpad. Commit message: Fix getPrecachedPersonsFromIDs to handle teams with mailing lists. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/external-dependencies-trusted into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/external-dependencies-trusted/+merge/331490 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/external-dependencies-trusted into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/external-dependencies-trusted/+merge/331490 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/fix-memcache-error-message into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/fix-memcache-error-message/+merge/331417 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dsp-code into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/dsp-code/+merge/331424 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/drop-sourcecodegen into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/drop-sourcecodegen/+merge/331265 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-apiindex into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-apiindex/+merge/331241 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/build-twisted-plugin-cache into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/build-twisted-plugin-cache/+merge/331240 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/allow-header-syntax into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/allow-header-syntax/+merge/330885 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/ampoule-0.2.0.post1 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/ampoule-0.2.0.post1/+merge/330862 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-buildout-recipes into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-buildout-recipes/+merge/330159 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/disable-pot-generation into lp:launchpad

Review: Approve code what will we ever do -- https://code.launchpad.net/~cjwatson/launchpad/disable-pot-generation/+merge/330157 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-geonames-identity into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-geonames-identity/+merge/330355 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-mime-tests into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-mime-tests/+merge/330156 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/storm-datetime into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/storm-datetime/+merge/330086 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/buildd-148-compat into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/buildd-148-compat/+merge/330661 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-set-git-path into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-set-git-path/+merge/329360 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/upgrade-oops into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/upgrade-oops/+merge/330118 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

<    1   2   3   4   5   6   7   8   9   10   >