Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/drop-gpgservice-deps into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/drop-gpgservice-deps/+merge/330116 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/bug-1707890 into lp:launchpad

William Grant has proposed merging lp:~wgrant/launchpad/bug-1707890 into lp:launchpad. Commit message: Fix Translations' text_to_html to not parse HTML as a C format string. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1707890 in Launchpad itself

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/show-signing-key-fingerprints into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/show-signing-key-fingerprints/+merge/328305 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/mp-revision-id-text-line into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/mp-revision-id-text-line/+merge/328082 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/series-for-all-builds into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/series-for-all-builds/+merge/328097 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/choose-icon into lp:launchpad

Review: Approve -- https://code.launchpad.net/~cjwatson/launchpad/choose-icon/+merge/327983 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/improve-livefs-scoring into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/improve-livefs-scoring/+merge/327639 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-check-proxy-config into lp:launchpad

Review: Approve -- https://code.launchpad.net/~cjwatson/launchpad/snap-check-proxy-config/+merge/327975 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/better-upload-error-notifications into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'lib/lp/archiveuploader/dscfile.py' > --- lib/lp/archiveuploader/dscfile.py 2016-06-01 01:59:32 + > +++ lib/lp/archiveuploader/dscfile.py 2016-11-17 17:09:06 + > @@ -144,6 +144,9 @@ > if verify_signature: >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/yui-autocomplete into lp:launchpad

Review: Approve code Looks fine to me. Better, even. Nice find. -- https://code.launchpad.net/~cjwatson/launchpad/yui-autocomplete/+merge/327804 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/yarn into lp:launchpad

Review: Approve Is xenial's nodejs reasonably new? Can we backport it to precise, or do we want to wait a few weeks? Diff comments: > > === modified file 'Makefile' > --- Makefile 2017-05-11 14:15:36 + > +++ Makefile 2017-07-20 17:52:40 + > @@ -159,17 +159,20 @@ > $(JS_BUILD_DIR):

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint-abolish-test-should into lp:launchpad

Review: Approve -- https://code.launchpad.net/~cjwatson/launchpad/eslint-abolish-test-should/+merge/327932 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint-declare-vars into lp:launchpad

Review: Approve -- https://code.launchpad.net/~cjwatson/launchpad/eslint-declare-vars/+merge/327900 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint-remove-unused-vars into lp:launchpad

Review: Approve -- https://code.launchpad.net/~cjwatson/launchpad/eslint-remove-unused-vars/+merge/327894 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint-remove-dead-code into lp:launchpad

Review: Approve -- https://code.launchpad.net/~cjwatson/launchpad/eslint-remove-dead-code/+merge/327892 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-inline-filebug-base-url into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-inline-filebug-base-url/+merge/327881 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/tour-css-browser-selector-0.4.0 into lp:launchpad

Review: Approve -- https://code.launchpad.net/~cjwatson/launchpad/tour-css-browser-selector-0.4.0/+merge/327883 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-inline-comment-id-leftovers into lp:launchpad

Review: Approve -- https://code.launchpad.net/~cjwatson/launchpad/remove-inline-comment-id-leftovers/+merge/327875 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/misc-js-tidying into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/misc-js-tidying/+merge/327790 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-add-branch-leftovers into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-add-branch-leftovers/+merge/327869 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

[Launchpad-reviewers] [Merge] lp:~wgrant/python-oops-tools/prune-by-date into lp:python-oops-tools

William Grant has proposed merging lp:~wgrant/python-oops-tools/prune-by-date into lp:python-oops-tools. Commit message: Fix prune to find oldest OOPS by date, not by ID. Requested reviews: python-oops-tools reviewers (oops-tools-reviewers) For more details, see: https://code.launchpad.net

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/tidy-incompatible-arguments-exception into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/tidy-incompatible-arguments-exception/+merge/326534 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/lazr-restful-0.20.0 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/lazr-restful-0.20.0/+merge/326485 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/buster into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~wgrant/launchpad/buster/+merge/326500 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/buster into lp:launchpad

William Grant has proposed merging lp:~wgrant/launchpad/buster into lp:launchpad. Commit message: Add gina_target.buster. It's already in production configs. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wgrant/launchpad

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/twisted-job-runner-logging into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/twisted-job-runner-logging/+merge/325634 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-upload-retry-502-503 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-upload-retry-502-503/+merge/325536 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-bad-refresh-response-mail into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-bad-refresh-response-mail/+merge/325508 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-better-upload-failures into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-better-upload-failures/+merge/325492 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-tools-fingerprint into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-tools-fingerprint/+merge/325620 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/debug-snap-upload-auth into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/debug-snap-upload-auth/+merge/325449 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pu-getFileByName-binary into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/pu-getFileByName-binary/+merge/325564 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/send-keys-to-builders into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/send-keys-to-builders/+merge/323438 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/upcoming-optimisation-mk2 into lp:launchpad

William Grant has proposed merging lp:~wgrant/launchpad/upcoming-optimisation-mk2 into lp:launchpad. Commit message: Force +upcomingwork to apply the spec privacy check only to relevant specs. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1696519

Re: [Launchpad-reviewers] [Merge] lp:~hloeung/canonical-mojo-specs/update-add-floating-ip-lp-snap-proxy into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk

Review: Approve -- https://code.launchpad.net/~hloeung/canonical-mojo-specs/update-add-floating-ip-lp-snap-proxy/+merge/325208 Your team Launchpad code reviewers is subscribed to branch lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-branch-popup-widget into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-branch-popup-widget/+merge/324475 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/upcoming-optimisation into lp:launchpad

Diff comments: > === modified file 'lib/lp/registry/model/person.py' > --- lib/lp/registry/model/person.py 2017-04-22 13:09:01 + > +++ lib/lp/registry/model/person.py 2017-06-06 08:18:21 + > @@ -1434,6 +1434,32 @@ > from lp.registry.model.distribution import Distribution >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-ssh-vulnkey into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-ssh-vulnkey/+merge/324935 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/upcoming-optimisation into lp:launchpad

William Grant has proposed merging lp:~wgrant/launchpad/upcoming-optimisation into lp:launchpad. Commit message: Optimise Person.getAssignedSpecificationWorkItemsDueBefore main query. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1692120 in Launchpad

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/optimise-getPublishedBinaries into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/optimise-getPublishedBinaries/+merge/325028 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-mp-better-title into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/git-mp-better-title/+merge/324533 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/mp-job-new-revision-author into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/mp-job-new-revision-author/+merge/324641 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/https-cve into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/https-cve/+merge/324880 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/docutils-0.13.1 into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/docutils-0.13.1/+merge/324879 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/person-product-privacy into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'lib/lp/registry/model/personproduct.py' > --- lib/lp/registry/model/personproduct.py2015-07-08 16:05:11 + > +++ lib/lp/registry/model/personproduct.py2017-05-26 17:23:18 + > @@ -45,3 +45,11 @@ > > def

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-gpgservice-config into lp:launchpad

Review: Approve -- https://code.launchpad.net/~cjwatson/launchpad/remove-gpgservice-config/+merge/324669 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-branch-set-api into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-branch-set-api/+merge/324474 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/mp-setStatus-merged-revision into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/mp-setStatus-merged-revision/+merge/324399 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/mirror-prober-extra-slashes into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/mirror-prober-extra-slashes/+merge/324379 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-xenial into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-xenial/+merge/324104 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/quieten-tests into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/quieten-tests/+merge/323918 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-path-HEAD into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/git-path-HEAD/+merge/323660 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/faster-archive-signing-key-tests into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/faster-archive-signing-key-tests/+merge/323429 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archive-dependencies-unittest into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/archive-dependencies-unittest/+merge/323129 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-funkload-webunit into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-funkload-webunit/+merge/323915 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-mailman-pythonpath into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-mailman-pythonpath/+merge/323912 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/composeBuildRequest-deferred into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/composeBuildRequest-deferred/+merge/323401 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-buildout-templates into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-buildout-templates/+merge/323744 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-buildout-bin-test into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-buildout-bin-test/+merge/323743 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/queue-upload-file-links into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/queue-upload-file-links/+merge/323708 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/unsigned-source-buildinfo into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/unsigned-source-buildinfo/+merge/323530 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/person-ppas-timeout into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/person-ppas-timeout/+merge/322995 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/fix-create-bot-account-tests into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/fix-create-bot-account-tests/+merge/323742 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-lpbuildd-pottery-dependencies into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-lpbuildd-pottery-dependencies/+merge/323850 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/unverified-salesforce-proxy into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/unverified-salesforce-proxy/+merge/323661 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-find-by-url-prefixes into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-find-by-url-prefixes/+merge/323035 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

[Launchpad-reviewers] [Merge] lp:~wgrant/lazr-postgresql/no-filename-sort into lp:lazr-postgresql

William Grant has proposed merging lp:~wgrant/lazr-postgresql/no-filename-sort into lp:lazr-postgresql. Commit message: Sort patches by their version elements, not by filename. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/buildinfo-multiple-binary into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/buildinfo-multiple-binary/+merge/322956 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/store-buildinfo into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'lib/lp/soyuz/interfaces/binarypackagebuild.py' > --- lib/lp/soyuz/interfaces/binarypackagebuild.py 2016-01-08 13:15:02 > + > +++ lib/lp/soyuz/interfaces/binarypackagebuild.py 2017-03-29 22:36:06 > + > @@ -157,6

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-store-upload-error-debug into lp:launchpad

Review: Approve code Let's just hope it doesn't echo back the whole blob. -- https://code.launchpad.net/~cjwatson/launchpad/snap-store-upload-error-debug/+merge/322715 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/ttb-from-disk into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'lib/lp/translations/model/translationimportqueue.py' > --- lib/lp/translations/model/translationimportqueue.py 2015-07-08 > 16:05:11 + > +++ lib/lp/translations/model/translationimportqueue.py 2017-04-19 > 11:20:19

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/fix-mp-extract-candidate-bug-id into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/fix-mp-extract-candidate-bug-id/+merge/322531 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-build-job-repr into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-build-job-repr/+merge/322699 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-sprint-link-unlink-spec into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-sprint-link-unlink-spec/+merge/322108 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/root-public-blueprint-count into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/root-public-blueprint-count/+merge/322563 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bugtask-distroseries-sort-by-version into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/bugtask-distroseries-sort-by-version/+merge/322467 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/optimise-binary-deletion into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/optimise-binary-deletion/+merge/322443 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/delete-sprint into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'lib/lp/blueprints/browser/configure.zcml' > --- lib/lp/blueprints/browser/configure.zcml 2014-11-24 06:20:03 + > +++ lib/lp/blueprints/browser/configure.zcml 2017-04-09 08:45:48 + > @@ -78,6 +78,13 @@ >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-store-revision into lp:launchpad

Review: Approve code Seems like we might also want to record the snap-id, since name remapping will happen at some point,. -- https://code.launchpad.net/~cjwatson/launchpad/snap-store-revision/+merge/321712 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/lists-footer into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/lists-footer/+merge/321686 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/webhook-job-ordering into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/webhook-job-ordering/+merge/321188 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-repr into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-repr/+merge/321195 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-webhook-store-status into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-webhook-store-status/+merge/320295 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~stub/launchpad/botbake into lp:launchpad

Review: Approve code I'd marginally prefer that the team stuff were moved into an API script, but if you don't care then this is fine. -- https://code.launchpad.net/~stub/launchpad/botbake/+merge/319445 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

Re: [Launchpad-reviewers] [Merge] lp:~stub/launchpad/botbake into lp:launchpad

Diff comments: > > === added file 'lib/lp/registry/scripts/createbotaccount.py' > --- lib/lp/registry/scripts/createbotaccount.py 1970-01-01 00:00:00 > + > +++ lib/lp/registry/scripts/createbotaccount.py 2017-03-13 15:07:05 > + > @@ -0,0 +1,129 @@ > +# Copyright 2017

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/privacy-skip-codereviewvote-reviewer into lp:launchpad

William Grant has proposed merging lp:~wgrant/launchpad/privacy-skip-codereviewvote-reviewer into lp:launchpad. Commit message: Allow team privacy changes when referenced by CodeReviewVote.reviewer. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-builds-batching into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-builds-batching/+merge/319380 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-store-upload-state-api into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-store-upload-state-api/+merge/318396 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-release-fix-macaroon-auth into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-release-fix-macaroon-auth/+merge/318352 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dpkg-architecture-subprocess-timeline into lp:launchpad

Review: Approve code Worth including DEB_HOST_ARCH too? Though it really shouldn't matter... -- https://code.launchpad.net/~cjwatson/launchpad/dpkg-architecture-subprocess-timeline/+merge/317381 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-rescan-api into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/git-rescan-api/+merge/316956 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/generalise-macaroon-auth into lp:launchpad

Review: Approve code We should really have made it just a list of macaroons, but this makes the situation no worse. -- https://code.launchpad.net/~cjwatson/launchpad/generalise-macaroon-auth/+merge/315773 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/check-keys-from-keyserver into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/check-keys-from-keyserver/+merge/315677 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/isolate-launchpadlib-tests into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/isolate-launchpadlib-tests/+merge/316083 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snapcraft-yaml-more-paths into lp:launchpad

Review: Approve code I'd almost be tempted to turn it into a lop at this point. -- https://code.launchpad.net/~cjwatson/launchpad/snapcraft-yaml-more-paths/+merge/316084 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-buildout-bin-python-easy into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-buildout-bin-python-easy/+merge/314976 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-buildout-bin-shell into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-buildout-bin-shell/+merge/314973 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/normalise-mlist-sync into lp:launchpad

Review: Approve code Intriguingly, this reverses a change that was made only five years ago, though I cannot discern the rationale. It is conceivable that it was to force it to use python2.7, though I can't see why it was only ever that script. --

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/testopenid-certificate into lp:launchpad

Review: Approve code Diff comments: > > === modified file 'lib/lp/services/webapp/login.py' > --- lib/lp/services/webapp/login.py 2016-05-19 02:02:39 + > +++ lib/lp/services/webapp/login.py 2017-01-14 15:45:28 + > @@ -160,11 +159,7 @@ > name='+basiclogin') > > >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/xenial-apt-tests into lp:launchpad

Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/xenial-apt-tests/+merge/314700 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

<    1   2   3   4   5   6   7   8   9   10   >