Re: [Launchpad-reviewers] [Merge] ~nteodosio/launchpad-buildd:disk-space into launchpad-buildd:master

2024-08-27 Thread Colin Watson
Review: Approve -- https://code.launchpad.net/~nteodosio/launchpad-buildd/+git/launchpad-buildd/+merge/472047 Your team Launchpad code reviewers is requested to review the proposed merge of ~nteodosio/launchpad-buildd:disk-space into launchpad-buildd:master. __

[Launchpad-reviewers] [Merge] lp:~cjwatson/python-pgbouncer/drop-py2 into lp:python-pgbouncer

2024-07-30 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/python-pgbouncer/drop-py2 into lp:python-pgbouncer. Commit message: Drop Python 2 support. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/python-pgbouncer/drop-py2

[Launchpad-reviewers] [Merge] ~cjwatson/lp-archive:typos into lp-archive:main

2024-04-10 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lp-archive:typos into lp-archive:main. Commit message: Fix a couple of typos in the landing page Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp-archive/+git/lp

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:drop-py35 into launchpad:master

2024-03-17 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:drop-py35 into launchpad:master. Commit message: Drop various bits of code to handle Python <= 3.5 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launch

[Launchpad-reviewers] [Merge] ~cjwatson/lp-mailman:charm into lp-mailman:master

2023-11-28 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lp-mailman:charm into lp-mailman:master. Commit message: Add a basic charm Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp-mailman/+git/lp-mailman/+merge/456439 This

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:black-py38 into launchpad:master

2023-11-28 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:black-py38 into launchpad:master. Commit message: Upgrade Black's target Python version to 3.8 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:upgrade-type-annotations into launchpad:master

2023-11-28 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:upgrade-type-annotations into launchpad:master. Commit message: Upgrade variable type annotations to 3.6+ style Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:rework-archive-job-series-check into launchpad:master

2023-11-27 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:rework-archive-job-series-check into launchpad:master. Commit message: Rework CI build upload series check to use DistroSeriesParent Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-postgresql-extras-push-backups-primary-only into launchpad:master

2023-11-26 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-postgresql-extras-push-backups-primary-only into launchpad:master. Commit message: charm: Only run push-backups on primary database units Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:simplify-git-branch-handling into launchpad:master

2023-11-22 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:simplify-git-branch-handling into launchpad:master. Commit message: Revert "Restore compatibility with xenial's git" Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://cod

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:preflight-juju-fragile-users into launchpad:master

2023-11-22 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:preflight-juju-fragile-users into launchpad:master. Commit message: preflight: Add Juju-style user names to FRAGILE_USERS Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-push-backups-run-one into launchpad:master

2023-11-22 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-push-backups-run-one into launchpad:master. Commit message: charm: Run postgresql-extras push-backups under run-one Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:staging-restore-in-place-again into launchpad:master

2023-11-22 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:staging-restore-in-place-again into launchpad:master. Commit message: Remove conflicting --dbname options Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

Re: [Launchpad-reviewers] [Merge] ~xnox/launchpad:drop-i18n-index into launchpad:master

2023-11-22 Thread Colin Watson
Review: Approve Diff comments: > diff --git a/lib/lp/registry/interfaces/distroseries.py > b/lib/lp/registry/interfaces/distroseries.py > index bcb5a24..d27ac20 100644 > --- a/lib/lp/registry/interfaces/distroseries.py > +++ b/lib/lp/registry/interfaces/distroseries.py > @@ -585,6 +585,17 @@ c

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:doc-qastaging into launchpad-buildd:master

2023-11-22 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:doc-qastaging into launchpad-buildd:master. Commit message: doc: Replace dogfood with qastaging Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/lp-archive:doc-qastaging into lp-archive:main

2023-11-22 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lp-archive:doc-qastaging into lp-archive:main. Commit message: doc: Explain qastaging deployment Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp-archive/+git/lp

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:staging-restore-in-place-again into launchpad:master

2023-11-21 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:staging-restore-in-place-again into launchpad:master. Commit message: Revert "Build staging db inplace due to lack of disk space" Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details,

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:gpg-eddsa into launchpad:master

2023-11-21 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:gpg-eddsa into launchpad:master. Commit message: Add support for EdDSA GnuPG keys Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1827369 in Launchpad itself: "Launchpad cannot handle ECC or Ed

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:pyupgrade-py38 into launchpad:master

2023-11-21 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:pyupgrade-py38 into launchpad:master. Commit message: Run "pyupgrade --py38-plus" Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-push-backups-argument-ordering into launchpad:master

2023-11-21 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-push-backups-argument-ordering into launchpad:master. Commit message: charm: Fix argument ordering in postgresql-extras cron job Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:fix-swift-db-pruning into launchpad:master

2023-11-21 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:fix-swift-db-pruning into launchpad:master. Commit message: Fix pruning of DB branch builds from Swift Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

Re: [Launchpad-reviewers] [Merge] lp:~ines-almeida/canonical-mojo-specs/remove-old-ppa-units into lp:canonical-mojo-specs

2023-11-21 Thread Colin Watson
This is a duplicate of https://code.launchpad.net/~cjwatson/canonical-mojo-specs/lp-remove-old-ppa/+merge/455789. -- https://code.launchpad.net/~ines-almeida/canonical-mojo-specs/remove-old-ppa-units/+merge/455961 Your team Launchpad code reviewers is requested to review the proposed merge of lp

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:mirror-prober-silence-tunnel-errors into launchpad:master

2023-11-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:mirror-prober-silence-tunnel-errors into launchpad:master. Commit message: Silence TunnelError OOPSes from the mirror prober Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] lp:~cjwatson/lpbuildbot/drop-xenial into lp:lpbuildbot

2023-11-20 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/lpbuildbot/drop-xenial into lp:lpbuildbot. Commit message: Drop xenial builders. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lpbuildbot/drop-xenial/+merge/455899

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:staging-restore-fixes into launchpad:master

2023-11-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:staging-restore-fixes into launchpad:master. Commit message: replication: Fix several issues with remote staging-restore Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-db-update-postgresql-client into launchpad:master

2023-11-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-db-update-postgresql-client into launchpad:master. Commit message: charm: Add postgresql-client to launchpad-db-update Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:doc-riscv64 into launchpad-buildd:master

2023-11-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:doc-riscv64 into launchpad-buildd:master. Commit message: doc: riscv64 builders are no longer managed separately Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-db-update-fix-backend-connections into launchpad:master

2023-11-17 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-db-update-fix-backend-connections into launchpad:master. Commit message: charm: Fix launchpad-db-update's connections to backend databases Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details

Re: [Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:cgroup2 into launchpad-buildd:master

2023-11-16 Thread Colin Watson
@xnox I admire your optimism that xenial won't have its support lifetime extended in perpetuity! -- https://code.launchpad.net/~cjwatson/launchpad-buildd/+git/launchpad-buildd/+merge/455733 Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad-buildd

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-buildd:cgroup2 into launchpad-buildd:master

2023-11-16 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-buildd:cgroup2 into launchpad-buildd:master. Commit message: Add lxc.cgroup2.* configuration Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad-buildd

[Launchpad-reviewers] [Merge] ~cjwatson/txpkgupload:charm-handle-build-label-change into txpkgupload:master

2023-11-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/txpkgupload:charm-handle-build-label-change into txpkgupload:master. Commit message: charm: Handle build_label changes Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-codehosting-sync-branches-action into launchpad:master

2023-11-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-codehosting-sync-branches-action into launchpad:master. Commit message: charm: Add a sync-branches action to launchpad-codehosting Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-codehosting-ro into launchpad:master

2023-11-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-codehosting-ro into launchpad:master. Commit message: charm: Allow codehosting access to the "ro" role Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-riscv64-timeout into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-11-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-riscv64-timeout into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder. Commit message: vbuilder: Bump sbuild-stalled-package-timeout to 1500 on riscv64 Requested reviews: Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-ppa-publisher-missing-import into launchpad:master

2023-11-15 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-ppa-publisher-missing-import into launchpad:master. Commit message: charm: Add missing import to ppa-publisher secrets template Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-codehosting-rsync-mirrors into launchpad:master

2023-11-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-codehosting-rsync-mirrors into launchpad:master. Commit message: charm: Add bzr_repositories_rsync_hosts_allow option to codehosting Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-artifactory-write-credentials into launchpad:master

2023-11-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-artifactory-write-credentials into launchpad:master. Commit message: charm: Add artifactory_write_credentials option to ppa-publisher Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:fix-refactor-team-membership-active-states into launchpad:master

2023-11-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:fix-refactor-team-membership-active-states into launchpad:master. Commit message: Fix test regression caused by ACTIVE_STATES refactoring Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/txpkgupload:charm-ipv6 into txpkgupload:master

2023-11-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/txpkgupload:charm-ipv6 into txpkgupload:master. Commit message: charm: Make haproxy listen on both IPv4 and IPv6 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-ppa-artifactory into launchpad:master

2023-11-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-ppa-artifactory into launchpad:master. Commit message: charm: Add artifactory_base_url option to ppa-publisher Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:signing-cleanup into launchpad:master

2023-11-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:signing-cleanup into launchpad:master. Commit message: signing: Clean up installed directory on failures Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/txpkgupload:charm-send-sftp-port into txpkgupload:master

2023-11-14 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/txpkgupload:charm-send-sftp-port into txpkgupload:master. Commit message: charm: Tell haproxy to send to the SFTP port Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-update-log-hosts-allow into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-11-13 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-update-log-hosts-allow into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder. Commit message: vbuilder: Allow launchpad-bastion-ps5.internal to rsync logs Requested reviews: Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-ppa-fix-oval-data into launchpad:master

2023-11-13 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-ppa-fix-oval-data into launchpad:master. Commit message: charm: Fix oval_data_root in ppa-publisher Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad-mojo-specs/+git/private:add-bos03-arm64-arch into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-11-13 Thread Colin Watson
Review: Approve -- https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/455512 Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder. ___ Mailing list: https://l

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:update-sync-branches-source into launchpad:master

2023-11-13 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:update-sync-branches-source into launchpad:master. Commit message: Update rsync source used by sync-branches Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad-mojo-specs/+git/private:add-bos03-arm64-arch into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-11-13 Thread Colin Watson
Review: Approve -- https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/455499 Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder. ___ Mailing list: https://l

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-codehosting-fix-mount-instructions into launchpad:master

2023-11-13 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-codehosting-fix-mount-instructions into launchpad:master. Commit message: charm: Fix instructions for mounting codehosting data volume Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:logintoken-typos into launchpad:master

2023-11-09 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:logintoken-typos into launchpad:master. Commit message: Fix typos in OpenPGP key import error message Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad-mojo-specs/+git/private:add-bos03-arm64-arch into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-11-07 Thread Colin Watson
Review: Approve -- https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/455059 Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder. ___ Mailing list: https://l

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-codehosting-reload-apache2 into launchpad:master

2023-11-07 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-codehosting-reload-apache2 into launchpad:master. Commit message: charm: Reload apache2 on codehosting config changes Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:pre-commit-autoupdate into launchpad:master

2023-11-07 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:pre-commit-autoupdate into launchpad:master. Commit message: Update pre-commit hooks Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:branch-hosting-import-policy into launchpad:master

2023-11-07 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:branch-hosting-import-policy into launchpad:master. Commit message: Fix import policy violation with InvalidRevisionException Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:refactor-team-membership-active-states into launchpad:master

2023-11-07 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:refactor-team-membership-active-states into launchpad:master. Commit message: Use ACTIVE_STATES in more places for team membership status checks Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see

[Launchpad-reviewers] [Merge] ~xnox/launchpad/+git/launchpad-private:deathrow-patch into launchpad:master

2023-11-05 Thread Colin Watson
The proposal to merge ~xnox/launchpad/+git/launchpad-private:deathrow-patch into launchpad:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~xnox/launchpad/+git/launchpad-private/+merge/452676 -- Your team Launchpad code reviewers is

Re: [Launchpad-reviewers] [Merge] ~xnox/launchpad/+git/launchpad-private:deathrow-patch into launchpad:master

2023-11-05 Thread Colin Watson
I somehow entirely failed to notice this when preparing https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/454759 (which is very similar except that it also includes necessary changes to some test cases), even though I swear I looked. Sorry! Anyway, that's deployed and on pr

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad-mojo-specs/+git/private:add-bos03-arm64-arch into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-11-04 Thread Colin Watson
Review: Needs Fixing A good first try! Needs a few fixes, but something like this should work. Diff comments: > diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml > index c601076..ec2d038 100644 > --- a/vbuilder/bundle.yaml > +++ b/vbuilder/bundle.yaml > @@ -131,7 +131,7 @@ > {%- set o

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:invent-kde-org-blobs into launchpad:master

2023-11-02 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:invent-kde-org-blobs into launchpad:master. Commit message: Support fetching blobs from repositories on invent.kde.org Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2040260 in Launchpad itself

[Launchpad-reviewers] [Merge] ~cjwatson/lp-archive:always-set-cache-control into lp-archive:main

2023-11-02 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lp-archive:always-set-cache-control into lp-archive:main. Commit message: Always set Cache-Control header on redirect responses Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-fix-rebuilds-index into launchpad:master

2023-10-30 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-fix-rebuilds-index into launchpad:master. Commit message: charm: Fix rebuild-test.internal indexes Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-fix-derived-archive-vhost into launchpad:master

2023-10-30 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-fix-derived-archive-vhost into launchpad:master. Commit message: charm: Fix derived.archive.canonical.com vhost config Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/txpkgupload:charm-fix-log-messages into txpkgupload:master

2023-10-29 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/txpkgupload:charm-fix-log-messages into txpkgupload:master. Commit message: charm: Fix missing space in log messages Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:pre-commit-flake8-bugbear into launchpad:master

2023-10-28 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:pre-commit-flake8-bugbear into launchpad:master. Commit message: pre-commit: Enable flake8-bugbear Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:loggerhead-max-requests into launchpad:master

2023-10-28 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:loggerhead-max-requests into launchpad:master. Commit message: loggerhead: Set Gunicorn max_requests to 2000 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:deathrow-sha256 into launchpad:master

2023-10-28 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:deathrow-sha256 into launchpad:master. Commit message: deathrow: Compare SHA-256 hashes instead of MD5 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:snap-improve-infer-pro-enable into launchpad:master

2023-10-27 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:snap-improve-infer-pro-enable into launchpad:master. Commit message: snap: Improve some edge cases in inferProEnable Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-copy-archive-publisher-archives-dir into launchpad:master

2023-10-26 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-copy-archive-publisher-archives-dir into launchpad:master. Commit message: charm: Set archives_dir for copy archive publisher Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-admin-bot-account-actions into launchpad:master

2023-10-26 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-admin-bot-account-actions into launchpad:master. Commit message: charm: Add launchpad-admin actions to manage bot accounts Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-loggerhead-enable into launchpad:master

2023-10-26 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-loggerhead-enable into launchpad:master. Commit message: charm: Enable launchpad-loggerhead service Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:fix-bugbear-unused-loop-variables into launchpad:master

2023-10-23 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:fix-bugbear-unused-loop-variables into launchpad:master. Commit message: Fix test failures caused by "Remove/rename unused loop variables" Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details,

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-bump-launchpad-layers into launchpad:master

2023-10-23 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-bump-launchpad-layers into launchpad:master. Commit message: charm: Bump launchpad-layers to 0fd04056ad Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:publisher-parts-dependencies into launchpad-layers:main

2023-10-21 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:publisher-parts-dependencies into launchpad-layers:main. Commit message: Add dependencies of lp:ubuntu-archive-publishing Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-bump-launchpad-layers into launchpad:master

2023-10-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-bump-launchpad-layers into launchpad:master. Commit message: charm: Bump launchpad-layers to 91defc3073 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-layers:fix-publisher-parts-directory into launchpad-layers:main

2023-10-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-layers:fix-publisher-parts-directory into launchpad-layers:main. Commit message: launchpad-publisher-parts: Fix parts directory Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-buildd-manager-authentication-timeout-option into launchpad:master

2023-10-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-buildd-manager-authentication-timeout-option into launchpad:master. Commit message: charm: Allow buildd-manager authentication timeout to be tuned Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-ftpmaster-top-level-directory-index into launchpad:master

2023-10-20 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-ftpmaster-top-level-directory-index into launchpad:master. Commit message: charm: Enable a top-level directory index on ftpmaster-publish Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-ftpmaster-rsync-secrets-permissions into launchpad:master

2023-10-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-ftpmaster-rsync-secrets-permissions into launchpad:master. Commit message: charm: Fix permissions of rsync secrets file Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:bugbear-getattr-setattr into launchpad:master

2023-10-19 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:bugbear-getattr-setattr into launchpad:master. Commit message: Remove useless uses of getattr/setattr Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-fix-tour into launchpad:master

2023-10-17 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-fix-tour into launchpad:master. Commit message: charm: Send +tour requests to appserver, not assets Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2039479 in Launchpad itself: "Broken ‘Tak

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:lazr.restful-2.0.2 into launchpad:master

2023-10-17 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:lazr.restful-2.0.2 into launchpad:master. Commit message: Upgrade to lazr.restful 2.0.2 Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2039251 in Launchpad itself: "Launchpad API randomly re

[Launchpad-reviewers] [Merge] ~cjwatson/lp-source-dependencies:lazr.restful-2.0.2 into lp-source-dependencies:master

2023-10-17 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lp-source-dependencies:lazr.restful-2.0.2 into lp-source-dependencies:master. Commit message: Add lazr.restful 2.0.2 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-scripts-export-queue-verbose into launchpad:master

2023-10-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-scripts-export-queue-verbose into launchpad:master. Commit message: charm: Run rosetta-export-queue with more verbosity Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-loggerhead into launchpad:master

2023-10-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-loggerhead into launchpad:master. Commit message: charm: Add launchpad-loggerhead Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:verifyObject-person-as-registry into launchpad:master

2023-10-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:verifyObject-person-as-registry into launchpad:master. Commit message: Run verifyObject on IPerson as a registry expert Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~cjwatson/turnip:lpci-pre-commit into turnip:master

2023-10-12 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/turnip:lpci-pre-commit into turnip:master. Commit message: Add pre-commit checks via lpci Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/turnip/+git/turnip/+merge/453433

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:makefile-quiet-if-no-git into launchpad:master

2023-10-10 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:makefile-quiet-if-no-git into launchpad:master. Commit message: Quieten Makefile when there's no .git directory Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjw

Re: [Launchpad-reviewers] [Merge] ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-production-riscv64 into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-10-10 Thread Colin Watson
Diff comments: > diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml > index c3b40ce..c601076 100644 > --- a/vbuilder/bundle.yaml > +++ b/vbuilder/bundle.yaml > @@ -38,7 +41,7 @@ > {%- set openstack_username_lcy02 = "launchpad-vbuilder-production" %} > {%- set vbuilders_bos01 = {"amd

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-production-riscv64 into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-10-10 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-production-riscv64 into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder. Commit message: vbuilder: Add bos03-riscv64 on production Requested reviews: Launchpad code reviewers (launchpad-reviewers

[Launchpad-reviewers] [Merge] ~cjwatson/lp-signing:doc-simplify-deployment into lp-signing:master

2023-10-09 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lp-signing:doc-simplify-deployment into lp-signing:master. Commit message: doc: Simplify deployment commands Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp-signing

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-cron-control-redirects into launchpad:master

2023-10-09 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:charm-cron-control-redirects into launchpad:master. Commit message: charm: Redirect old cron-control URLs Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-qastaging-riscv64 into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-10-09 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-qastaging-riscv64 into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder. Commit message: vbuilder: Add bos03-riscv64 on qastaging Requested reviews: Launchpad code reviewers (launchpad-reviewers) For

Re: [Launchpad-reviewers] [Merge] ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-qastaging into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-10-05 Thread Colin Watson
The private repo is because I never managed to quite persuade management to sign off on open-sourcing it. I've sent the thread from a couple of years ago on to Clinton in the hope of reviving it, since it would certainly make life easier in a few ways. Diff comments: > diff --git a/vbuilder/b

Re: [Launchpad-reviewers] [Merge] ~xnox/launchpad:only-sha256 into launchpad:master

2023-10-04 Thread Colin Watson
Making this series-specific shouldn't require any database schema changes. There's already a `DistroSeries.publishing_options` column which we use for a number of other pieces of series-specific behaviour, and that would be the appropriate place to put this as well. -- https://code.launchpad.n

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:stagingsetup-syntax into launchpad:master

2023-10-03 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:stagingsetup-syntax into launchpad:master. Commit message: Fix syntax error in stagingsetup Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:doc-services-build-farm into launchpad:master

2023-10-03 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:doc-services-build-farm into launchpad:master. Commit message: doc: Add high-level build farm documentation Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-qastaging into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

2023-10-03 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-qastaging into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder with ~cjwatson/launchpad-mojo-specs/+git/private:vbuilder-remove-lgw01 as a prerequisite. Commit message: vbuilder: Add qastaging

[Launchpad-reviewers] [Merge] ~cjwatson/lp-signing:charm-update-ols-layers into lp-signing:master

2023-10-02 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lp-signing:charm-update-ols-layers into lp-signing:master. Commit message: charm: Update charm-wheels/ols-layers Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp

[Launchpad-reviewers] [Merge] ~cjwatson/lp-codeimport:charm-update-ols-layers into lp-codeimport:master

2023-10-02 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lp-codeimport:charm-update-ols-layers into lp-codeimport:master. Commit message: charm: Update charm-wheels/ols-layers Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:doc-services-signing into launchpad:master

2023-10-02 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:doc-services-signing into launchpad:master. Commit message: doc: Add high-level signing service documentation Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson

[Launchpad-reviewers] [Merge] ~cjwatson/lp-codeimport:flake8-6.1.0 into lp-codeimport:master

2023-10-02 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/lp-codeimport:flake8-6.1.0 into lp-codeimport:master. Commit message: pre-commit: Update to flake8 6.1.0 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp-codeimport

  1   2   3   4   5   6   7   8   9   10   >