Superseded by cprov's rework of that checkbox.
--
https://code.launchpad.net/~cjohnston/launchpad/fix-word-break/+merge/219285
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
The proposal to merge lp:~cjohnston/launchpad/fix-word-break into lp:launchpad
has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~cjohnston/launchpad/fix-word-break/+merge/219285
--
Chris Johnston has proposed merging lp:~cjohnston/launchpad/fix-word-break into
lp:launchpad.
Commit message:
Fix word-break not working in FF
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
The proposal to merge lp:~cjohnston/launchpad/fix-word-break into lp:launchpad
has been updated.
Commit Message changed to:
Fix word-break not working in FF, add a newline between code and ICs in emails.
For more details, see:
The proposal to merge lp:~cjohnston/launchpad/fix-word-break into lp:launchpad
has been updated.
Description changed to:
- fixes word-break not working in FF
- add a new line between code and ICs in emails
- Remove a few trailing whitespaces
For more details, see:
Review: Approve
Thanks for working on this.
I have only on minor comment about replacing L.insert(0,...) for a append('');
extend(...); append('')
Once that's done we can land it.
Inline comments:
--- lib/lp/app/javascript/inlineedit/assets/skins/sam/editor-skin.css
2014-04-09 19:58:33
The proposal to merge lp:~cjohnston/launchpad/fix-word-break into lp:launchpad
has been updated.
Commit Message changed to:
Fix word-break not working in FF, add a newline between code and ICs in emails,
default publish inline comments True.
For more details, see:
The proposal to merge lp:~cjohnston/launchpad/fix-word-break into lp:launchpad
has been updated.
Description changed to:
- fixes word-break not working in FF
- add a new line between code and ICs in emails
- Remove a few trailing whitespaces
- Set publish inline comments to true by default
For
Celso Providelo has proposed merging lp:~cjohnston/launchpad/fix-word-break
into lp:launchpad.
Requested reviews:
Celso Providelo (cprov)
For more details, see:
https://code.launchpad.net/~cjohnston/launchpad/fix-word-break/+merge/219285
- Set publish inline comments to true by default
--
9 matches
Mail list logo
