Colin Watson has proposed merging lp:~cjwatson/launchpad/germinate-stale-files
into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1001517 in Launchpad itself: generate-extra-overrides can leave stale
files behind in config.germinateroot
Review: Approve code
Looks good.
The with/pass in test_generate_extra_overrides.py (line 877 of the diff)
confused me for a second. I wonder if an old-fashioned open().close()
wouldn't be easier to understand at first blush. Or maybe even a
touch helper function.
--
Maybe I'm weird, but I prefer the with/pass pattern myself; however, a
helper function makes sense, and perhaps can be moved somewhere more
common in future. Done.
--
https://code.launchpad.net/~cjwatson/launchpad/germinate-stale-files/+merge/106626
Your team Launchpad code reviewers is
The proposal to merge lp:~cjwatson/launchpad/germinate-stale-files into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/germinate-stale-files/+merge/106626
--
The proposal to merge lp:~cjwatson/launchpad/germinate-stale-files into
lp:launchpad has been updated.
Commit Message changed to:
Remove stale files from config.germinateroot.
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/germinate-stale-files/+merge/106626
--
The proposal to merge lp:~cjwatson/launchpad/germinate-stale-files into
lp:launchpad has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/germinate-stale-files/+merge/106626
--
6 matches
Mail list logo
