Review: Approve
post landing review - some thoughts: getSubscriptionForPerson seems to overlap
other getSubscription methods quite a bit. One particular thing is that this
seems buggy: I can subscribe my *team* but the edit facility will only let me
edit my *personal* subscription: its a
Graham Binns has proposed merging
lp:~gmb/launchpad/add-update-subscription-workflow-bug-664571 into
lp:launchpad/devel.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers): code
Related bugs:
#664571 Users should have the option to alter a subscription's
BugNotificationLevel
Review: Approve
--
https://code.launchpad.net/~gmb/launchpad/add-update-subscription-workflow-bug-664571/+merge/39966
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~gmb/launchpad/add-update-subscription-workflow-bug-664571 into
lp:launchpad/devel.
The proposal to merge
lp:~gmb/launchpad/add-update-subscription-workflow-bug-664571 into
lp:launchpad/devel has been updated.
Status: Needs review = Approved
--
https://code.launchpad.net/~gmb/launchpad/add-update-subscription-workflow-bug-664571/+merge/39966
Your team Launchpad code
I self-reviewed this as the on-call reviewer was unavailable and no-one was
available on my team to do the review.
--
https://code.launchpad.net/~gmb/launchpad/add-update-subscription-workflow-bug-664571/+merge/39966
Your team Launchpad code reviewers is requested to review the proposed merge of
The proposal to merge
lp:~gmb/launchpad/add-update-subscription-workflow-bug-664571 into
lp:launchpad/devel has been updated.
Status: Approved = Merged
--
https://code.launchpad.net/~gmb/launchpad/add-update-subscription-workflow-bug-664571/+merge/39966
Your team Launchpad code reviewers
6 matches
Mail list logo
