The proposal to merge lp:~wallyworld/launchpad/improve-menu-rendering into
lp:launchpad/devel has been updated.
Status: Approved = Merged
--
https://code.launchpad.net/~wallyworld/launchpad/improve-menu-rendering/+merge/38222
Your team Launchpad code reviewers is requested to review the
Ian Booth has proposed merging lp:~wallyworld/launchpad/improve-menu-rendering
into lp:launchpad/devel.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers): code
Related bugs:
#659171 Menu performance fix - only render required links
https://bugs.launchpad.net/bugs/659171
You probably want to subclass userdict instead of dict, may avoid some
of your boilerplate.
Looks good otherwise.
-Rob
--
https://code.launchpad.net/~wallyworld/launchpad/improve-menu-rendering/+merge/38222
Your team Launchpad code reviewers is requested to review the proposed merge of
You probably want to subclass userdict instead of dict, may avoid some
of your boilerplate.
Looks good otherwise.
-Rob
Thanks for the review.
Actually, I initially used DictMixin and that worked for the pages I looked
at manually but tests failed because there's specific code that calls
Actually, I initially used DictMixin and that worked for the pages I looked
at manually but tests failed because there's specific code that calls
isinstance(dict) and UserDict does not subclass dict. Java is much better is
this regard since there's standard collection interfaces everything
The proposal to merge lp:~wallyworld/launchpad/improve-menu-rendering into
lp:launchpad/devel has been updated.
Status: Needs review = Approved
--
https://code.launchpad.net/~wallyworld/launchpad/improve-menu-rendering/+merge/38222
Your team Launchpad code reviewers is requested to review
6 matches
Mail list logo
