The proposal to merge lp:~bac/launchpad/lep-projconfig into lp:launchpad/devel
has been updated.
Commit Message changed to:
Show project maintainers application configuration links and a progress bar
showing completion status.
--
The proposal to merge lp:~bac/launchpad/lep-projconfig into lp:launchpad/devel
has been updated.
Status: Approved = Merged
--
https://code.launchpad.net/~bac/launchpad/lep-projconfig/+merge/30999
Your team Launchpad code reviewers is requested to review the proposed merge of
Hi Curtis,
Thanks for the review and the excellent suggestions to save me from myself.
Diff at http://pastebin.ubuntu.com/472353/
New screenshot at http://people.canonical.com/~bac/config-progress-bar.png
--
https://code.launchpad.net/~bac/launchpad/lep-projconfig/+merge/30999
Your team
Review: Needs Fixing code
The inline diff is really messed up so I am just looking at the paste.
in lib/lp/registry/templates/pillar-involvement-portlet.pt, I see invalid
markup. A list must contain an li, and it can never contain a table. The ul is
not needed since the table is a block
Sorry I failed to see and strip out that ul.
Diff: http://pastebin.ubuntu.com/472388/
--
https://code.launchpad.net/~bac/launchpad/lep-projconfig/+merge/30999
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~bac/launchpad/lep-projconfig into
Review: Approve code
Looks good to land.
--
https://code.launchpad.net/~bac/launchpad/lep-projconfig/+merge/30999
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~bac/launchpad/lep-projconfig into lp:launchpad/devel.
The proposal to merge lp:~bac/launchpad/lep-projconfig into lp:launchpad/devel
has been updated.
Status: Needs review = Approved
--
https://code.launchpad.net/~bac/launchpad/lep-projconfig/+merge/30999
Your team Launchpad code reviewers is requested to review the proposed merge of
7 matches
Mail list logo
