Review: Needs Information
This seems like a massive layering violation. I really think we should just
issue macaroons with LFA.id caveats directly, even though that loses us the
BuildStatus.BUILDING restriction.
--
Review: Approve code
Diff comments:
>
> === modified file 'lib/lp/services/librarianserver/web.py'
> --- lib/lp/services/librarianserver/web.py2018-01-01 17:40:03 +
> +++ lib/lp/services/librarianserver/web.py2018-04-06 08:39:18 +
> @@ -188,76 +194,109 @@
> return
Review: Approve code
There are probably much worse problems with that script, but indeed.
--
https://code.launchpad.net/~cjwatson/launchpad/close-account-git-subscription/+merge/345237
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
The proposal to merge lp:~cjwatson/launchpad/close-account-git-subscription
into lp:launchpad has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/close-account-git-subscription/+merge/345237
--
Your team Launchpad code
Review: Approve code
Quite.
--
https://code.launchpad.net/~cjwatson/launchpad/spr-faster-time-estimation/+merge/345289
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
The proposal to merge lp:~cjwatson/launchpad/spr-faster-time-estimation into
lp:launchpad has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/spr-faster-time-estimation/+merge/345289
--
Your team Launchpad code reviewers is
I don't understand the principle here. Can you explain why it's any more of a
layering violation for a BPB issuer to grant permission to access its
associated LFAs than it is for a CodeImportJob issuer to grant permission to
access its associated GitRepositories?
In general, my intent in
Colin Watson has proposed merging
lp:~cjwatson/launchpad/spr-faster-time-estimation into lp:launchpad.
Commit message:
Only consider the most recent nine successful builds when estimating recipe
build durations.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Diff comments:
>
> === modified file 'lib/lp/buildmaster/model/buildfarmjobbehaviour.py'
> --- lib/lp/buildmaster/model/buildfarmjobbehaviour.py 2016-10-12 14:02:19
> +
> +++ lib/lp/buildmaster/model/buildfarmjobbehaviour.py 2018-05-02 13:37:24
> +
> @@ -48,11 +49,39 @@
>
The proposal to merge lp:~cjwatson/launchpad/twisted-17.9.0 into lp:launchpad
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/twisted-17.9.0/+merge/342777
--
Your team Launchpad code reviewers is subscribed to branch
Diff comments:
>
> === modified file 'lib/lp/soyuz/model/livefsbuildbehaviour.py'
> --- lib/lp/soyuz/model/livefsbuildbehaviour.py2018-03-01 17:36:31
> +
> +++ lib/lp/soyuz/model/livefsbuildbehaviour.py2018-05-02 13:37:24
> +
> @@ -76,33 +77,26 @@
>
Colin Watson has proposed merging lp:~cjwatson/launchpad/more-comment-footers
into lp:launchpad.
Commit message:
Show spam controls for comments on non-mergeable MPs.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1680746 in Launchpad itself: "No way to
Colin Watson has proposed merging lp:~cjwatson/launchpad/amqp-port into
lp:launchpad.
Commit message:
Upgrade to Python 3-compatible versions of rabbitfixture and oops-amqp.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
Review: Approve code
--
https://code.launchpad.net/~cjwatson/launchpad/build-fast-cleanup/+merge/344958
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
On 09/05/18 23:24, Colin Watson wrote:
> I don't understand the principle here. Can you explain why it's any
> more of a layering violation for a BPB issuer to grant permission to
> access its associated LFAs than it is for a CodeImportJob issuer to
> grant permission to access its associated
I think that sounds fine. It's a bit of a change from where we are today, but
not a huge way off and not clearly in the wrong direction.
--
https://code.launchpad.net/~cjwatson/launchpad/librarian-accept-macaroon/+merge/345079
Your team Launchpad code reviewers is subscribed to branch
Review: Approve code
--
https://code.launchpad.net/~cjwatson/launchpad/more-comment-footers/+merge/345303
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
Review: Approve code
--
https://code.launchpad.net/~cjwatson/launchpad/amqp-port/+merge/345305
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Would it be better if the librarian talked to the authserver for this?
I'd avoided that approach because it seemed like unnecessary complexity,
but it could easily be done asynchronously and it would allow preserving
the fine-grained permissions, which I'd really like to find a way to do.
We could
19 matches
Mail list logo
