Re: [Launchpad-reviewers] [Merge] lp:~twom/launchpad/rework-git-permissions-for-shadowing into lp:launchpad

2018-10-18 Thread Colin Watson
Review: Needs Fixing Diff comments: > > === modified file 'lib/lp/code/interfaces/gitrule.py' > --- lib/lp/code/interfaces/gitrule.py 2018-10-16 15:29:37 + > +++ lib/lp/code/interfaces/gitrule.py 2018-10-18 13:49:45 + > @@ -71,6 +71,16 @@ > > grants = Attribute("The access

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/genericise-cron.publish-ppa into lp:launchpad

2018-10-18 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/genericise-cron.publish-ppa into lp:launchpad. Commit message: Make cron.publish-ppa take distro selection criteria as arguments. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

[Launchpad-reviewers] [Merge] lp:~twom/launchpad/rework-git-permissions-for-shadowing into lp:launchpad

2018-10-18 Thread Tom Wardill
Tom Wardill has proposed merging lp:~twom/launchpad/rework-git-permissions-for-shadowing into lp:launchpad. Commit message: Rework git branch permissions to improve shadowing for multiple grants Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: