Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dpkg-xz-support-619152 into lp:launchpad/devel

2010-11-05 Thread Colin Watson
The blocker is having a new enough version of dpkg in production. The Launchpad servers have now all been upgraded to lucid, which helps. However, it is not sufficient, as lucid has dpkg 1.15.5.6, but xz support was introduced in dpkg 1.15.6. The backport is not trivial, because the compression

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dpkg-xz-support-619152 into lp:launchpad

2011-03-21 Thread Colin Watson
https://rt.admin.canonical.com/Ticket/Display.html?id=44684 -- https://code.launchpad.net/~cjwatson/launchpad/dpkg-xz-support-619152/+merge/32868 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/dpkg-xz-support-619152 into lp:launchpad.

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dpkg-xz-support-619152 into lp:launchpad

2011-03-25 Thread Colin Watson
We now have a suitable version of dpkg in production, thanks to LaMont. Can somebody please help me land this? -- https://code.launchpad.net/~cjwatson/launchpad/dpkg-xz-support-619152/+merge/32868 Your team Launchpad code reviewers is requested to review the proposed merge of

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dpkg-xz-support-619152 into lp:launchpad

2011-03-25 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/dpkg-xz-support-619152 into lp:launchpad has been updated. Commit Message changed to: Add support for data.tar.xz .deb members. For more details, see: https://code.launchpad.net/~cjwatson/launchpad/dpkg-xz-support-619152/+merge/32868 --

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dpkg-xz-support-619152 into lp:launchpad

2011-07-04 Thread Colin Watson
Sergey, the changelog in oneiric is not directly relevant to this: what needs to happen is a backport to lucid. I've asked Michael to put it through the SRU process. -- https://code.launchpad.net/~cjwatson/launchpad/dpkg-xz-support-619152/+merge/32868 Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/multiarch-translations into lp:launchpad/db-devel

2011-07-11 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/multiarch-translations into lp:launchpad/db-devel has been updated. Commit Message changed to: Set LongDescription true in apt.conf for series that want it. For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/multiarch-translations into lp:launchpad/db-devel

2011-07-11 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/multiarch-translations into lp:launchpad/db-devel has been updated. Description changed to: I'm seeking review to merge this branch into db-devel. Summary: https://blueprints.launchpad.net/ubuntu/+spec/foundations-o-multiarch-next-steps requires

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/multiarch-translations into lp:launchpad/db-devel

2011-07-12 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/multiarch-translations into lp:launchpad/db-devel has been updated. Description changed to: I'm seeking review to merge this branch into db-devel. Summary: https://blueprints.launchpad.net/ubuntu/+spec/foundations-o-multiarch-next-steps requires

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dpkg-xz-support-619152 into lp:launchpad

2011-07-13 Thread Colin Watson
I made a few more fixes to my branch (though the branch scanner isn't picking them up for some reason; https://answers.launchpad.net/launchpad/+question/164657), and have verified that the archiveuploader tests pass with the versions of apt-utils and python-apt now in lucid-proposed. Once

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/germinate-ubuntustudio into lp:launchpad

2011-07-19 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/germinate-ubuntustudio into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #562706 in Launchpad itself: On i386, selecting the ubuntu studio packages fails to install https

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/germinate-ubuntustudio into lp:launchpad

2011-07-19 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/germinate-ubuntustudio into lp:launchpad has been updated. Commit Message changed to: Add Ubuntu Studio to cron.germinate. For more details, see: https://code.launchpad.net/~cjwatson/launchpad/germinate-ubuntustudio/+merge/68404 --

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dpkg-xz-support-619152 into lp:launchpad

2011-07-29 Thread Colin Watson
It should be possible to land this branch now. I'd welcome somebody with appropriate permissions doing so. -- https://code.launchpad.net/~cjwatson/launchpad/dpkg-xz-support-619152/+merge/32868 Your team Launchpad code reviewers is requested to review the proposed merge of

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/fix-target-detection into lp:meta-lp-deps

2011-08-17 Thread Colin Watson
I did double-check that the version variable wasn't being used anywhere else, yes. -- https://code.launchpad.net/~cjwatson/meta-lp-deps/fix-target-detection/+merge/71840 Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps. ___

[Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/fix-target-detection-harder into lp:meta-lp-deps

2011-08-19 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/meta-lp-deps/fix-target-detection-harder into lp:meta-lp-deps. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/meta-lp-deps/fix-target-detection-harder/+merge/72166 My

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-archive-cruft-check into lp:launchpad

2011-09-29 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-archive-cruft-check into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/remove-archive-cruft-check/+merge/77524 Remove

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/germinate-armhf into lp:launchpad

2011-10-14 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/germinate-armhf into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #874298 in Launchpad itself: cron.germinate needs to be fixed to examine the armhf architecture https

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad

2011-12-06 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #899972 in Launchpad itself: cron.germinate is very slow https://bugs.launchpad.net/launchpad/+bug/899972

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad

2011-12-06 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad has been updated. Commit Message changed to: Reimplement most of cron.germinate in Python using the new python-germinate package. This no longer needs to recompute the dependency expansion of common seeds

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad

2011-12-06 Thread Colin Watson
Right. I've tracked down all the problems I could find and released germinate 2.1 to fix all of them; none of them were problems with this branch. The runtime is now down to about 4m50s on mawson; the only differences in output are (a) in places where it doesn't matter very much and (b)

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad

2011-12-07 Thread Colin Watson
I think you're right that the file shouldn't be put in place if the context exits with an exception. If I were writing this without context managers, then rather than: with AtomicFile('foo') as handle: print handle, 'bar' ... I'd probably write: handle = open('foo.new', 'w')

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad

2011-12-07 Thread Colin Watson
On Wed, Dec 07, 2011 at 07:20:29AM -, Jeroen T. Vermeulen wrote: The part from “series = None” onward seems to be an isolated unit of work. I think it looks for the first distroseries in development state, or failing that, the first in frozen state. But the structure of the code makes

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad

2011-12-07 Thread Colin Watson
[I've not responded to your entire review point-by-point, but I believe I've addressed all points where I haven't given an explicit response.] On Wed, Dec 07, 2011 at 09:22:24AM -, Jeroen T. Vermeulen wrote: +def runGerminate(self, override_file, series_name, arch, flavours, +

[Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/python-germinate into lp:meta-lp-deps

2011-12-07 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/meta-lp-deps/python-germinate into lp:meta-lp-deps. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #899972 in Launchpad itself: cron.germinate is very slow https://bugs.launchpad.net/launchpad/+bug/899972

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-archive-integrity-check into lp:launchpad

2011-12-13 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-archive-integrity-check into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #125016 in Launchpad itself: Port ftpmaster-tools/archive-integrity-check.py to use LP standards

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/always-index-d-i into lp:launchpad

2011-12-14 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/always-index-d-i into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #118227 in Launchpad itself: main/debian-installer missing from Release files https://bugs.launchpad.net

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/sign-installer into lp:launchpad

2011-12-14 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/sign-installer into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #383044 in Launchpad itself: No GPG signatures for nonstandard installers https://bugs.launchpad.net/launchpad

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/python-germinate into lp:meta-lp-deps

2011-12-15 Thread Colin Watson
On Thu, Dec 15, 2011 at 10:25:26PM -, j.c.sackett wrote: Taking a quick look at this, I see that lp:~cjwatson/launchpad/refactor-cron-germinate has been merged with lp:launchpad, but this has not been landed. I would have assumed that buildbot would have chocked if this was required. I

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/soyuz-test-mail-ordering into lp:launchpad

2011-12-15 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/soyuz-test-mail-ordering into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #904220 in Launchpad itself: Soyuz tests with lists of e-mail addresses are non-deterministic https

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/soyuz-test-mail-ordering into lp:launchpad

2011-12-15 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/soyuz-test-mail-ordering into lp:launchpad has been updated. Description changed to: = Summary = Fix a couple of test failures on i386 due to relying on the iteration order of sets. == Proposed fix == Introduce an

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/weaken-xz-dpkg-requirement into lp:launchpad

2011-12-16 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/weaken-xz-dpkg-requirement into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #905322 in Launchpad itself: Lower required dpkg version for xz-compressed packages https

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/background-scandium into lp:launchpad

2011-12-16 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/background-scandium into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #905333 in Launchpad itself: Ubuntu publisher should trigger scandium in the background https

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/python-germinate into lp:meta-lp-deps

2011-12-23 Thread Colin Watson
On Fri, Dec 23, 2011 at 11:02:25AM -, Gavin Panella wrote: Do you want germinate 2.3 from your PPA into the LP PPA? 2.1 has already been copied. Yes please. It'll be needed for later work (https://code.launchpad.net/~cjwatson/launchpad/germinate-from-db, work in progress). -- Colin

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/python-germinate into lp:meta-lp-deps

2011-12-24 Thread Colin Watson
My memory is that merging this into trunk triggers recipe builds. -- https://code.launchpad.net/~cjwatson/meta-lp-deps/python-germinate/+merge/84763 Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps. ___ Mailing list:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/germinate-all-dev-series into lp:launchpad

2011-12-26 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/germinate-all-dev-series into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #904538 in Launchpad itself: generate-extra-overrides is confused by multiple DEVELOPMENT/FROZEN

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/germinate-all-dev-series into lp:launchpad

2011-12-26 Thread Colin Watson
Would it be better to just go back to having multiple lists and iterating over them with zip() (my personal threshold for when I start thinking about consolidating this kind of thing into a list of classes seems to be about three, which is why I did it at this point), or is it worth caching the

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/stop-publishing-obsolete-series into lp:launchpad

2011-12-27 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/stop-publishing-obsolete-series into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #905281 in Launchpad itself: Publisher spends time considering series that can't possibly

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/stop-publishing-obsolete-series into lp:launchpad

2011-12-27 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/stop-publishing-obsolete-series into lp:launchpad has been updated. Commit Message changed to: Skip publishing OBSOLETE and FUTURE series in PRIMARY and PARTNER archives. For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/gina-dsc-binaries into lp:launchpad

2012-01-05 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/gina-dsc-binaries into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #911943 in Launchpad itself: gina imports SourcePackageRelease.dsc_binaries incorrectly https

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/typos into lp:launchpad

2012-01-06 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/typos into lp:launchpad has been updated. Commit Message changed to: Fix a slew of typos. For more details, see: https://code.launchpad.net/~cjwatson/launchpad/typos/+merge/87726 -- https://code.launchpad.net/~cjwatson/launchpad/typos/+merge/87726

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/gina-dsc-binaries into lp:launchpad

2012-01-06 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/gina-dsc-binaries into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #911943 in Launchpad itself: gina imports SourcePackageRelease.dsc_binaries incorrectly https

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archive-copy-packages-source-series into lp:launchpad

2012-01-09 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/archive-copy-packages-source-series into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #913722 in Launchpad itself: Archive.copyPackages doesn't allow specifying a source series

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/precise-lts-flavours into lp:launchpad

2012-01-09 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/precise-lts-flavours into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #914055 in Launchpad itself: Add Kubuntu, Edubuntu, and Xubuntu LTS Supported fields for Precise https

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archive-copy-packages-source-series into lp:launchpad

2012-01-10 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/archive-copy-packages-source-series into lp:launchpad has been updated. Commit Message changed to: Add an optional from_series parameter to Archive.copyPackages and Archive.syncSources. For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/precise-lts-flavours into lp:launchpad

2012-01-10 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/precise-lts-flavours into lp:launchpad has been updated. Commit Message changed to: Support Kubuntu and Edubuntu 12.04 for five years, and Xubuntu for three years. For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-exclude-pocket into lp:launchpad

2012-01-10 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-exclude-pocket into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/remove-exclude-pocket/+merge/88030 == Summary

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-spr-dsc-binaries-updater into lp:launchpad

2012-01-13 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-spr-dsc-binaries-updater into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/remove-spr-dsc-binaries-updater/+merge/88528

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-spr-dsc-binaries-updater into lp:launchpad

2012-01-13 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/remove-spr-dsc-binaries-updater into lp:launchpad has been updated. Commit Message changed to: Remove completed SourcePackageReleaseDscBinariesUpdater garbo job. For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/precise-lts-flavours into lp:launchpad

2012-01-17 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/precise-lts-flavours into lp:launchpad has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~cjwatson/launchpad/precise-lts-flavours/+merge/88009 --

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/contributions-linkify-bugs into lp:launchpad

2012-01-20 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/contributions-linkify-bugs into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/contributions-linkify-bugs/+merge/89403 I often look

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/contributions-linkify-bugs into lp:launchpad

2012-01-20 Thread Colin Watson
Review: Needs Fixing ... except {{{ }}} ignores markup, and all the workarounds wgrant and I have tried are painful in some way. Let's just shelve this for now. -- https://code.launchpad.net/~cjwatson/launchpad/contributions-linkify-bugs/+merge/89403 Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/kill-old-switchdbuser into lp:launchpad

2012-01-20 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/kill-old-switchdbuser into lp:launchpad has been updated. Commit Message changed to: Migrate everything to the functions in lp.testing.dbuser, and kill off the old LaunchpadZopelessLayer.switchDbUser method. For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/more-extra-override-filenames into lp:launchpad

2012-03-27 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/more-extra-override-filenames into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #966092 in Launchpad itself: more-extra.override.* generation doesn't match use https

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-archive-override-check into lp:launchpad

2012-03-27 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-archive-override-check into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/remove-archive-override-check/+merge/99514 archive

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/kill-sqlbase-commit into lp:launchpad

2012-03-27 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/kill-sqlbase-commit into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/kill-sqlbase-commit/+merge/99526 sqlbase.commit has been

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/publish-proposed into lp:launchpad

2012-04-05 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/publish-proposed into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #974328 in Launchpad itself: pre-release uploads to -proposed are accepted but cannot be published https

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/api-build-builder into lp:launchpad

2012-04-06 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/api-build-builder into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #975579 in Launchpad itself: Build API does not export builder https://bugs.launchpad.net/launchpad/+bug/975579

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad

2012-04-07 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/remove-query-distro-pending-suites/+merge

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad

2012-04-07 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad has been updated. Description changed to: == Summary == The pending_suites action in the lp-query-distro.py script (and the LpQueryDistro script class) made sense when the ftpmaster publisher

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad

2012-04-07 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad has been updated. Description changed to: == Summary == The pending_suites action in the lp-query-distro.py script (and the LpQueryDistro script class) made sense when the ftpmaster publisher

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad

2012-04-07 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad has been updated. Commit Message changed to: Remove now-pointless indirection through LpQueryDistro pending_suites, and remove several other obsolete actions. For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-services-unicode-csv into lp:launchpad

2012-04-09 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-services-unicode-csv into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/remove-services-unicode-csv/+merge/101315

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad

2012-04-16 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #983165 in Launchpad itself: ForbiddenAttribute: ('d', BinaryPackagePublishingHistory

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pyflakes-cleanups into lp:launchpad

2012-04-16 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/pyflakes-cleanups into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/pyflakes-cleanups/+merge/102202 == Summary == This branch

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pyflakes-cleanups into lp:launchpad

2012-04-16 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/pyflakes-cleanups into lp:launchpad has been updated. Commit Message changed to: Clean up a slew of pyflakes warnings. For more details, see: https://code.launchpad.net/~cjwatson/launchpad/pyflakes-cleanups/+merge/102202 --

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/init-packageset-fixes into lp:launchpad

2012-04-22 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/init-packageset-fixes into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #887185 in Launchpad itself: ArchivePermission allows duplicated rows https://bugs.launchpad.net/launchpad

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/init-packageset-fixes into lp:launchpad

2012-04-22 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/init-packageset-fixes into lp:launchpad has been updated. Commit Message changed to: Fix InitializeDistroSeries._copy_packagesets to copy from only the most recent series, not merge packagesets from all series. For more details, see:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/init-packageset-fixes into lp:launchpad

2012-04-22 Thread Colin Watson
Oh, incidentally, I don't think this entirely closes this bug, as we need to check for existing busted data and do something about it if any, so this is probably [incr]. I'm willing to work on the rest, although probably not immediately. --

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archive-permission-sampledata into lp:launchpad

2012-04-24 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/archive-permission-sampledata into lp:launchpad. Requested reviews: William Grant (wgrant): code Related bugs: Bug #887185 in Launchpad itself: ArchivePermission allows duplicated rows https://bugs.launchpad.net/launchpad/+bug/887185

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archive-permission-sampledata into lp:launchpad

2012-04-24 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/archive-permission-sampledata into lp:launchpad has been updated. Commit Message changed to: Remove duplicated ArchivePermission rows from sampledata. For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-old-fakelibrarian into lp:launchpad

2012-04-26 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-old-fakelibrarian into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/remove-old-fakelibrarian/+merge/103651 All former users

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-old-fakelibrarian into lp:launchpad

2012-04-26 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/remove-old-fakelibrarian into lp:launchpad has been updated. Commit Message changed to: Remove old lp.testing.fakelibrarian, which is no longer used. For more details, see:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-data-tar-xz-version-requirement into lp:launchpad

2012-04-27 Thread Colin Watson
On Fri, Apr 27, 2012 at 02:05:21PM -, Brad Crittenden wrote: In the test you restored, test_verifyFormat_xz_good_predep, is it still necessary to have the 'Pre-Depends' in the control in order for the upload to be accepted? Perhaps you can keep the test, though rename it, and remove the

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/db-packageset-score into lp:launchpad/db-devel

2012-05-08 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/db-packageset-score into lp:launchpad/db-devel. Requested reviews: Stuart Bishop (stub): db Robert Collins (lifeless): db Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #990219 in Launchpad itself: Reprioritize

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/db-packageset-score into lp:launchpad/db-devel

2012-05-09 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/db-packageset-score into lp:launchpad/db-devel has been updated. Commit Message changed to: Add Packageset.score column. For more details, see: https://code.launchpad.net/~cjwatson/launchpad/db-packageset-score/+merge/105113 --

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/packageset-score into lp:launchpad

2012-05-15 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/packageset-score into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #990219 in Launchpad itself: Reprioritize package build scores based on packageset https://bugs.launchpad.net

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/packageset-score into lp:launchpad

2012-05-15 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/packageset-score into lp:launchpad has been updated. Commit Message changed to: Allow members of launchpad-buildd-admins to set a build score bonus for a package set. For more details, see:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/packageset-score into lp:launchpad

2012-05-16 Thread Colin Watson
Thanks for your review and suggestions. I believe I've implemented all of these now, along with some further changes to speed up the webservice tests. If you're happy with this, could you set the MP status to Approved and then I can land it? (I can't do that myself as I'm not in ~launchpad.)

[Launchpad-reviewers] [Merge] lp:~cjwatson/lp-dev-utils/loc-delta into lp:lp-dev-utils

2012-05-16 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/lp-dev-utils/loc-delta into lp:lp-dev-utils. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/lp-dev-utils/loc-delta/+merge/106080 Add a loc-delta script to report

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/packageset-score into lp:launchpad

2012-05-17 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/packageset-score into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #990219 in Launchpad itself: Reprioritize package build scores based on packageset https://bugs.launchpad.net

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/packageset-score into lp:launchpad

2012-05-17 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/packageset-score into lp:launchpad has been updated. Commit Message changed to: Rename Packageset.score to Packageset.relative_build_score in code. For more details, see: https://code.launchpad.net/~cjwatson/launchpad/packageset-score/+merge/106220

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/packageset-score into lp:launchpad

2012-05-18 Thread Colin Watson
The property name (aside from the DB column name) is now fixed courtesy of a later merge from this branch. -- https://code.launchpad.net/~cjwatson/launchpad/packageset-score/+merge/105915 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/germinate-stale-files into lp:launchpad

2012-05-21 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/germinate-stale-files into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1001517 in Launchpad itself: generate-extra-overrides can leave stale files behind in config.germinateroot

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/germinate-stale-files into lp:launchpad

2012-05-21 Thread Colin Watson
Maybe I'm weird, but I prefer the with/pass pattern myself; however, a helper function makes sense, and perhaps can be moved somewhere more common in future. Done. -- https://code.launchpad.net/~cjwatson/launchpad/germinate-stale-files/+merge/106626 Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/germinate-stale-files into lp:launchpad

2012-05-21 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/germinate-stale-files into lp:launchpad has been updated. Commit Message changed to: Remove stale files from config.germinateroot. For more details, see: https://code.launchpad.net/~cjwatson/launchpad/germinate-stale-files/+merge/106626 --

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archive-build-score-api into lp:launchpad

2012-05-22 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/archive-build-score-api into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1002387 in Launchpad itself: buildd admins should be able to adjust Archive.relative_build_score https

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archive-build-score-api into lp:launchpad

2012-05-22 Thread Colin Watson
It's fine for buildd-admins, since we're all steeped in this stuff all the time. I have no idea whether commercial-admins find it intelligible. The Builds with a higher score will build sooner bit was added in r12134.2.1, and personally I'd be inclined to say that it addresses Jono's bug. --

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archive-build-score-api into lp:launchpad

2012-05-22 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/archive-build-score-api into lp:launchpad has been updated. Commit Message changed to: Allow launchpad-buildd-admins to set Archive.relative_build_score using the webservice. For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-distro-parts into lp:launchpad

2012-05-22 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-distro-parts into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1002589 in Launchpad itself: Deploy new Ubuntu archive signing key https://bugs.launchpad.net/launchpad/+bug

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-distro-parts into lp:launchpad

2012-05-22 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/remove-distro-parts into lp:launchpad has been updated. Commit Message changed to: Remove cronscripts/publishing/distro-parts/ubuntu and support for in-tree distro-parts scripts. This is now maintained as lp:ubuntu-archive-publishing for Ubuntu,

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/update-run-parts-location-config into lp:launchpad

2012-05-23 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/update-run-parts-location-config into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/update-run-parts-location-config/+merge/107084

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-daily-installers into lp:launchpad

2012-05-23 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-daily-installers into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #827965 in Launchpad itself: Ditch daily installers https://bugs.launchpad.net/launchpad/+bug/827965

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-daily-installers into lp:launchpad

2012-05-23 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/remove-daily-installers into lp:launchpad has been updated. Description changed to: == Summary == As Jeroen and I established in the IRC discussion cited in bug 827965, the support for automatic daily uploads of debian-installer is not used and in

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-daily-installers into lp:launchpad

2012-05-23 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/remove-daily-installers into lp:launchpad has been updated. Description changed to: == Summary == As Jeroen and I established in the IRC discussion cited in bug 827965, the support for automatic daily uploads of debian-installer is not used and in

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-daily-installers into lp:launchpad

2012-05-24 Thread Colin Watson
Yeah, I was a little surprised to find nothing else, but .0. is a bit hard to grep for; I did grep for daily-installer and installer.*\.0\. and found nothing. -- https://code.launchpad.net/~cjwatson/launchpad/remove-daily-installers/+merge/107136 Your team Launchpad code reviewers is subscribed

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/custom-upload-parsing into lp:launchpad

2012-05-28 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/custom-upload-parsing into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #827973 in Launchpad itself: Unify custom-upload filename parsing and handling https://bugs.launchpad.net

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/custom-upload-parsing into lp:launchpad

2012-05-28 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/custom-upload-parsing into lp:launchpad has been updated. Description changed to: == Summary == In bug 827973, Jeroen noted that the custom uploads copier has code that is rather similar to the filename parsing in custom upload implementations, and

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/queue-api-accept-reject into lp:launchpad

2012-05-29 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/queue-api-accept-reject into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1006173 in Launchpad itself: Replace queue tool with API https://bugs.launchpad.net/launchpad/+bug

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/custom-upload-parsing into lp:launchpad

2012-05-30 Thread Colin Watson
I've made the classmethod change, thanks. I prefer to keep setTargetDirectory separate, though, in order that all processing failures happen during process() rather than some of them happening during the constructor instead; this makes more sense to me, and it makes it easier to consolidate

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pas-arm into lp:launchpad

2012-05-30 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/pas-arm into lp:launchpad has been updated. Description changed to: == Summary == Bug 917708 reports that the any-arm wildcard is not recognised in packages' Architecture fields. == Proposed fix == Use dpkg-architecture to match architecture

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/queue-api-accept-reject into lp:launchpad

2012-05-30 Thread Colin Watson
The proposal to merge lp:~cjwatson/launchpad/queue-api-accept-reject into lp:launchpad has been updated. Description changed to: == Summary == This is a small first step towards fixing bug 1006173, to provide an API sufficient to replace scripts/ftpmaster-tools/queue. Most of the rest of the

  1   2   3   4   5   6   7   8   9   10   >