[Launchpad-reviewers] [Merge] lp:~roadmr/canonical-mojo-specs/lp-snap-proxy-novaclient-v2 into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk

The proposal to merge lp:~roadmr/canonical-mojo-specs/lp-snap-proxy-novaclient-v2 into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk has been updated. Status: Needs review => Work in progress For more details, see:

Re: [Launchpad-reviewers] [Merge] lp:~roadmr/canonical-mojo-specs/lp-snap-proxy-novaclient-v2 into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk

Found a problem with these imports, will fix in a bit. Don't merge yet! -- https://code.launchpad.net/~roadmr/canonical-mojo-specs/lp-snap-proxy-novaclient-v2/+merge/318412 Your team Launchpad code reviewers is subscribed to branch lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.

[Launchpad-reviewers] [Merge] lp:~roadmr/canonical-mojo-specs/lp-snap-proxy-novaclient-v2 into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk

Daniel Manrique has proposed merging lp:~roadmr/canonical-mojo-specs/lp-snap-proxy-novaclient-v2 into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk. Commit message: Try novaclient v2 and fall back to v1_1 if not present. Should solve CI problems when the Mojo host uses Xenial

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad-buildd/fix-core-snap-installation into lp:launchpad-buildd

Review: Approve LGTM, the code changes are quite simple and consistent with the changelog description. I checked that the lxc.cap.drop syntax is good and they match capabilities listed in the man page. My only question is - why not put udev in the same loop that checks for availability of

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-private-code-import into lp:launchpad

Review: Abstain LGTM, thanks! I'm not a Launchpad code reviewer and I don't know this codebase well enough, so I'll abstain, but this makes sense. -- https://code.launchpad.net/~cjwatson/launchpad/git-private-code-import/+merge/353874 Your team Launchpad code reviewers is requested to review

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-max-retries into lp:launchpad

Review: Approve LGTM. The store's timeout is tunable so we can make that lower easily but for now 18 minutes seems to be what we need. Setting this value to 30 should result in about 27:30 minutes of retries from Launchpad (up from the previous 17:30 which was uncomfortably close to the

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/celery-disable-pickle into lp:launchpad

Review: Approve @roadmr cjwatson: lgtm but one question - why the json serializer and not yaml? I know johan/maxi picked yaml over json for sca for $REASONS @roadmr (I think yaml could serialize some things that json couldn't or somesuch) cjwatson roadmr: LP doesn't really need anything

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/close-account-dry-run into lp:launchpad

Review: Approve LGTM, even if unfamiliar with Launchpad code itself, this seems pretty straightforward. -- https://code.launchpad.net/~cjwatson/launchpad/close-account-dry-run/+merge/366853 Your team Launchpad code reviewers is requested to review the proposed merge of

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad-buildd/ols-vms into lp:launchpad-buildd

Review: Approve Looks OK -- https://code.launchpad.net/~cjwatson/launchpad-buildd/ols-vms/+merge/370831 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad-buildd/ols-vms into lp:launchpad-buildd.