Thiago F. Pappacena has proposed merging
~pappacena/launchpad:message-fix-for-package-filter into launchpad:master.
Commit message:
Small fix for "No matching package for ''." message on PPAs with no packages
Requested reviews:
Launchpad code reviewers (launchpad-rev
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:autorestart-for-librarian into launchpad:master.
Commit message:
Automatically restart web server when file changes are detected
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Do we have automated tests to check the output of the templates?
--
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/377006
Your team Launchpad code reviewers is requested to review the proposed merge of
~pappacena/launchpad:message-fix-for-package-filter into launchpad:maste
The proposal to merge ~pappacena/launchpad:autorestart-for-librarian into
launchpad:master has been updated.
Description changed to:
I was testing somethings on Zope templates, and it was kind of a pain to
manually restart the server every time. So, I've created this small script to
detect fil
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:pending-builds-msg-fix into launchpad:master.
Commit message:
Fixing singular message "A recent upload has resulted in 1 pending builds."
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related b
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:oops-report-test-errors into launchpad:master.
Commit message:
Fixing test errors when accessing person's name for OOPS reports
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
The proposal to merge ~pappacena/launchpad:test-fix-no-pkg-filter into
launchpad:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/377191
--
Your team Launchpad code reviewers is req
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:test-fix-no-pkg-filter into launchpad:master.
Commit message:
Fixing broken test that expects wrong error message when no filter is filled on
package search page.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:test-fix-no-pkg-filter into launchpad:master.
Commit message:
Fixing broken test that expects wrong error message when no filter is filled on
package search page.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers
LGTM
--
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/376998
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:zope-upgrades into launchpad:master.
___
Mailing list: https://launc
LGTM
--
https://code.launchpad.net/~cjwatson/lp-source-dependencies/+git/lp-source-dependencies/+merge/376997
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/lp-source-dependencies:zope-upgrades into
lp-source-dependencies:master.
__
Review: Approve
--
https://code.launchpad.net/~cjwatson/lp-source-dependencies/+git/lp-source-dependencies/+merge/376997
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/lp-source-dependencies:zope-upgrades into
lp-source-dependencies:master.
_
Review: Approve
--
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/376998
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:zope-upgrades into launchpad:master.
___
Mailing list:
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:bugtrackercompo-matching-interface into launchpad:master.
Commit message:
Renaming sourcepackagename attribute on IBugTrackerComponent to match naming
conventions (and to make BugTrackerComponent.source_package_name match the
The proposal to merge ~pappacena/launchpad:bugtrackercompo-matching-interface
into launchpad:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/377194
--
Your team Launchpad code revi
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:bugtrackercompo-matching-interface into launchpad:master.
Commit message:
Renaming source_package_name attribute on BugTrackerComponent to match
interface's naming.
Requested reviews:
Launchpad code reviewers (launchpad-revi
The proposal to merge ~pappacena/launchpad:bugtrackercompo-matching-interface
into launchpad:master has been updated.
Description changed to:
Used pycharm renaming tool, and it didn't find any other usage of this
attribute. The lp.bugs* seems to be running fine too.
For more details, see:
http
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:macaroon-secret-key-cfg-explanation into launchpad:master.
Commit message:
- Adding a comment to help configure macaroon secret key for development
- Adding config section to run diff processing job
Requested reviews:
Launchpad
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:process-job-respecting-config-section into
launchpad:master.
Commit message:
Adding the option for process-job-source to link a script configuration to
another section, in order to avoid duplicating config
Requested reviews
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:fix-encoding-css-combine into launchpad:master.
Commit message:
Fix for encoding problem when combining CSS files with non-ascii chars
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Diff comments:
> diff --git a/lib/lp/scripts/utilities/js/combinecss.py
> b/lib/lp/scripts/utilities/js/combinecss.py
> index 1aa1072..1bb94c2 100755
> --- a/lib/lp/scripts/utilities/js/combinecss.py
> +++ b/lib/lp/scripts/utilities/js/combinecss.py
> @@ -75,9 +75,9 @@ def main():
>
> c
LGTM
--
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377339
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:combinecss-bytes into launchpad:master.
___
Mailing list: https://la
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:gitrepo-pending-merges-tuning into launchpad:master.
Commit message:
Small improvements in performance and allowing to limit the amount of MPs
displayed on repository-pending-merges portlet (on git repository page)
Requested reviews
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:db-patch-archive-queue-audit-trail into launchpad:db-devel.
Commit message:
Creation of database table for PackageUploadLog
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #885739 in Launchpad
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:archive-queue-audit-trail into launchpad:master.
Commit message:
Creating audit logs for package approval and rejection
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #885739 in Launchpad
The proposal to merge ~pappacena/launchpad:pkg-upload-log-api into
launchpad:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/377897
--
Your team Launchpad code reviewers is request
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:pkg-upload-log-api into launchpad:master.
Commit message:
API for Package Upload logs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git
This is still a work in progress, since I want to check if it would be possible
to refactor some of the pre-fetching to happen only on PackageUploadSet,
instead of beign kind of duplicated in the browser.queue.QueueItemsView.
--
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+mer
QueueItemsView is caching some extra attributes that are not beign cached on
PackageUploadSet, but there was room for a small improvement anyway.
This should be ok to be reviewed, but should only be merged once the other MP
is approved.
Diff comments:
> diff --git a/lib/lp/soyuz/browser/queue.
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:pkg-upload-log-api into launchpad:master.
Commit message:
API for Package Upload logs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:storm_select_related into launchpad:master.
Commit message:
[DONT MERGE] Adding an easy way to select related objects on Storm (discussion
only)
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:pkg-upload-log-api into launchpad:master with
~pappacena/launchpad:archive-queue-audit-trail as a prerequisite.
Commit message:
API for Package Upload logs
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For
It's still a work in progress, but I would like some feedbacks about the
database structure, just to make sure I'm not missing anything.
--
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/378364
Your team Launchpad code reviewers is requested to review the proposed merge of
cjwatson, I'll move things to lp.service.signing and split the database model
to allow multiple archives/series to use the same key. But I've added a
question about the behavior of "minimum series using this key" bellow.
Thanks for pointing out the "responses" module. Never used it before, and i
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:pgk-upload-log-positioning into launchpad:master.
Commit message:
Use different padding depending on how many columns we have on package upload
queue
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
Diff comments:
> diff --git a/lib/lp/soyuz/templates/distroseries-queue.pt
> b/lib/lp/soyuz/templates/distroseries-queue.pt
> index 39629ce..3850174 100644
> --- a/lib/lp/soyuz/templates/distroseries-queue.pt
> +++ b/lib/lp/soyuz/templates/distroseries-queue.pt
> @@ -147,10 +147,14 @@
>
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:lp-signing-integration into launchpad:master.
Commit message:
[HOLD! DON'T MERGE] Integrating LP to lp-signing service
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
I'm sorry this got a bit too big. Let me give a brief explanation of the
changes here:
- Renaming of current (I)ArchiveSigningKey to (I)ArchiveGPGSigningKey to avoid
confusion (this increased a bit the MP size, but no logic was changed regarding
this part; only renaming the classes);
- On lp.s
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:renaming-archive-signing-key into launchpad:master.
Commit message:
Renaming (I)ArchiveSigningKey to (I)ArchiveGPGSigningKey
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Thiago F. Pappacena has proposed merging
~pappacena/lp-source-dependencies:remove-auditor into
lp-source-dependencies:master.
Commit message:
Removing auditor dependencies
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Thiago F. Pappacena has proposed merging ~pappacena/launchpad:remove-auditor
into launchpad:master.
Commit message:
Removing auditor
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:db-patch-lp-signing-integration into launchpad:db-devel.
Commit message:
Database patch for signing service integration tables.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
I have a question about the prober: what should we do about mirrors using
"invalid" certificates? Should we consider them or not?
I'm asking because I was thinking to mark those as not healthy, but the HTTPS
version of releases.ubuntu.com and nl.archive.ubuntu.com, for example, both use
a certi
Another topic is proxy: the current HTTP prober supports proxy (configured at
config.launchpad.http_proxy). Is there any reason for us to support this type
of proxy for HTTPS?
--
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/379387
Your team Launchpad code reviewers is re
I think it's in a good state for a review now, cjwatson. It's including:
- Brody's work to add the new fields
- The changes on prober to deal with HTTPS (using treq), including proxy (using
ProxyAgent) and dealing with invalid certificates (both generic SSL errors and
validation errors, like DNS
The proposal to merge ~pappacena/launchpad:https-mirrors into launchpad:master
has been updated.
Commit message changed to:
Allowing to register HTTPS mirrors (both for CD images and archives).
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/379387
-
Thiago F. Pappacena has proposed merging ~pappacena/launchpad:https-mirrors
into launchpad:master.
Commit message:
Allowing to register HTTPS mirrors (both for CD images and archives).
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1255120 in Launchpad
MP for the database patch:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/379504
--
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/379387
Your team Launchpad code reviewers is requested to review the proposed merge of
~pappacena/launchpad:https-mirro
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:db-patch-https-mirrors into launchpad:db-devel.
Commit message:
Database patch to support HTTPS mirrors
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pappacena
Renamed db patch version to the pre-allocated number 2210-03-0.
Diff comments:
> diff --git a/database/schema/patch-2210-13-0.sql
> b/database/schema/patch-2210-13-0.sql
> new file mode 100644
> index 000..dada0ec
> --- /dev/null
> +++ b/database/schema/patch-2210-13-0.sql
> @@ -0,0 +1,15 @@
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:revert-https-mirrors into launchpad:master.
Commit message:
Reverting https-mirrors branch until we land the database patch.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
The proposal to merge ~pappacena/launchpad:revert-https-mirrors into
launchpad:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/379909
--
Your team Launchpad code reviewers is requested to
The proposal to merge ~pappacena/launchpad:https-mirrors-2 into
launchpad:master has been updated.
Commit message changed to:
Undoing git revert on: Allowing to register HTTPS mirrors (both for CD images
and archives).
This MP is undoing the git revert of HTTPS mirrors feature on master
(http
Thiago F. Pappacena has proposed merging ~pappacena/launchpad:https-mirrors-2
into launchpad:master.
Commit message:
Undoing git revert on: Allowing to register HTTPS mirrors (both for CD images
and archives).
This MP is undoing the git revert of HTTPS mirrors feature on master
(https
Thiago F. Pappacena has proposed merging ~pappacena/turnip:python3-take3 into
turnip:master.
Commit message:
Turnip running on Python3
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge
Thiago F. Pappacena has proposed merging
~pappacena/turnip/+git/turnip-dependencies:python3-simple-deps-upgrade into
turnip:master.
Commit message:
Upgrading support dependencies for better compatibility with Python 3.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For
MP for dependencies repository:
https://code.launchpad.net/~pappacena/turnip/+git/turnip-dependencies/+merge/380122
Diff comments:
> diff --git a/.gitignore b/.gitignore
> index fb9d39c..d35921f 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -16,3 +16,4 @@ parts
> tags
> TAGS
> turnip/vers
Thiago F. Pappacena has proposed merging
~pappacena/turnip:python3-simple-deps-upgrade into turnip:master.
Commit message:
Upgrading support dependencies for better compatibility with Python 3.
These dependencies are small and support libs that we will need to upgrade for
Python 3, but in this
Thiago F. Pappacena has proposed merging
~pappacena/turnip:xmlrpc-str-method-names into turnip:master.
Commit message:
Fixing Python3 compatibility with XMLRPC's proxy.callRemote (method names
should be str, not bytes).
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Thiago F. Pappacena has proposed merging
~pappacena/turnip:pyramid-cornice-upgrade into turnip:master.
Commit message:
Upgrading cornice, pyramid and zope libs for better compatibility with python 3.
Deps repository MP:
https://code.launchpad.net/~pappacena/turnip/+git/turnip-dependencies
Diff comments:
> diff --git a/lib/lp/codehosting/sftp.py b/lib/lp/codehosting/sftp.py
> index 51d42e7..48e7671 100644
> --- a/lib/lp/codehosting/sftp.py
> +++ b/lib/lp/codehosting/sftp.py
> @@ -111,7 +111,7 @@ class DirectoryListing:
> return self
>
> def next(self):
Shouldn't
Thiago F. Pappacena has proposed merging ~pappacena/turnip:upgrade-twisted into
turnip:master.
Commit message:
Upgrading Twisted and it's dependencies for better compatibility with python 3.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
Thiago F. Pappacena has proposed merging
~pappacena/turnip/+git/turnip-dependencies:upgrade-twisted into turnip:master.
Commit message:
Upgrading Twisted and it's dependencies for better compatibility with python 3.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For
The proposal to merge ~pappacena/turnip:upgrade-twisted into turnip:master has
been updated.
Commit message changed to:
Upgrading Twisted and it's dependencies for better compatibility with python 3.
Dependencies MP:
https://code.launchpad.net/~pappacena/turnip/+git/turnip-dependencies/+merge/
The proposal to merge
~pappacena/turnip/+git/turnip-dependencies:upgrade-twisted into turnip:master
has been updated.
Commit message changed to:
Upgrading Twisted and it's dependencies for better compatibility with python 3.
Code MP: https://code.launchpad.net/~pappacena/turnip/+git/turnip/+me
The proposal to merge ~pappacena/turnip:upgrade-twisted into turnip:master has
been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge/380166
--
Your team Launchpad code reviewers is requested to review th
Thiago F. Pappacena has proposed merging ~pappacena/turnip:upgrade-twisted into
turnip:master.
Commit message:
Upgrading Twisted and it's dependencies for better compatibility with python 3.
Dependencies MP:
https://code.launchpad.net/~pappacena/turnip/+git/turnip-dependencies/+merge/3
The proposal to merge ~pappacena/turnip:upgrade-twisted into turnip:master has
been updated.
Commit message changed to:
Upgrading Twisted and it's dependencies for better compatibility with python 3.
Dependencies MP:
https://code.launchpad.net/~pappacena/turnip/+git/turnip-dependencies/+merge/
The proposal to merge ~pappacena/turnip:beautifulsoup-upgrade into
turnip:master has been updated.
Commit message changed to:
Upgrading beautifulsoup4 for better python 3 compatibility.
Deps MP:
https://code.launchpad.net/~pappacena/turnip/+git/turnip-dependencies/+merge/380171
For more detai
Thiago F. Pappacena has proposed merging
~pappacena/turnip:beautifulsoup-upgrade into turnip:master.
Commit message:
Upgrading beautifulsoup4 for better python 3 compatibility.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
cjwatson, this is still a WIP (I'm still missing tests, for example), but I
would like to get a "pre-review", just to make sure we are aligned on what
should be done here.
Basically, I checked lp:ubuntu-archive-tools repo and it seems that the
`change-override` scripts call the changeOverride o
Diff comments:
> diff --git a/database/schema/patch-2210-12-0.sql
> b/database/schema/patch-2210-12-0.sql
> new file mode 100644
> index 000..0348301
> --- /dev/null
> +++ b/database/schema/patch-2210-12-0.sql
> @@ -0,0 +1,15 @@
> +-- Copyright 2020 Canonical Ltd. This software is license
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:change-override-log into launchpad:master.
Commit message:
Saving and showing the user that requested to override a package publishing.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #885739
cjwatson, while checking the template to show the "copied_from_archive", I've
noticed that we actually have this info displayed at some situations:
basically, we show it if the archive of the PackagePublishingHistory is not the
same as the sourcepackagename's (or build's) archive, or if the dist
Diff comments:
> diff --git a/turnip/api/store.py b/turnip/api/store.py
> index 11b4756..2179f27 100644
> --- a/turnip/api/store.py
> +++ b/turnip/api/store.py
> @@ -333,14 +334,21 @@ def repack(repo_path, ignore_alternates=False,
> single=False,
>
> def get_refs(repo_store, repo_name, excl
Thiago F. Pappacena has proposed merging ~pappacena/turnip:py3-strings-compat
into turnip:master.
Commit message:
Making some strings compatible both with python2 and python3
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
It should be showing both the "root" original package's archive and it's first
"parent", from where it was copied.
Of course, if it's the first copy of the package, it doesn't show the message
twice.
--
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/380382
Your team Laun
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:package-publishing-copied-from-archive into
launchpad:master.
Commit message:
Keeping track of the original archives of source and binary package copies on
[Source|Binary]PackagePublishingHistory.
Requested reviews:
Launchpad
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:db-patch-change-override-log into launchpad:db-devel.
Commit message:
Adding 'creator' column (and index) to BinaryPackagePublishingHistory
(SourcePackagePublishingHistory already the same column and index).
Request
I added just one suggestion. But apart from that, it's good.
Diff comments:
> diff --git a/lib/lp/code/interfaces/branch.py
> b/lib/lp/code/interfaces/branch.py
> index f0e9393..ccb4084 100644
> --- a/lib/lp/code/interfaces/branch.py
> +++ b/lib/lp/code/interfaces/branch.py
> @@ -1427,10 +1427,3
Thiago F. Pappacena has proposed merging
~pappacena/turnip:reverting-pygit-dep-version into turnip:master.
Commit message:
Downgrading pycparser to comply with pygit dependency of pycparser<2.18.
pycparser was mistakenly upgraded previously, and `make check` didn't warn
about the
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:https-mirror-prober-proxy-fix into launchpad:master.
Commit message:
Adding a HTTPS proxy-CONNECT for twisted, and using it for HTTPS mirrors prober.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:https-mirror-tls-version into launchpad:master.
Commit message:
Changing TLS version used on HTTPS mirrors (using 1.2 instead of 1.1), which
should be compatible with most of HTTPS servers.
Requested reviews:
Launchpad code
Thiago F. Pappacena has proposed merging ~pappacena/launchpad:prober-test-fix
into launchpad:master.
Commit message:
Removing duplicated setup code on mirror prober tests.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:mirror-prober-parallelism-control into launchpad:master.
Commit message:
Adding options to distribution mirror prober to allow us to easily control
maximum number of requests in parallel that should be issued.
Requested reviews
cjwatson, I'm opening this MP for review, and I will create a new one for OCI
Recipe creation to make the review process easier. Otherwise, the diff will be
too big.
This one should be easy since most of the lines changed are marking OCIProject
and OCIRecipe fields as "exported".
--
https://co
Thiago F. Pappacena has proposed merging ~pappacena/launchpad:oci-project-api
into launchpad:master.
Commit message:
API for managing OCI Project
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:oci-api-create-recipe into launchpad:master with
~pappacena/launchpad:oci-project-api as a prerequisite.
Commit message:
API operation to create a new OCIRecipe from an existing OCIProject.
The feature is only enabled if we turn on
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:package-history-test-fix into launchpad:master.
Commit message:
Fixing tests broken by the new package publishing history messages.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Diff comments:
> diff --git a/lib/lp/registry/model/ociproject.py
> b/lib/lp/registry/model/ociproject.py
> index c13ee66..916d206 100644
> --- a/lib/lp/registry/model/ociproject.py
> +++ b/lib/lp/registry/model/ociproject.py
> @@ -88,7 +94,7 @@ class OCIProject(BugTargetBase, StormBase):
>
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:oci-api-create-project into launchpad:master.
Commit message:
API operation to create a new OCIProject for a Distribution.
The feature is only enabled if we turn on the 'oci.project.create.enabled'
feature flag.
Request
The proposal to merge ~pappacena/launchpad:oci-api-create-project into
launchpad:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/381189
--
Your team Launchpad code reviewers is req
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:oci-api-create-project into launchpad:master.
Commit message:
API operation to create a new OCIProject for a Distribution.
The feature is only enabled if we turn on the 'oci.project.create.enabled'
feature flag.
Request
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:unexporting-ocirecipe-build-attributes into
launchpad:master.
Commit message:
Avoiding to export on the OCIRecipe API the build fields.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
The API method to create OCIProject here is public, but behind a feature flag.
I'm planning to work on the permission in a different MP, in order to reduce
diff size and make the review easier.
--
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/381189
Your team Launchpad c
The proposal to merge ~pappacena/launchpad:db-patch-oci-project-admin into
launchpad:master has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/381319
--
Your team Launchpad code reviewers is r
Thiago F. Pappacena has proposed merging
~pappacena/launchpad:db-patch-oci-project-admin into launchpad:db-devel.
Commit message:
Database patch creating Distribution.oci_project_admin column, which should be
used to grant permission to person/team that can manage OCI projects.
Requested
Thiago F. Pappacena has proposed merging ~pappacena/launchpad:oci-project-admin
into launchpad:master.
Commit message:
Adding the attribute and method to check if a given person has permission to
manage OCI projects for a given Distribution.
Requested reviews:
Launchpad code reviewers
LGTM
--
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/381336
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:py3-replace-new-module into launchpad:master.
___
Mailing list: http
LGTM. Just added a couple of minor notes for coding style.
Let's see wgrant's opinion.
Diff comments:
> diff --git a/lp_signing/auth.py b/lp_signing/auth.py
> index e78a46b..f73ce77 100644
> --- a/lp_signing/auth.py
> +++ b/lp_signing/auth.py
> @@ -78,6 +85,28 @@ class BoxedRequest(Request):
>
1 - 100 of 779 matches
Mail list logo
