Ines Almeida has proposed merging
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master.
Commit message:
Update fetch service revoke token authentication
We now use the proxy token as authentication to the fetch service control API
to revoke
@Ines I would love to have this merged asap, as both my and Simone's work base
on this, and having this pre-requisite MPs juggling around is pretty cumbersome.
The code path for the fetch service cannot be triggered yet, so I do not see
any issues with merging this - even without the auth being
Thanks you for the comments!
I don't think we need feature flag here simply because the feature flag in the
launchpad code base should already do the same. The fetch service code in
buildd will only be reached if the snap object has a `use_fetch_service` bool
True - which will only be possible
Thanks! I added some comments. This is almost done, but let's try to use
consistent, descriptive and RFC compliant naming for the hosts.
Do you think we need a feature flag for this? I do not think so, but you might
have more insight.
Diff comments:
> diff --git a/lpbuildd/proxy.py
This MP has been updated after some conversations. The topic of how to
authenticate the call to revoke the token is still on not decided on, so that
part might change.
--
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd/+merge/462875
Your team Launchpad code
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Description changed to:
This handles calling the revocation endpoint against the fetch service, but not
yet closing the session (that will be handled in
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Description changed to:
This handles calling the revocation endpoint against the fetch service, but not
yet closing the session (that will be handled in
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd/+merge/462875
--
Your
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Commit message changed to:
Enable revoking a token for the fetch service
Handle calling the revocation_endpoint sent by Launchpad, both in the cases
Ines Almeida has proposed merging
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master.
Commit message:
WIP: Update end-of-session code for snaps that use the fetch service
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For
Given we will have 2 endpoints (one for token revocation, another for session
closing), I decided to separate this into 2 MPs:
- This one will handle adding the logic to call the revocation endpoint to the
fetch service
- The next one will handle closing the fetch service session and saving
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Status: Needs review => Work in progress
For more details, see:
In a meeting, decided that we will most likely need to have 2 endpoints for
ending the session:
- One for revoking the token
- Another one to close the session
This MP is blocked until we settle that out.
--
Ines Almeida has proposed merging
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master.
Commit message:
WIP: Update end-of-session code for snaps that use the fetch service
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For
14 matches
Mail list logo
