Re: [Launchpad-reviewers] [Merge] ~pelpsi/lp-signing:update-development-documentation into lp-signing:master

2024-03-04 Thread Simone Pelosi



Diff comments:

> diff --git a/README.rst b/README.rst
> index 5fc6b9b..4e52196 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -38,6 +38,12 @@ Generate another key pair, and add the private half to 
> ``private_keys``
>  
>  $ env/bin/lp-signing generate-key-pair
>  
> +If you want to communicate with the lp-signing server, 
> +add your client to the signing service::
> +
> +$ source env/bin/activate
> +$ lp-signing register-client  

base64-encoded NaCl public key, let me add this information to the doc

> +
>  Start the server::
>  
>  $ make run


-- 
https://code.launchpad.net/~pelpsi/lp-signing/+git/lp-signing/+merge/461650
Your team Launchpad code reviewers is requested to review the proposed merge of 
~pelpsi/lp-signing:update-development-documentation into lp-signing:master.


___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp


Re: [Launchpad-reviewers] [Merge] ~pelpsi/lp-signing:update-development-documentation into lp-signing:master

2024-03-04 Thread Jürgen Gmach



Diff comments:

> diff --git a/README.rst b/README.rst
> index 5fc6b9b..4e52196 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -38,6 +38,12 @@ Generate another key pair, and add the private half to 
> ``private_keys``
>  
>  $ env/bin/lp-signing generate-key-pair
>  
> +If you want to communicate with the lp-signing server, 
> +add your client to the signing service::
> +
> +$ source env/bin/activate
> +$ lp-signing register-client  

Is the key a path to a file or the public key as a string?

> +
>  Start the server::
>  
>  $ make run


-- 
https://code.launchpad.net/~pelpsi/lp-signing/+git/lp-signing/+merge/461650
Your team Launchpad code reviewers is requested to review the proposed merge of 
~pelpsi/lp-signing:update-development-documentation into lp-signing:master.


___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp


[Launchpad-reviewers] [Merge] ~pelpsi/lp-signing:update-development-documentation into lp-signing:master

2024-03-01 Thread Simone Pelosi
Simone Pelosi has proposed merging 
~pelpsi/lp-signing:update-development-documentation into lp-signing:master.

Commit message:
Add register-client command to the documentation

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pelpsi/lp-signing/+git/lp-signing/+merge/461650
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of 
~pelpsi/lp-signing:update-development-documentation into lp-signing:master.
diff --git a/README.rst b/README.rst
index 5fc6b9b..4e52196 100644
--- a/README.rst
+++ b/README.rst
@@ -38,6 +38,12 @@ Generate another key pair, and add the private half to ``private_keys``
 
 $ env/bin/lp-signing generate-key-pair
 
+If you want to communicate with the lp-signing server, 
+add your client to the signing service::
+
+$ source env/bin/activate
+$ lp-signing register-client  
+
 Start the server::
 
 $ make run
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp