[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

2018-04-25 Thread noreply
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup-2/+merge/343236 -- Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

2018-04-16 Thread Maximiliano Bertacchini
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad has been updated. Description changed to: Add sitesearch tests based on doctests. - sitesearch/doc/google-searchservice.txt => sitesearch/tests/test_google.py - sitesearch/doc/bing-searchservice.txt =>

Re: [Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

2018-04-16 Thread Maximiliano Bertacchini
All comments addressed. Was unsure about deleting those doctests or keeping them for documentation purposes. Also, there's an extra disabled doctest, which I think I could tackle in this same branch. What do you think? Diff comments: > === modified file

Re: [Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

2018-04-14 Thread Colin Watson
Also, did you intend to remove the corresponding doctests at the same time? They still seem to be in this tree. -- https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup-2/+merge/343236 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

Re: [Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

2018-04-14 Thread Colin Watson
Review: Approve Most of these comments apply in multiple places, but I've only commented on the first occurrence of each. Diff comments: > === modified file 'lib/lp/services/sitesearch/tests/test_bing.py' > --- lib/lp/services/sitesearch/tests/test_bing.py 2018-04-12 19:42:23 > + >

[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

2018-04-13 Thread Maximiliano Bertacchini
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad has been updated. Description changed to: Add sitesearch tests based on doctests. - sitesearch/doc/google-searchservice.txt => sitesearch/tests/test_google.py - sitesearch/doc/bing-searchservice.txt =>

[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

2018-04-13 Thread Maximiliano Bertacchini
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad has been updated. Commit message changed to: Add sitesearch tests based on doctests. For more details, see: https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup-2/+merge/343236 -- Your team

[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

2018-04-13 Thread Maximiliano Bertacchini
Maximiliano Bertacchini has proposed merging lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad with lp:~maxiberta/launchpad/sitesearch-cleanup-1 as a prerequisite. Commit message: Assorted sitesearch fixes and improvements (part 2). Requested reviews: Launchpad code reviewers

[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

2018-04-13 Thread Maximiliano Bertacchini
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad has been updated. Status: Work in progress => Superseded For more details, see: https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup-2/+merge/343235 -- Your team Launchpad code reviewers is