Review: Approve
Diff comments:
>
> === modified file 'lpbuildd/target/lxd.py'
> --- lpbuildd/target/lxd.py2018-06-12 23:23:13 +
> +++ lpbuildd/target/lxd.py2018-10-25 09:55:10 +
> @@ -277,16 +277,30 @@
> old_profile.delete()
>
> raw_lxc_config = [
> -
The proposal to merge lp:~tobijk/launchpad-buildd/launchpad-buildd-bionic into
lp:launchpad-buildd has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~tobijk/launchpad-buildd/launchpad-buildd-bionic/+merge/354331
--
Your team Launchpad code
@cjwatson, thanks for the clarification on the "resubmit". I'm not sure how you
want the re-factoring on `raw_lxc_config` to look like, so maybe it's better if
you just mold it to your liking. Thanks.
Diff comments:
>
> === modified file 'lpbuildd/target/lxd.py'
> --- lpbuildd/target/lxd.py
(The "Resubmit" vote is something that your reviewer might use to indicate that
the MP needs to be entirely withdrawn and resubmitted, perhaps against a
different branch. It isn't something you do when you've made revisions in
response to a review.)
Regarding tests at package build time,
The proposal to merge lp:~tobijk/launchpad-buildd/launchpad-buildd-bionic into
lp:launchpad-buildd has been updated.
Description changed to:
This patch makes the buildd's LXD backend work on Bionic:
* Based on LXD version modify raw.lxc settings (some parameter names have
changed)
* Fix a
Is there a reason why only tests in lpbuildd/tests are run during package build?
--
https://code.launchpad.net/~tobijk/launchpad-buildd/launchpad-buildd-bionic/+merge/354331
Your team Launchpad code reviewers is requested to review the proposed merge of
Review: Resubmit
@cjwatson, ready for re-review.
Diff comments:
>
> === modified file 'lpbuildd/target/lxd.py'
> --- lpbuildd/target/lxd.py2018-06-12 23:23:13 +
> +++ lpbuildd/target/lxd.py2018-10-25 07:43:01 +
> @@ -277,16 +277,31 @@
> old_profile.delete()
>
>
Review: Needs Fixing
Diff comments:
> === modified file 'lpbuildd/target/lxd.py'
> --- lpbuildd/target/lxd.py2018-06-12 23:23:13 +
> +++ lpbuildd/target/lxd.py2018-09-17 13:33:57 +
> @@ -277,16 +278,34 @@
> old_profile.delete()
>
> raw_lxc_config = [
> -
@cjwatson, please review.
--
https://code.launchpad.net/~tobijk/launchpad-buildd/launchpad-buildd-bionic/+merge/354331
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~tobijk/launchpad-buildd/launchpad-buildd-bionic into lp:launchpad-buildd.
The proposal to merge lp:~tobijk/launchpad-buildd/launchpad-buildd-bionic into
lp:launchpad-buildd has been updated.
Description changed to:
This patch makes the buildd's LXD backend work on Bionic:
* Use client host_info, apt cache, lxd --version in that order to find LXD
version
* Based on
Thanks a lot for the initial review! When you find the time, maybe you can skim
over this and see if it is better now. I'll see what I can do about the tests.
--
https://code.launchpad.net/~tobijk/launchpad-buildd/launchpad-buildd-bionic/+merge/354331
Your team Launchpad code reviewers is
The proposal to merge lp:~tobijk/launchpad-buildd/launchpad-buildd-bionic into
lp:launchpad-buildd has been updated.
Description changed to:
This patch makes the buildd's LXD backend work on Bionic:
* Use client host_info, apt cache, lxd --version in that order to find LXD
version
* Based on
Review: Needs Fixing
Thanks for working on this!
As well as the inline comments I've left, I'm pretty sure that this is going to
need changes to the test suite.
Diff comments:
> === modified file 'lpbuildd/target/lxd.py'
> --- lpbuildd/target/lxd.py2018-06-12 23:23:13 +
> +++
Tobias Koch has proposed merging
lp:~tobijk/launchpad-buildd/launchpad-buildd-bionic into lp:launchpad-buildd.
Commit message:
bionic compatibility
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
14 matches
Mail list logo
