Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/python-oops/py3 into lp:python-oops

2018-02-08 Thread Colin Watson
Ah, of course, thanks.  Done.
-- 
https://code.launchpad.net/~cjwatson/python-oops/py3/+merge/337332
Your team Launchpad code reviewers is requested to review the proposed merge of 
lp:~cjwatson/python-oops/py3 into lp:python-oops.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp


Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/python-oops/py3 into lp:python-oops

2018-02-08 Thread Robert Collins
Review: Approve

Looks fine to me.

Note that 

str == bytes would be more idiomatic as
str is bytes

but its functionally equivalent so shrug :).
-- 
https://code.launchpad.net/~cjwatson/python-oops/py3/+merge/337332
Your team Launchpad code reviewers is requested to review the proposed merge of 
lp:~cjwatson/python-oops/py3 into lp:python-oops.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp