Re: [Lazarus] JCF2 patch in trunk

2020-09-11 Thread Michael Van Canneyt via lazarus
On Fri, 11 Sep 2020, Mattias Gaertner via lazarus wrote: On Fri, 11 Sep 2020 13:14:59 +0300 "Alexey Tor. via lazarus" wrote: https://github.com/graemeg/lazarus/commit/f4ffd5e0640948e9c396e1ef1b2aacd90512ac77    if StartsText('{$include',pcToken.SourceCode)=true then   lPos:=10     e

Re: [Lazarus] JCF2 patch in trunk

2020-09-11 Thread Mattias Gaertner via lazarus
On Fri, 11 Sep 2020 13:14:59 +0300 "Alexey Tor. via lazarus" wrote: > https://github.com/graemeg/lazarus/commit/f4ffd5e0640948e9c396e1ef1b2aacd90512ac77 > >    if StartsText('{$include',pcToken.SourceCode)=true then >   lPos:=10 >     else if StartsStr('{$I',pcToken.SourceCode)=true then

Re: [Lazarus] JCF2 patch in trunk

2020-09-11 Thread Bart via lazarus
On Fri, Sep 11, 2020 at 12:15 PM Alexey Tor. via lazarus wrote: > if StartsText('{$include',pcToken.SourceCode)=true then >lPos:=10 > else if StartsStr('{$I',pcToken.SourceCode)=true then I really dislike this "if BooleanExpression=true" (or: "if BooleanExpression=false"). A sim

[Lazarus] JCF2 patch in trunk

2020-09-11 Thread Alexey Tor. via lazarus
https://github.com/graemeg/lazarus/commit/f4ffd5e0640948e9c396e1ef1b2aacd90512ac77    if StartsText('{$include',pcToken.SourceCode)=true then   lPos:=10     else if StartsStr('{$I',pcToken.SourceCode)=true then a) $include is searched case-insens? why no space after "$include" to avoid inc