Re: [Lazarus] TMask revisited

2021-10-16 Thread Bart via lazarus
On Sat, Oct 16, 2021 at 11:20 PM Juha Manninen via lazarus wrote: > Ideas? Comments? I see you implemented the "old" constructors with the TMaskOptions parameter and deprecated them as suggested. Thanks for that. Maybe add: 'Will be removed in 2.4' or similar to the deprecated message? The

Re: [Lazarus] TMask revisited

2021-10-16 Thread Juha Manninen via lazarus
I turned the define RANGES_AUTOREVERSE into a run time option in 67111d9a30. A boolean RangeAutoReverse is True by default. I don't really know when somebody would want to turn it off. I also added constructors and functions for legacy syntax, which means [?] represents a literal '?' and

Re: [Lazarus] TMask revisited

2021-10-16 Thread Bart via lazarus
On Sat, Oct 16, 2021 at 3:19 PM Maxim Ganetsky via lazarus wrote: > > So far, this has not been reporduced by others in this thread. > > Juha already reproduced it. Happens in `Find in Files` dialog. That's GMail for you. When I wrote that, it was a reply to the only new message in this thread

Re: [Lazarus] TMask revisited

2021-10-16 Thread Maxim Ganetsky via lazarus
16.10.2021 16:11, Bart via lazarus пишет: On Sat, Oct 16, 2021 at 12:14 AM DougC via lazarus wrote: Shouldn't the mask "*.pas*" be used to match file.pas.bak ? If so, the old code and new code are ok. You miss the point. It was said that the mask '*.pas;*.pp;*.inc' now also matched the

Re: [Lazarus] TMask revisited

2021-10-16 Thread Bart via lazarus
On Sat, Oct 16, 2021 at 12:14 AM DougC via lazarus wrote: > Shouldn't the mask "*.pas*" be used to match file.pas.bak ? If so, the old > code and new code are ok. You miss the point. It was said that the mask '*.pas;*.pp;*.inc' now also matched the file foo.pas.bak, which would be a bug. So

Re: [Lazarus] TMask revisited

2021-10-16 Thread Maxim Ganetsky via lazarus
16.10.2021 13:00, Juha Manninen via lazarus пишет: P.S. Not related to the Mask code but I installed TortoiseGit on Windows. It works OK but still does not offer anything as good as *gitk*. The "Show log" view shows commits and their messages, and names of changed files but no diffs. Getting

Re: [Lazarus] TMask revisited

2021-10-16 Thread Maxim Ganetsky via lazarus
16.10.2021 11:54, Juha Manninen via lazarus пишет: On Sat, Oct 16, 2021 at 11:20 AM Juha Manninen mailto:juha.mannine...@gmail.com>> wrote: Yes, the TMaskWindows indeed behaves wrong. '**.pas*' matches with '*abc.pas.bak*'. Fixed in a111270ed0. Please test. No code changes were

Re: [Lazarus] TMask revisited

2021-10-16 Thread Juha Manninen via lazarus
On Sat, Oct 16, 2021 at 12:23 AM Bart via lazarus < lazarus@lists.lazarus-ide.org> wrote: > > Yes, there should be an option for backwards compatible syntax, like > "[?]" . However the small changes in the syntax can be seen as improvements. > > There already is a define for converting "[z-a]" to

Re: [Lazarus] TMask revisited

2021-10-16 Thread Juha Manninen via lazarus
On Sat, Oct 16, 2021 at 11:20 AM Juha Manninen wrote: > Yes, the TMaskWindows indeed behaves wrong. '**.pas*' matches with ' > *abc.pas.bak*'. > Fixed in a111270ed0. Please test. No code changes were needed. I only disabled one of the Windows quirks, namely eWindowsQuirk_Extension3More. Please

Re: [Lazarus] TMask revisited

2021-10-16 Thread Juha Manninen via lazarus
On Fri, Oct 15, 2021 at 3:38 PM Maxim Ganetsky via lazarus < lazarus@lists.lazarus-ide.org> wrote: > Please try with, for example bla.pas and bla.pas.bak files. > I got another mail from Maxim. It was also sent to this list but didn't appear. I also configured my Windows under Virtualbox for