Re: [Lazarus] New TMaskList [forked from: TMask revisited]

2021-10-26 Thread Bart via lazarus
On Tue, Oct 26, 2021 at 7:20 PM Bart wrote: > So, now we have: > TMask > TMaskWindows About naming: We have MatchesWindowsMask(List), but TMaskWindows. That's not very logical or consistent. Either we should rename TMaskWindows to TWindowsMask, or fase out MatchesWindowsMask(List) in favour of

Re: [Lazarus] New TMaskList [forked from: TMask revisited]

2021-10-26 Thread Bart via lazarus
On Tue, Oct 26, 2021 at 9:15 PM Juha Manninen via lazarus wrote: > Yes, sounds OK, I'll have a go at it then > but it cannot cover CreateSysNative which is now used in procedure > TFileSearcher.Search. > The IFDEF can be placed there directly of course. Probably better. -- Bart --

Re: [Lazarus] New TMaskList [forked from: TMask revisited]

2021-10-26 Thread Juha Manninen via lazarus
On Tue, Oct 26, 2021 at 8:24 PM Bart via lazarus < lazarus@lists.lazarus-ide.org> wrote: > However, now that we have a dedicated TMaskWindows, wouldn't it also > make more sense to have a TMaskListWindows class? > > The TMaskList constructors > constructor CreateWindows(const aValue: String;

[Lazarus] New TMaskList [forked from: TMask revisited]

2021-10-26 Thread Bart via lazarus
Hi, So, now we have: TMask TMaskWindows TMaskList TMaskList also caters for the old TMask.MatchesWindowsMask. However, now that we have a dedicated TMaskWindows, wouldn't it also make more sense to have a TMaskListWindows class? The TMaskList constructors constructor CreateWindows(const

Re: [Lazarus] TMask revisited

2021-10-26 Thread Bart via lazarus
On Tue, Oct 26, 2021 at 6:48 PM Bart wrote: > Point 2 would need (probably a minor) change to the CompileRange method. Attached diff might do what I intended. @José: does it in fact allow ? in a range as a literal, without side effects. I don't really understand the matching algorithm. --

Re: [Lazarus] TMask revisited

2021-10-26 Thread Bart via lazarus
On Tue, Oct 26, 2021 at 1:38 PM José Mejuto via lazarus wrote: > You found a bug, I thought about it some more. Inside a range everything is treated as a literal, the only exceptions are: 1. [?] 2. '!' as the first char in a range when [mocNegateGroup] is enabled. 3. '-' if it is NOT the first

Re: [Lazarus] TMask revisited

2021-10-26 Thread José Mejuto via lazarus
El 24/10/2021 a las 15:48, Bart via lazarus escribió: It looks like escaping does not work as advertised? Seems like escaping is NOT supported in ranges or sets, but only outside them? If that is the case (and by design) then, with [mocRange] enabled, you can only have '-' in a range if the

Re: [Lazarus] TMask revisited

2021-10-26 Thread Juha Manninen via lazarus
On Mon, Oct 25, 2021 at 7:20 PM Bart via lazarus < lazarus@lists.lazarus-ide.org> wrote: > As I see it now, we are planning to remove all the old TMask stuff (in > the future) and replace it with the new and improved TMask. > > Shouldn't that mean that we should also deprecate the CreateLegacy