On Tue, 12 Dec 2017 11:14:09 +0100
Sven Barth via Lazarus wrote:
>[...]
> Patches with formatting changes are very likely to be rejected in code that
> belongs to the FPC project (can't speak about Lazarus here) and for the
> compiler itself it is even nearly
On Tue, Dec 12, 2017 at 11:14:09AM +0100, Sven Barth via Lazarus wrote:
> want.
> The modus operandi is to adhere to the formatting of the surrounding code.
>
> I will do whole work again as Romans want if Romans pay me.
>
>
> Patches with formatting changes are very likely to be rejected in
Am 12.12.2017 09:07 schrieb "Sergey Bodrov via Lazarus" <
lazarus@lists.lazarus-ide.org>:
2017-12-11 19:18 GMT+03:00 Sven Barth via Lazarus <
lazarus@lists.lazarus-ide.org>:
Problem is that I first change code formatting just to make it readable,
> and then do fixes. Most fixes was impossible
2017-12-11 19:18 GMT+03:00 Sven Barth via Lazarus <
lazarus@lists.lazarus-ide.org>:
Problem is that I first change code formatting just to make it readable,
> and then do fixes. Most fixes was impossible without reformatting.
>
>
> In projects like Lazarus and Free Pascal it's "when in Rome, do
Am 11.12.2017 15:15 schrieb "Sergey Bodrov via Lazarus" <
lazarus@lists.lazarus-ide.org>:
2017-12-11 16:14 GMT+03:00 Marco van de Voort via Lazarus <
lazarus@lists.lazarus-ide.org>:
> On Sun, Dec 10, 2017 at 01:25:59PM +0300, Sergey Bodrov via Lazarus wrote:
> >
> > I change code formatting,
On Mon, Dec 11, 2017 at 05:15:36PM +0300, Sergey Bodrov via Lazarus wrote:
> > big style related operations mixing it with real fixes. Now you know why
> > :-)
> >
>
> Problem is that I first change code formatting just to make it readable,
> and then do fixes. Most fixes was impossible without
2017-12-11 16:14 GMT+03:00 Marco van de Voort via Lazarus <
lazarus@lists.lazarus-ide.org>:
> On Sun, Dec 10, 2017 at 01:25:59PM +0300, Sergey Bodrov via Lazarus wrote:
> >
> > I change code formatting, many private names, add many comments and
> embrace
> > whole blocks of code into
On Sun, Dec 10, 2017 at 01:25:59PM +0300, Sergey Bodrov via Lazarus wrote:
>
> I change code formatting, many private names, add many comments and embrace
> whole blocks of code into try..finally. And now can't tell, which parts is
> most essential.
Yes. Somebody will have to figure that mess
>
> On Fri, Dec 08, 2017 at 03:23:06PM +0300, Sergey Bodrov via Lazarus wrote:
> > There is too many changes in many files, and that can't be posted as
> simple
> > diff patch.
>
> Then layer them. Make patches for the most essential bits, and then
> reallign
> your sources.
>
I change code