Re: [Lazarus] Editor toolbar changes ?

2015-09-01 Thread Michael Van Canneyt
On Tue, 1 Sep 2015, Juha Manninen wrote: On Tue, Sep 1, 2015 at 7:39 PM, Ondrej Pokorny wrote: I updated, but see no changes. What are we supposed to see ? Michael. If you add one of the JumpTo* buttons (e.g. "Jump to Implementation") to IDECoolBar or EditorToolBar you

Re: [Lazarus] Editor toolbar changes ?

2015-09-01 Thread Juha Manninen
Good news! Trunk revision 49732 implements configurable ToolButtons with dropdown lists. The design is from Ondrej Pokorny. It uses a new class TIDEToolButton + polymorphism and integrates with TIDEMenuCommand. The code that implements a specific button can be in a package. We have a clean API now

Re: [Lazarus] Editor toolbar changes ?

2015-09-01 Thread Ondrej Pokorny
On 01.09.2015 17:54, Michael Van Canneyt wrote: On Tue, 1 Sep 2015, Graeme Geldenhuys wrote: On 2015-09-01 12:16, Juha Manninen wrote: I added JumpToImplementation button to the default configuration. It is identical with the orignal Editor Toolbar now. Graeme and Michael, please test. Many

Re: [Lazarus] Editor toolbar changes ?

2015-09-01 Thread Juha Manninen
On Tue, Sep 1, 2015 at 7:39 PM, Ondrej Pokorny wrote: >> I updated, but see no changes. What are we supposed to see ? >> >> Michael. > > If you add one of the JumpTo* buttons (e.g. "Jump to Implementation") to > IDECoolBar or EditorToolBar you will see that they have a

Re: [Lazarus] Editor toolbar changes ?

2015-09-01 Thread Graeme Geldenhuys
On 2015-09-01 12:16, Juha Manninen wrote: > I added JumpToImplementation button to the default configuration. It > is identical with the orignal Editor Toolbar now. > > Graeme and Michael, please test. Many thanks Juha (and anybody else that contributed). I'll get an update tonight and test.

Re: [Lazarus] Editor toolbar changes ?

2015-09-01 Thread Michael Van Canneyt
On Tue, 1 Sep 2015, Graeme Geldenhuys wrote: On 2015-09-01 12:16, Juha Manninen wrote: I added JumpToImplementation button to the default configuration. It is identical with the orignal Editor Toolbar now. Graeme and Michael, please test. Many thanks Juha (and anybody else that

Re: [Lazarus] Editor toolbar changes ?

2015-08-04 Thread Juha Manninen
On Tue, Aug 4, 2015 at 12:26 PM, Michael Van Canneyt mich...@freepascal.org wrote: But: If I click the 'configure' button, the 'jump to' is not displayed in the list of enabled buttons. Earlier it was hard-coded and not configurable. IMO it did not deserve any special treatment, it should one

Re: [Lazarus] Editor toolbar changes ?

2015-08-04 Thread Graeme Geldenhuys
On 2015-08-04 13:11, Juha Manninen wrote: Personal preferences differ. I did not realize it was so crucial for somebody. I thought only Graeme uses it. :) So I don't count. :) However it may be easier to fix than I first though. The Search menu already has a menu section for the Jump ...

Re: [Lazarus] Editor toolbar changes ?

2015-08-04 Thread Michael Van Canneyt
On Tue, 4 Aug 2015, Juha Manninen wrote: On Tue, Aug 4, 2015 at 2:50 PM, Michael Van Canneyt mich...@freepascal.org wrote: Double-click 'jump to' under 'Code explorer' ? Maybe this is another jump to ? Right, yes. That one is quite useless in a toolbar. I don't know how to filter out the

Re: [Lazarus] Editor toolbar changes ?

2015-08-04 Thread Juha Manninen
On Tue, Aug 4, 2015 at 2:50 PM, Michael Van Canneyt mich...@freepascal.org wrote: Double-click 'jump to' under 'Code explorer' ? Maybe this is another jump to ? Right, yes. That one is quite useless in a toolbar. I don't know how to filter out the useless commands. Another related issue are the

[Lazarus] Editor toolbar changes ?

2015-08-04 Thread Michael Van Canneyt
Hi, I have 2 lazarus installations: A new one (one that was compiler more recently: today). Another one is a little older (rev 49180). I have in the older installation in the editor toolbar a dropdown button with the items 'Jump to' menu. It works as expected. But: If I click the

Re: [Lazarus] Editor toolbar changes ?

2015-08-04 Thread Michael Van Canneyt
On Tue, 4 Aug 2015, Juha Manninen wrote: On Tue, Aug 4, 2015 at 12:26 PM, Michael Van Canneyt mich...@freepascal.org wrote: But: If I click the 'configure' button, the 'jump to' is not displayed in the list of enabled buttons. Earlier it was hard-coded and not configurable. IMO it did not

Re: [Lazarus] Editor toolbar changes ?

2015-08-04 Thread Michael Van Canneyt
On Tue, 4 Aug 2015, Graeme Geldenhuys wrote: On 2015-08-04 10:26, Michael Van Canneyt wrote: In the newer installation, when I add the 'Jump to' button, a button is added to the editor toolbar, but it is not functional: the dropdown menu is not shown, and clicking it does not do anything

Re: [Lazarus] Editor toolbar changes ?

2015-08-04 Thread Graeme Geldenhuys
On 2015-08-04 10:26, Michael Van Canneyt wrote: In the newer installation, when I add the 'Jump to' button, a button is added to the editor toolbar, but it is not functional: the dropdown menu is not shown, and clicking it does not do anything (not surprising). This drove me insane too.

Re: [Lazarus] Editor toolbar changes ?

2015-08-04 Thread Juha Manninen
On Tue, Aug 4, 2015 at 3:24 PM, Graeme Geldenhuys mailingli...@geldenhuys.co.uk wrote: If the combobox could be added again, I too would be very grateful. I mostly used the default button behaviour (jump to implementation - without having to open the combobox), but on occasion I used the other