Re: [Lazarus] Package editor in Lazarus 1.6

2016-01-28 Thread Mattias Gaertner 
On Thu, 28 Jan 2016 14:34:25 +0200
Juha Manninen  wrote:

> On Thu, Jan 28, 2016 at 12:06 AM, Mattias Gaertner
>  wrote:
> > And what was the bug?
> > It does not sound like a bugfix, so I'm a bit worried that it went to
> > 1.6RC2.
> 
> Most changes were made before 1.6 was branched.

Ok. I was just a bit worried when you wrote it is in RC2 instead of
writing it is "in 1.6" and that it wasn't documented.


> Many usability issues were fixed.

Usability is a broad term. If something is unusable then it needs a
fix. If it only "improves" usability, then it is not a bug fix.


> Only the last one was merged to 1.6,
> others happened before it.
> IMO the package editor is now smooth and nice.

Good.
Just keep in mind that "smooth and nice" includes documentation. :)

Mattias

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Package editor in Lazarus 1.6

2016-01-28 Thread Juha Manninen 
On Thu, Jan 28, 2016 at 12:06 AM, Mattias Gaertner
 wrote:
> And what was the bug?
> It does not sound like a bugfix, so I'm a bit worried that it went to
> 1.6RC2.

Most changes were made before 1.6 was branched. They don't need to be
only bug fixes then.
For example the AddMore button change is from last May which is half a
year before 1.6 branch:

 r49046  Package editor: Replace AddMore button with a popup menu.
Step 1. to improve the GUI. Issue #28097, (modified) patch from Alexey
Torgashin.
and
 r49096  IDE: Improve adding a new file to package, reuse the "New..."
dialog. Issue #28097, patch from Alexey Torgashin.

The only commit merged into 1.6 that was not really a bug fix is from
December 15 :
 r50815  Package editor: Duplicate the "Add" button's menu items in
tree popup menu. Part of issue #28097.
It was kind of part of the improvements I wanted to finish and is
rather safe. It only adds menu items for existing functionality.

Also look at the related issues, like:
  http://bugs.freepascal.org/view.php?id=26188
Many usability issues were fixed. Only the last one was merged to 1.6,
others happened before it.
IMO the package editor is now smooth and nice.

Juha

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Package editor in Lazarus 1.6

2016-01-28 Thread Juha Manninen 
On Mon, Jan 25, 2016 at 9:53 PM, Michael Van Canneyt
 wrote:
> Requirements must still be added one at a time; The requirement dialog shows
> a dropdown.
> ...

Yes, that is true. There should be either a CheckListbox or a Listbox
with multi-select.


> If you select a required package in the package dialog, the bottom of the
> package dialog shows the min/max required version. This is easy to change
> it.
>
> In the project dialog, if you select a required package, there is no way to
> set the min/max required version. You must delete the requirement, and add
> it again, because only during the add you can specify the version.
> It would be nice to offer the same functionality as in the package dialog.
>
> As an aside:
>
> I also think it would be nice if the min/max versions were simply shown in
> the package tree.

Ok, there is an old bug report about it.
  http://bugs.freepascal.org/view.php?id=20377

I will look at these issues later.

Juha

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Package editor in Lazarus 1.6

2016-01-27 Thread Mattias Gaertner 
On Wed, 27 Jan 2016 22:12:59 +0200
Juha Manninen  wrote:

> On Wed, Jan 27, 2016 at 7:44 PM, Mattias Gaertner
>  wrote:
> > What bug was fixed with this patch?
> > ...
> > Changes should be documented:
> > http://wiki.lazarus.freepascal.org/Lazarus_1.6.0_release_notes#IDE_Changes
> 
> Ok, I added a "Package editor" section there.
> Reducing two "Add" buttons to one button was the biggest visible change.
> There were many other changes to make it smooth to use. Yes, it uses
> my new ModifySilently concept which conflicts with your earlier
> concept. Some method names should be fixed but otherwise I still feel
> it is an easy and clean way to do it. You should look at it sometime
> later.

And what was the bug?
It does not sound like a bugfix, so I'm a bit worried that it went to
1.6RC2.

 
> > http://wiki.lazarus.freepascal.org/IDE_Window:_Package_Editor
> 
> Uhhh, that needs more updating. The screenshot must be updated for sure.
> I will look at it tomorrow.

Thanks.

Mattias


--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Package editor in Lazarus 1.6

2016-01-27 Thread Mattias Gaertner 
On Mon, 25 Jan 2016 18:41:42 +0200
Juha Manninen  wrote:

> Forgot to write earlier...
> 
> The package editor has been improved in RC2.
> See this + its related issues :
>   http://bugs.freepascal.org/view.php?id=28097

What bug was fixed with this patch?

> The changes were partly inspired by ideas from Michael Van Canneyt and others.
> See this mail thread :
>  
> http://free-pascal-lazarus.989080.n3.nabble.com/Lazarus-Package-dialog-tt4041400.html#none
> [^]
> 
> Opinions?

Changes should be documented:

http://wiki.lazarus.freepascal.org/Lazarus_1.6.0_release_notes#IDE_Changes

http://wiki.lazarus.freepascal.org/IDE_Window:_Package_Editor


Mattias

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Package editor in Lazarus 1.6

2016-01-27 Thread Juha Manninen 
On Wed, Jan 27, 2016 at 7:44 PM, Mattias Gaertner
 wrote:
> What bug was fixed with this patch?
> ...
> Changes should be documented:
> http://wiki.lazarus.freepascal.org/Lazarus_1.6.0_release_notes#IDE_Changes

Ok, I added a "Package editor" section there.
Reducing two "Add" buttons to one button was the biggest visible change.
There were many other changes to make it smooth to use. Yes, it uses
my new ModifySilently concept which conflicts with your earlier
concept. Some method names should be fixed but otherwise I still feel
it is an easy and clean way to do it. You should look at it sometime
later.

> http://wiki.lazarus.freepascal.org/IDE_Window:_Package_Editor

Uhhh, that needs more updating. The screenshot must be updated for sure.
I will look at it tomorrow.

Juha

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Package editor in Lazarus 1.6

2016-01-25 Thread Michael Van Canneyt 



On Mon, 25 Jan 2016, Juha Manninen wrote:


Forgot to write earlier...

The package editor has been improved in RC2.
See this + its related issues :
 http://bugs.freepascal.org/view.php?id=28097
The changes were partly inspired by ideas from Michael Van Canneyt and others.
See this mail thread :
http://free-pascal-lazarus.989080.n3.nabble.com/Lazarus-Package-dialog-tt4041400.html#none
[^]

Opinions?

I did not understand the request for a better editor of requirements.
IMO they can be edited very well now.



From my point of view, there are still 2 issues:


First
-

Requirements must still be added one at a time; The requirement dialog shows a 
dropdown.
I usually have lots of requirements. It would be better to have a checklistbox 
where
I can simply check all required packages instead of having to add them one by 
one.

I have easily 10-12 dependencies. Now it is 
- click open the dropdown next to "add"

- select "New requirement"
- Dialog pops up, in dialog select new requirement in combobox.
  There are 180 (!!) packages in the dropdown, it takes a while to select from 
them.
  (lots start with laz, requiring you to type 4 or 5 letters before a 
meaningful choice pops up)
- Click ok.
That's a lot of clicking if you must do this 12 times for a new project and/or 
package.

It would be much easier if, in the dialog, I could select multiple required 
packages
by setting a check mark in a checklistbox. As soon as an item is 
selected/checked, the
min/max version checkboxes/edits can appear enabled to the right of the listbox.



Second
--
If you select a required package in the package dialog, the bottom of the
package dialog shows the min/max required version. This is easy to change it.

In the project dialog, if you select a required package, there is no way to
set the min/max required version. You must delete the requirement, and add
it again, because only during the add you can specify the version.
It would be nice to offer the same functionality as in the package dialog.

As an aside:

I also think it would be nice if the min/max versions were simply shown in
the package tree.

Something like:

laz_fpspreadsheet (>=1.0.0 and <=2.0.0)

But this is a minor issue.

Anyway, I hope the above descriptions are clear. I don't expect these issues
to be addressed in 1.6, but just mention them to say that there is still
lots of room for improvement :-)

Michael.

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

[Lazarus] Package editor in Lazarus 1.6

2016-01-25 Thread Juha Manninen 
Forgot to write earlier...

The package editor has been improved in RC2.
See this + its related issues :
  http://bugs.freepascal.org/view.php?id=28097
The changes were partly inspired by ideas from Michael Van Canneyt and others.
See this mail thread :
 
http://free-pascal-lazarus.989080.n3.nabble.com/Lazarus-Package-dialog-tt4041400.html#none
[^]

Opinions?

I did not understand the request for a better editor of requirements.
IMO they can be edited very well now.

Juha

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus